From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, kishon@ti.com,
vkoul@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings
Date: Fri, 18 Jun 2021 00:30:02 +0200 [thread overview]
Message-ID: <CAFBinCCE8vmMJE-Y0dvGpT+1QFKVN0U9yKinF_2w+644GaXxYg@mail.gmail.com> (raw)
In-Reply-To: <20210616233109.GA285667@robh.at.kernel.org>
Hi Rob,
On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote:
[...]
> > +description: |+
> > + The HDMI TX PHY node should be the child of a syscon node with the
> > + required property:
> > +
> > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"
>
> Is there a sub range of registers for this functionality in
> "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.
yes, for this part of the HHI registers there's a dedicated sub range.
I'll add a reg property with register offset and size
one question about .dts validation: at least the clock controller
(which is also a sub-node of this) does not have a dedicated sub
range.
Is it still OK in this case to set #size-cells = <1> and
#address-cells = <1> in the HHI node?
Best regards,
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, kishon@ti.com,
vkoul@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings
Date: Fri, 18 Jun 2021 00:30:02 +0200 [thread overview]
Message-ID: <CAFBinCCE8vmMJE-Y0dvGpT+1QFKVN0U9yKinF_2w+644GaXxYg@mail.gmail.com> (raw)
In-Reply-To: <20210616233109.GA285667@robh.at.kernel.org>
Hi Rob,
On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote:
[...]
> > +description: |+
> > + The HDMI TX PHY node should be the child of a syscon node with the
> > + required property:
> > +
> > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"
>
> Is there a sub range of registers for this functionality in
> "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.
yes, for this part of the HHI registers there's a dedicated sub range.
I'll add a reg property with register offset and size
one question about .dts validation: at least the clock controller
(which is also a sub-node of this) does not have a dedicated sub
range.
Is it still OK in this case to set #size-cells = <1> and
#address-cells = <1> in the HHI node?
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, kishon@ti.com,
vkoul@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings
Date: Fri, 18 Jun 2021 00:30:02 +0200 [thread overview]
Message-ID: <CAFBinCCE8vmMJE-Y0dvGpT+1QFKVN0U9yKinF_2w+644GaXxYg@mail.gmail.com> (raw)
In-Reply-To: <20210616233109.GA285667@robh.at.kernel.org>
Hi Rob,
On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote:
[...]
> > +description: |+
> > + The HDMI TX PHY node should be the child of a syscon node with the
> > + required property:
> > +
> > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"
>
> Is there a sub range of registers for this functionality in
> "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.
yes, for this part of the HHI registers there's a dedicated sub range.
I'll add a reg property with register offset and size
one question about .dts validation: at least the clock controller
(which is also a sub-node of this) does not have a dedicated sub
range.
Is it still OK in this case to set #size-cells = <1> and
#address-cells = <1> in the HHI node?
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, kishon@ti.com,
vkoul@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings
Date: Fri, 18 Jun 2021 00:30:02 +0200 [thread overview]
Message-ID: <CAFBinCCE8vmMJE-Y0dvGpT+1QFKVN0U9yKinF_2w+644GaXxYg@mail.gmail.com> (raw)
In-Reply-To: <20210616233109.GA285667@robh.at.kernel.org>
Hi Rob,
On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote:
[...]
> > +description: |+
> > + The HDMI TX PHY node should be the child of a syscon node with the
> > + required property:
> > +
> > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"
>
> Is there a sub range of registers for this functionality in
> "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.
yes, for this part of the HHI registers there's a dedicated sub range.
I'll add a reg property with register offset and size
one question about .dts validation: at least the clock controller
(which is also a sub-node of this) does not have a dedicated sub
range.
Is it still OK in this case to set #size-cells = <1> and
#address-cells = <1> in the HHI node?
Best regards,
Martin
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-06-17 22:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 19:03 [PATCH 0/2] phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-16 23:31 ` Rob Herring
2021-06-16 23:31 ` Rob Herring
2021-06-16 23:31 ` Rob Herring
2021-06-16 23:31 ` Rob Herring
2021-06-17 22:30 ` Martin Blumenstingl [this message]
2021-06-17 22:30 ` Martin Blumenstingl
2021-06-17 22:30 ` Martin Blumenstingl
2021-06-17 22:30 ` Martin Blumenstingl
2021-06-04 19:03 ` [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-04 19:03 ` Martin Blumenstingl
2021-06-21 6:18 ` Vinod Koul
2021-06-21 6:18 ` Vinod Koul
2021-06-21 6:18 ` Vinod Koul
2021-06-21 6:18 ` Vinod Koul
2021-06-22 19:57 ` Martin Blumenstingl
2021-06-22 19:57 ` Martin Blumenstingl
2021-06-22 19:57 ` Martin Blumenstingl
2021-06-22 19:57 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCE8vmMJE-Y0dvGpT+1QFKVN0U9yKinF_2w+644GaXxYg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.