From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: robh+dt@kernel.org, f.fainelli@gmail.com,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
jianxin.pan@amlogic.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v2 08/11] net: stmmac: dwmac-meson8b: add support for the RX delay configuration
Date: Fri, 1 May 2020 19:10:06 +0200 [thread overview]
Message-ID: <CAFBinCCbtLRomdikKWkS+HOFoek4cGhN4L91FQfQ4rbKTV-xvg@mail.gmail.com> (raw)
In-Reply-To: <20200501154448.GH128733@lunn.ch>
Hi Andrew,
On Fri, May 1, 2020 at 5:44 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > + if (rx_dly_config & PRG_ETH0_ADJ_ENABLE) {
> > + /* The timing adjustment logic is driven by a separate clock */
> > + ret = meson8b_devm_clk_prepare_enable(dwmac,
> > + dwmac->timing_adj_clk);
> > + if (ret) {
> > + dev_err(dwmac->dev,
> > + "Failed to enable the timing-adjustment clock\n");
> > + return ret;
> > + }
> > + }
>
> Hi Martin
>
> It is a while since i used the clk API. I thought the get_optional()
> call returned a NULL pointer if the clock does not exist.
> clk_prepare_enable() passed a NULL pointer is a NOP, but it also does
> not return an error. So if the clock does not exist, you won't get
> this error, the code keeps going, configures the hardware, but it does
> not work.
>
> I think you need to check dwmac->timing_adj_clk != NULL here, and
> error out if DT has properties which require it.
Thank you for your excellent code review quality (as always)!
you are right and I will fix that in the next version
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
jianxin.pan@amlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-amlogic@lists.infradead.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v2 08/11] net: stmmac: dwmac-meson8b: add support for the RX delay configuration
Date: Fri, 1 May 2020 19:10:06 +0200 [thread overview]
Message-ID: <CAFBinCCbtLRomdikKWkS+HOFoek4cGhN4L91FQfQ4rbKTV-xvg@mail.gmail.com> (raw)
In-Reply-To: <20200501154448.GH128733@lunn.ch>
Hi Andrew,
On Fri, May 1, 2020 at 5:44 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > + if (rx_dly_config & PRG_ETH0_ADJ_ENABLE) {
> > + /* The timing adjustment logic is driven by a separate clock */
> > + ret = meson8b_devm_clk_prepare_enable(dwmac,
> > + dwmac->timing_adj_clk);
> > + if (ret) {
> > + dev_err(dwmac->dev,
> > + "Failed to enable the timing-adjustment clock\n");
> > + return ret;
> > + }
> > + }
>
> Hi Martin
>
> It is a while since i used the clk API. I thought the get_optional()
> call returned a NULL pointer if the clock does not exist.
> clk_prepare_enable() passed a NULL pointer is a NOP, but it also does
> not return an error. So if the clock does not exist, you won't get
> this error, the code keeps going, configures the hardware, but it does
> not work.
>
> I think you need to check dwmac->timing_adj_clk != NULL here, and
> error out if DT has properties which require it.
Thank you for your excellent code review quality (as always)!
you are right and I will fix that in the next version
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
jianxin.pan@amlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-amlogic@lists.infradead.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v2 08/11] net: stmmac: dwmac-meson8b: add support for the RX delay configuration
Date: Fri, 1 May 2020 19:10:06 +0200 [thread overview]
Message-ID: <CAFBinCCbtLRomdikKWkS+HOFoek4cGhN4L91FQfQ4rbKTV-xvg@mail.gmail.com> (raw)
In-Reply-To: <20200501154448.GH128733@lunn.ch>
Hi Andrew,
On Fri, May 1, 2020 at 5:44 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > + if (rx_dly_config & PRG_ETH0_ADJ_ENABLE) {
> > + /* The timing adjustment logic is driven by a separate clock */
> > + ret = meson8b_devm_clk_prepare_enable(dwmac,
> > + dwmac->timing_adj_clk);
> > + if (ret) {
> > + dev_err(dwmac->dev,
> > + "Failed to enable the timing-adjustment clock\n");
> > + return ret;
> > + }
> > + }
>
> Hi Martin
>
> It is a while since i used the clk API. I thought the get_optional()
> call returned a NULL pointer if the clock does not exist.
> clk_prepare_enable() passed a NULL pointer is a NOP, but it also does
> not return an error. So if the clock does not exist, you won't get
> this error, the code keeps going, configures the hardware, but it does
> not work.
>
> I think you need to check dwmac->timing_adj_clk != NULL here, and
> error out if DT has properties which require it.
Thank you for your excellent code review quality (as always)!
you are right and I will fix that in the next version
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-05-01 17:10 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:16 [PATCH RFC v2 00/11] dwmac-meson8b Ethernet RX delay configuration Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` [PATCH RFC v2 01/11] dt-bindings: net: meson-dwmac: Add the amlogic,rx-delay-ns property Martin Blumenstingl
2020-04-29 20:16 ` [PATCH RFC v2 01/11] dt-bindings: net: meson-dwmac: Add the amlogic, rx-delay-ns property Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:26 ` [PATCH RFC v2 01/11] dt-bindings: net: meson-dwmac: Add the amlogic,rx-delay-ns property Andrew Lunn
2020-05-01 15:26 ` Andrew Lunn
2020-05-01 15:26 ` Andrew Lunn
2020-05-12 14:51 ` Rob Herring
2020-05-12 14:51 ` Rob Herring
2020-05-12 14:51 ` Rob Herring
2020-04-29 20:16 ` [PATCH RFC v2 02/11] dt-bindings: net: dwmac-meson: Document the "timing-adjustment" clock Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:27 ` Andrew Lunn
2020-05-01 15:27 ` Andrew Lunn
2020-05-01 15:27 ` Andrew Lunn
2020-05-01 21:09 ` Rob Herring
2020-05-01 21:09 ` Rob Herring
2020-05-01 21:09 ` Rob Herring
2020-05-01 21:53 ` Martin Blumenstingl
2020-05-01 21:53 ` Martin Blumenstingl
2020-05-01 21:53 ` Martin Blumenstingl
2020-05-10 22:34 ` Martin Blumenstingl
2020-05-10 22:34 ` Martin Blumenstingl
2020-05-10 22:34 ` Martin Blumenstingl
2020-04-29 20:16 ` [PATCH RFC v2 03/11] net: stmmac: dwmac-meson8b: use FIELD_PREP instead of open-coding it Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:28 ` Andrew Lunn
2020-05-01 15:28 ` Andrew Lunn
2020-05-01 15:28 ` Andrew Lunn
2020-04-29 20:16 ` [PATCH RFC v2 04/11] net: stmmac: dwmac-meson8b: Move the documentation for the TX delay Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:29 ` Andrew Lunn
2020-05-01 15:29 ` Andrew Lunn
2020-05-01 15:29 ` Andrew Lunn
2020-04-29 20:16 ` [PATCH RFC v2 05/11] net: stmmac: dwmac-meson8b: Add the PRG_ETH0_ADJ_* bits Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:33 ` Andrew Lunn
2020-05-01 15:33 ` Andrew Lunn
2020-05-01 15:33 ` Andrew Lunn
2020-04-29 20:16 ` [PATCH RFC v2 06/11] net: stmmac: dwmac-meson8b: Fetch the "timing-adjustment" clock Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:35 ` Andrew Lunn
2020-05-01 15:35 ` Andrew Lunn
2020-05-01 15:35 ` Andrew Lunn
2020-04-29 20:16 ` [PATCH RFC v2 07/11] net: stmmac: dwmac-meson8b: Make the clock enabling code re-usable Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:37 ` Andrew Lunn
2020-05-01 15:37 ` Andrew Lunn
2020-05-01 15:37 ` Andrew Lunn
2020-04-29 20:16 ` [PATCH RFC v2 08/11] net: stmmac: dwmac-meson8b: add support for the RX delay configuration Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-05-01 15:44 ` Andrew Lunn
2020-05-01 15:44 ` Andrew Lunn
2020-05-01 15:44 ` Andrew Lunn
2020-05-01 17:10 ` Martin Blumenstingl [this message]
2020-05-01 17:10 ` Martin Blumenstingl
2020-05-01 17:10 ` Martin Blumenstingl
2020-04-29 20:16 ` [PATCH DO NOT MERGE v2 09/11] arm64: dts: amlogic: Add the Ethernet "timing-adjustment" clock Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` [PATCH DO NOT MERGE v2 10/11] ARM: dts: meson: " Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` [PATCH DO NOT MERGE v2 11/11] ARM: dts: meson: Switch existing boards with RGMII PHY to "rgmii-id" Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 20:16 ` Martin Blumenstingl
2020-04-29 21:29 ` [PATCH RFC v2 00/11] dwmac-meson8b Ethernet RX delay configuration Andrew Lunn
2020-04-29 21:29 ` Andrew Lunn
2020-04-29 21:29 ` Andrew Lunn
2020-05-01 14:49 ` Martin Blumenstingl
2020-05-01 14:49 ` Martin Blumenstingl
2020-05-01 14:49 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCbtLRomdikKWkS+HOFoek4cGhN4L91FQfQ4rbKTV-xvg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.