From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Dongjin Kim <tobetter@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
Date: Sat, 28 Aug 2021 18:11:59 +0200 [thread overview]
Message-ID: <CAFBinCDLmmtKztpoj5xvhwdagrH_7nJK7qUA+LOg7CWB5eCFRQ@mail.gmail.com> (raw)
In-Reply-To: <YScKYFWlYymgGw3l@anyang-linuxfactory-or-kr>
Hi,
Thanks for this patch!
my first suggestion is about the patch subject (first line):
arm64: dts: meson-sm1-odroid: add Ethernet PHY reset for ODROID-C4/HC4
This makes it match the pattern of the most recent commits there:
45d736ab17b4 arm64: dts: meson-sm1-odroid: add 5v regulator gpio
7881df513680 arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as
open source
On Thu, Aug 26, 2021 at 5:29 AM Dongjin Kim <tobetter@gmail.com> wrote:
>
> This patch is to fix an issue that the ethernet link doesn't come up
> when using ip link set down/up:
> [ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down
> [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31)
> [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma
> [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed
> [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
>
> This fix has been referred two commits applied for ODROID-N2 (G12B).
> commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line")
> commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements")
I am not 100% sure but I think you can just add two "Fixes: ..." tags here
That way this patch is also backported automatically
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Dongjin Kim <tobetter@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
Date: Sat, 28 Aug 2021 18:11:59 +0200 [thread overview]
Message-ID: <CAFBinCDLmmtKztpoj5xvhwdagrH_7nJK7qUA+LOg7CWB5eCFRQ@mail.gmail.com> (raw)
In-Reply-To: <YScKYFWlYymgGw3l@anyang-linuxfactory-or-kr>
Hi,
Thanks for this patch!
my first suggestion is about the patch subject (first line):
arm64: dts: meson-sm1-odroid: add Ethernet PHY reset for ODROID-C4/HC4
This makes it match the pattern of the most recent commits there:
45d736ab17b4 arm64: dts: meson-sm1-odroid: add 5v regulator gpio
7881df513680 arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as
open source
On Thu, Aug 26, 2021 at 5:29 AM Dongjin Kim <tobetter@gmail.com> wrote:
>
> This patch is to fix an issue that the ethernet link doesn't come up
> when using ip link set down/up:
> [ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down
> [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31)
> [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma
> [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed
> [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
>
> This fix has been referred two commits applied for ODROID-N2 (G12B).
> commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line")
> commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements")
I am not 100% sure but I think you can just add two "Fixes: ..." tags here
That way this patch is also backported automatically
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Dongjin Kim <tobetter@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
Date: Sat, 28 Aug 2021 18:11:59 +0200 [thread overview]
Message-ID: <CAFBinCDLmmtKztpoj5xvhwdagrH_7nJK7qUA+LOg7CWB5eCFRQ@mail.gmail.com> (raw)
In-Reply-To: <YScKYFWlYymgGw3l@anyang-linuxfactory-or-kr>
Hi,
Thanks for this patch!
my first suggestion is about the patch subject (first line):
arm64: dts: meson-sm1-odroid: add Ethernet PHY reset for ODROID-C4/HC4
This makes it match the pattern of the most recent commits there:
45d736ab17b4 arm64: dts: meson-sm1-odroid: add 5v regulator gpio
7881df513680 arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as
open source
On Thu, Aug 26, 2021 at 5:29 AM Dongjin Kim <tobetter@gmail.com> wrote:
>
> This patch is to fix an issue that the ethernet link doesn't come up
> when using ip link set down/up:
> [ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down
> [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31)
> [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma
> [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed
> [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
>
> This fix has been referred two commits applied for ODROID-N2 (G12B).
> commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line")
> commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements")
I am not 100% sure but I think you can just add two "Fixes: ..." tags here
That way this patch is also backported automatically
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-28 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 3:28 [PATCH] arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4 Dongjin Kim
2021-08-26 3:28 ` Dongjin Kim
2021-08-26 3:28 ` Dongjin Kim
2021-08-28 16:11 ` Martin Blumenstingl [this message]
2021-08-28 16:11 ` Martin Blumenstingl
2021-08-28 16:11 ` Martin Blumenstingl
2021-09-13 7:48 ` Neil Armstrong
2021-09-13 7:48 ` Neil Armstrong
2021-09-13 7:48 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCDLmmtKztpoj5xvhwdagrH_7nJK7qUA+LOg7CWB5eCFRQ@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.