From: Oded Gabbay <oded.gabbay@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: ongoing writecombine on ppc
Date: Thu, 21 Jan 2016 17:24:41 +0200 [thread overview]
Message-ID: <CAFCwf12BFYJZj168hfMn9ycYtguqX_oHUvgF+odUenZt=1u9PQ@mail.gmail.com> (raw)
In-Reply-To: <1443761773.2828.70.camel@kernel.crashing.org>
On Fri, Oct 2, 2015 at 7:56 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Fri, 2015-10-02 at 14:53 +1000, Dave Airlie wrote:
>> On 2 October 2015 at 14:45, Benjamin Herrenschmidt
>> <benh@kernel.crashing.org> wrote:
>> > On Fri, 2015-10-02 at 14:42 +1000, Dave Airlie wrote:
>> > > I don't think we resolved this the last time we talked about it,
>> > >
>> > > but radeon writecombine maps fail hard on ppc, I think all the
>> > > fixes
>> > > either did something bad to AGP systems or weren't liked.
>> > >
>> > > My patch attached just fixes radeon, which is where I'm still
>> > > seeing
>> > > the issue.
>> >
>> > Yes, you MUST NOT set the flags of system memory to anything other
>> > than
>> > fully cachable on any cache coherent powerpc machine. This should
>> > be
>> > bolted into the DRM core imho.
>> >
>>
>> Except you guys screwed up and allowed AGP to exist on Power, and
>> that requires it.
>
> Well, Apple did :-) Yes, AGP should never have existed in the first
> place, I think that's a given :)
>
>> So we have to keep the AGP trapdoor in place, and at the moment only
>> the drivers know if they are AGP, hence why I had to add this in the
>> driver instead of in the drm core.
> Cheers,
> Ben.
>
>
>
Bumping this and adding my r-b:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-21 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 4:42 ongoing writecombine on ppc Dave Airlie
2015-10-02 4:45 ` Benjamin Herrenschmidt
2015-10-02 4:47 ` Benjamin Herrenschmidt
2015-10-02 4:50 ` Benjamin Herrenschmidt
2015-10-02 4:53 ` Dave Airlie
2015-10-02 4:56 ` Benjamin Herrenschmidt
2016-01-21 15:24 ` Oded Gabbay [this message]
2016-01-21 15:39 ` Oded Gabbay
2016-01-21 17:10 ` Alex Deucher
2016-01-22 2:32 ` Michel Dänzer
2016-01-28 14:30 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFCwf12BFYJZj168hfMn9ycYtguqX_oHUvgF+odUenZt=1u9PQ@mail.gmail.com' \
--to=oded.gabbay@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.