Re: [Qemu-devel] [PATCH v2 5/9] i.MX: Add i.MX6 CCM and ANALOG device.

From: Peter Maydell <peter.maydell@linaro.org>
To: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/9] i.MX: Add i.MX6 CCM and ANALOG device.
Date: Mon, 29 Feb 2016 17:33:17 +0000	[thread overview]
Message-ID: <CAFEAcA-f7+AgnymzOaiUMEFzW_JE4=NCpamZttOy9XFmEVBmyw@mail.gmail.com> (raw)
In-Reply-To: <421b9f9121d8707bd38c6bdbadd9a736263129bb.1454967766.git.jcd@tribudubois.net>

On 8 February 2016 at 22:08, Jean-Christophe Dubois <jcd@tribudubois.net> wrote:
> Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
> ---

> +static uint64_t imx6_ccm_read(void *opaque, hwaddr offset, unsigned size)
> +{
> +    uint32 value = 0;

This should be 'uint32_t', not 'uint32'.

(You'll find this doesn't compile on current master if you rebase it;
uint32 was a type intended only for use with the softfloat code, and
we've just eliminated it.)

Similar issues in imx6_src_read() and imx_spi_read().

You also need to make sure all your new .c files have #include "qemu/osdep.h"
as the first include they do, or they won't build on current master.

thanks
-- PMM