From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Linus Walleij <linus.walleij@linaro.org>,
Linux API <linux-api@vger.kernel.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Florian Weimer <fw@deneb.enyo.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andy Lutomirski <luto@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode
Date: Mon, 20 Apr 2020 16:29:32 +0100 [thread overview]
Message-ID: <CAFEAcA9BQQah2vVfnwO4-3m4eHv9QtfvjvDpTdw+SmqicsDOMA@mail.gmail.com> (raw)
In-Reply-To: <d3fb73a3-ecf6-6371-783f-24a94eb66c59@redhat.com>
On Mon, 20 Apr 2020 at 16:24, Eric Blake <eblake@redhat.com> wrote:
> It will be interesting to find how much code (wrongly) assumes it can
> use a blind assignment of fcntl(fd, F_SETFD, 1) and thereby accidentally
> wipes out other existing flags, when it should have instead been doing a
> read-modify-write to protect flags other than FD_CLOEXEC.
For instance, a quick grep shows 4 instances of this in QEMU :-)
thanks
-- PMM
WARNING: multiple messages have this Message-ID (diff)
From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Linux API <linux-api@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Florian Weimer <fw@deneb.enyo.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andy Lutomirski <luto@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode
Date: Mon, 20 Apr 2020 16:29:32 +0100 [thread overview]
Message-ID: <CAFEAcA9BQQah2vVfnwO4-3m4eHv9QtfvjvDpTdw+SmqicsDOMA@mail.gmail.com> (raw)
In-Reply-To: <d3fb73a3-ecf6-6371-783f-24a94eb66c59@redhat.com>
On Mon, 20 Apr 2020 at 16:24, Eric Blake <eblake@redhat.com> wrote:
> It will be interesting to find how much code (wrongly) assumes it can
> use a blind assignment of fcntl(fd, F_SETFD, 1) and thereby accidentally
> wipes out other existing flags, when it should have instead been doing a
> read-modify-write to protect flags other than FD_CLOEXEC.
For instance, a quick grep shows 4 instances of this in QEMU :-)
thanks
-- PMM
next prev parent reply other threads:[~2020-04-20 15:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 13:35 [PATCH] fcntl: Add 32bit filesystem mode Linus Walleij
2020-03-31 13:35 ` Linus Walleij
2020-04-20 11:19 ` Peter Maydell
2020-04-20 11:19 ` Peter Maydell
2020-04-20 11:23 ` Florian Weimer
2020-04-20 11:23 ` Florian Weimer
2020-04-20 11:38 ` Peter Maydell
2020-04-20 11:38 ` Peter Maydell
2020-04-20 14:16 ` Peter Maydell
2020-04-20 14:16 ` Peter Maydell
2020-04-20 23:51 ` Andreas Dilger
2020-04-20 23:51 ` Andreas Dilger
2020-04-21 13:02 ` Peter Maydell
2020-04-21 13:02 ` Peter Maydell
2020-04-20 15:13 ` Theodore Y. Ts'o
2020-04-20 15:13 ` Theodore Y. Ts'o
2020-04-20 15:23 ` Eric Blake
2020-04-20 15:29 ` Peter Maydell [this message]
2020-04-20 15:29 ` Peter Maydell
2020-04-20 17:01 ` Theodore Y. Ts'o
2020-04-20 17:01 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9BQQah2vVfnwO4-3m4eHv9QtfvjvDpTdw+SmqicsDOMA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=adilger.kernel@dilger.ca \
--cc=eblake@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.