Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported

From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
	"Radoslaw Biernacki" <rad@semihalf.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-s390x <qemu-s390x@nongnu.org>, "Greg Kurz" <groug@kaod.org>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Leif Lindholm" <leif@nuviainc.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"David Hildenbrand" <david@redhat.com>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported
Date: Fri, 19 Feb 2021 11:55:56 +0000	[thread overview]
Message-ID: <CAFEAcA_66DuWfrftpaodqBZwBhS-VOD9uH=KwvGYC_VcksVFAA@mail.gmail.com> (raw)
In-Reply-To: <20210219114428.1936109-1-philmd@redhat.com>

On Fri, 19 Feb 2021 at 11:44, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> This series aims to improve user experience by providing
> a better error message when the user tries to enable KVM
> on machines not supporting it.

Thanks for having a look at this; fixing the ugly assertion
failure if you try to enable KVM for the raspi boards has
been vaguely on my todo list but never made it up to the top...

> Philippe Mathieu-Daudé (7):
>   accel/kvm: Check MachineClass kvm_type() return value
>   hw/boards: Introduce 'kvm_supported' field to MachineClass
>   hw/arm: Set kvm_supported for KVM-compatible machines
>   hw/mips: Set kvm_supported for KVM-compatible machines
>   hw/ppc: Set kvm_supported for KVM-compatible machines
>   hw/s390x: Set kvm_supported to s390-ccw-virtio machines
>   accel/kvm: Exit gracefully when KVM is not supported

Don't we also need to set kvm_supported for the relevant
machine types in hw/i386 ?

thanks
-- PMM