From: Alexandre Mergnat <amergnat@baylibre.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Chaotian Jing" <chaotian.jing@mediatek.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Wenbin Mei" <wenbin.mei@mediatek.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org,
"Alexandre Bailon" <abailon@baylibre.com>,
"Fabien Parent" <fparent@baylibre.com>,
"Amjad Ouled-Ameur" <aouledameur@baylibre.com>
Subject: Re: [PATCH v3 16/17] arm64: dts: mediatek: fix systimer properties
Date: Fri, 31 Mar 2023 14:05:20 +0200 [thread overview]
Message-ID: <CAFGrd9oPKn84yK2VpfJQRd1HbBTwq87Fuc6=Uw3uaeLjm89=8w@mail.gmail.com> (raw)
In-Reply-To: <8c917be2-e15a-921f-aaa9-b8753d2463de@gmail.com>
Hi Matthias
Le jeu. 30 mars 2023 à 19:34, Matthias Brugger
<matthias.bgg@gmail.com> a écrit :
>
>
>
> On 29/03/2023 10:54, amergnat@baylibre.com wrote:
> > From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> >
> > MT8365 has a SYST timer (System Timer), therefore the compatible node
> > should be "mediatek,mt6765-timer" instead of "mediatek,mt6795-systimer"
> > (which corresponds to ARM/ARM64 System Timer).
> >
> > Plus, register range should be 0x100 instead of 0x10.
> >
> > Finally, interrupt polarity of systimer is LEVEL_HIGH.
> >
> > Fix the above properties accordingly.
> >
> > Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>
> Patch looks good but does not apply cleanly because of previous patches that I
> didn't take and need rework. Please resend the patches I didn't queue with the
> comments addressed.
Sorry for that, I forgot to drop this patch since it has been already
fixed in the Bero's series [1]
I will drop it for the next version
[1]: https://lore.kernel.org/all/20230309213501.794764-4-bero@baylibre.com/
Regards,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Mergnat <amergnat@baylibre.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Chaotian Jing" <chaotian.jing@mediatek.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Wenbin Mei" <wenbin.mei@mediatek.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org,
"Alexandre Bailon" <abailon@baylibre.com>,
"Fabien Parent" <fparent@baylibre.com>,
"Amjad Ouled-Ameur" <aouledameur@baylibre.com>
Subject: Re: [PATCH v3 16/17] arm64: dts: mediatek: fix systimer properties
Date: Fri, 31 Mar 2023 14:05:20 +0200 [thread overview]
Message-ID: <CAFGrd9oPKn84yK2VpfJQRd1HbBTwq87Fuc6=Uw3uaeLjm89=8w@mail.gmail.com> (raw)
In-Reply-To: <8c917be2-e15a-921f-aaa9-b8753d2463de@gmail.com>
Hi Matthias
Le jeu. 30 mars 2023 à 19:34, Matthias Brugger
<matthias.bgg@gmail.com> a écrit :
>
>
>
> On 29/03/2023 10:54, amergnat@baylibre.com wrote:
> > From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> >
> > MT8365 has a SYST timer (System Timer), therefore the compatible node
> > should be "mediatek,mt6765-timer" instead of "mediatek,mt6795-systimer"
> > (which corresponds to ARM/ARM64 System Timer).
> >
> > Plus, register range should be 0x100 instead of 0x10.
> >
> > Finally, interrupt polarity of systimer is LEVEL_HIGH.
> >
> > Fix the above properties accordingly.
> >
> > Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>
> Patch looks good but does not apply cleanly because of previous patches that I
> didn't take and need rework. Please resend the patches I didn't queue with the
> comments addressed.
Sorry for that, I forgot to drop this patch since it has been already
fixed in the Bero's series [1]
I will drop it for the next version
[1]: https://lore.kernel.org/all/20230309213501.794764-4-bero@baylibre.com/
Regards,
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-31 12:05 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 8:54 [PATCH v3 00/17] Improve the MT8365 SoC and EVK board support Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 01/17] dt-bindings: watchdog: mediatek,mtk-wdt: add mt8365 Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-30 17:16 ` Matthias Brugger
2023-03-30 17:16 ` Matthias Brugger
2023-04-16 15:52 ` Guenter Roeck
2023-04-16 15:52 ` Guenter Roeck
2023-03-29 8:54 ` [PATCH v3 02/17] dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-30 17:17 ` Matthias Brugger
2023-03-30 17:17 ` Matthias Brugger
2023-03-31 8:24 ` Krzysztof Kozlowski
2023-03-31 8:24 ` Krzysztof Kozlowski
2023-03-29 8:54 ` [PATCH v3 03/17] arm64: dts: mediatek: Increase the size BL31 reserved memory amergnat
2023-03-29 8:54 ` amergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-30 17:20 ` Matthias Brugger
2023-03-30 17:20 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 04/17] arm64: dts: mediatek: add watchdog support for mt8365 SoC Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 05/17] arm64: dts: mediatek: add mt6357 device-tree amergnat
2023-03-29 8:54 ` amergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-30 17:22 ` Matthias Brugger
2023-03-30 17:22 ` Matthias Brugger
2023-03-31 9:41 ` Alexandre Mergnat
2023-03-31 9:41 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 06/17] arm64: dts: mediatek: add pwrap support to mt8365 SoC Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:19 ` AngeloGioacchino Del Regno
2023-03-29 13:19 ` AngeloGioacchino Del Regno
2023-03-30 17:22 ` Matthias Brugger
2023-03-30 17:22 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 07/17] arm64: dts: mediatek: add mt6357 PMIC support for mt8365-evk Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:20 ` AngeloGioacchino Del Regno
2023-03-29 13:20 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 08/17] arm64: dts: mediatek: add mmc support for mt8365 SoC Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:21 ` AngeloGioacchino Del Regno
2023-03-29 13:21 ` AngeloGioacchino Del Regno
2023-03-30 17:28 ` Matthias Brugger
2023-03-30 17:28 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 09/17] arm64: dts: mediatek: add mmc support for mt8365-evk Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:24 ` AngeloGioacchino Del Regno
2023-03-29 13:24 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 10/17] arm64: dts: mediatek: set vmc regulator as always on amergnat
2023-03-29 8:54 ` amergnat
2023-03-29 13:25 ` AngeloGioacchino Del Regno
2023-03-29 13:25 ` AngeloGioacchino Del Regno
2023-03-31 11:08 ` Alexandre Mergnat
2023-03-31 11:08 ` Alexandre Mergnat
2023-03-31 11:23 ` Alexandre Mergnat
2023-03-31 11:23 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 11/17] arm64: dts: mediatek: add usb controller support for mt8365-evk Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:26 ` AngeloGioacchino Del Regno
2023-03-29 13:26 ` AngeloGioacchino Del Regno
2023-03-30 17:30 ` Matthias Brugger
2023-03-30 17:30 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 12/17] arm64: dts: mediatek: add ethernet support for mt8365 SoC Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:27 ` AngeloGioacchino Del Regno
2023-03-29 13:27 ` AngeloGioacchino Del Regno
2023-03-30 17:31 ` Matthias Brugger
2023-03-30 17:31 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 13/17] arm64: dts: mediatek: add ethernet support for mt8365-evk Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 14/17] arm64: dts: mediatek: add OPP support for mt8365 SoC Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:28 ` AngeloGioacchino Del Regno
2023-03-29 13:28 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 15/17] arm64: dts: mediatek: add cpufreq support for mt8365-evk Alexandre Mergnat
2023-03-29 8:54 ` Alexandre Mergnat
2023-03-29 13:28 ` AngeloGioacchino Del Regno
2023-03-29 13:28 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 16/17] arm64: dts: mediatek: fix systimer properties amergnat
2023-03-29 8:54 ` amergnat
2023-03-29 13:29 ` AngeloGioacchino Del Regno
2023-03-29 13:29 ` AngeloGioacchino Del Regno
2023-03-30 17:34 ` Matthias Brugger
2023-03-30 17:34 ` Matthias Brugger
2023-03-31 12:05 ` Alexandre Mergnat [this message]
2023-03-31 12:05 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 17/17] arm64: dts: mediatek: Add CPU Idle support amergnat
2023-03-29 8:54 ` amergnat
2023-03-29 13:31 ` AngeloGioacchino Del Regno
2023-03-29 13:31 ` AngeloGioacchino Del Regno
2023-03-30 0:09 ` [PATCH v3 00/17] Improve the MT8365 SoC and EVK board support Kevin Hilman
2023-03-30 0:09 ` Kevin Hilman
2023-03-30 9:54 ` Alexandre Mergnat
2023-03-30 9:54 ` Alexandre Mergnat
2023-03-30 20:56 ` Kevin Hilman
2023-03-30 20:56 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFGrd9oPKn84yK2VpfJQRd1HbBTwq87Fuc6=Uw3uaeLjm89=8w@mail.gmail.com' \
--to=amergnat@baylibre.com \
--cc=abailon@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aouledameur@baylibre.com \
--cc=bero@baylibre.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
--cc=wim@linux-watchdog.org \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.