From: Alexandre Mergnat <amergnat@baylibre.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: "Daniel Vetter" <daniel@ffwll.ch>, "CK Hu" <ck.hu@mediatek.com>,
"Jitao Shi" <jitao.shi@mediatek.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Xinlei Lee" <xinlei.lee@mediatek.com>,
"Guillaume La Roque" <glaroque@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
"Fabien Parent" <fparent@baylibre.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365
Date: Wed, 15 Mar 2023 10:26:23 +0100 [thread overview]
Message-ID: <CAFGrd9qVhJb--COXJmGHuW6NxDnXZGdQnxbHGRvaA5Jqhx-yNg@mail.gmail.com> (raw)
In-Reply-To: <CAAOTY_819JuuidLgTOm+Ps=WnueW0Quos+abEDjrx8q8GifGKA@mail.gmail.com>
Hi Chun-Kuang,
Le lun. 13 mars 2023 à 16:17, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
>
> Hi, Alexandre:
>
> Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道：
> >
> > From: Fabien Parent <fparent@baylibre.com>
> >
> > DPI for MT8365 is compatible with MT8192 but requires an additional
> > clock. Modify the documentation to requires this clock only on MT8365 SoCs.
>
> If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
> I think some part of MT8165 DPI works under the speed control by the
> DPI clock and this is different with MT8192 DPI, how could these two
> are compatible?
AFAII, The mtk_dpi driver manage the 4th clock as optional
dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
And all configuration variables for mt8192 are the same for mt8365.
These configuration clock variables (like cal_factor) aren't
correlated with the 4th clock.
The clock number doesn't impact the configuration variable because the
4th clock is simply retrieved from DTS, saved in the driver structure
and prepare/unprepare/enable/disable, like other clocks.
Regards,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Mergnat <amergnat@baylibre.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: "Neil Armstrong" <neil.armstrong@linaro.org>,
"Jitao Shi" <jitao.shi@mediatek.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Fabien Parent" <fparent@baylibre.com>,
linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linux-pwm@vger.kernel.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Guillaume La Roque" <glaroque@baylibre.com>,
dri-devel@lists.freedesktop.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-mediatek@lists.infradead.org,
"Sam Ravnborg" <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org,
"Xinlei Lee" <xinlei.lee@mediatek.com>
Subject: Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365
Date: Wed, 15 Mar 2023 10:26:23 +0100 [thread overview]
Message-ID: <CAFGrd9qVhJb--COXJmGHuW6NxDnXZGdQnxbHGRvaA5Jqhx-yNg@mail.gmail.com> (raw)
In-Reply-To: <CAAOTY_819JuuidLgTOm+Ps=WnueW0Quos+abEDjrx8q8GifGKA@mail.gmail.com>
Hi Chun-Kuang,
Le lun. 13 mars 2023 à 16:17, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
>
> Hi, Alexandre:
>
> Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道：
> >
> > From: Fabien Parent <fparent@baylibre.com>
> >
> > DPI for MT8365 is compatible with MT8192 but requires an additional
> > clock. Modify the documentation to requires this clock only on MT8365 SoCs.
>
> If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
> I think some part of MT8165 DPI works under the speed control by the
> DPI clock and this is different with MT8192 DPI, how could these two
> are compatible?
AFAII, The mtk_dpi driver manage the 4th clock as optional
dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
And all configuration variables for mt8192 are the same for mt8365.
These configuration clock variables (like cal_factor) aren't
correlated with the 4th clock.
The clock number doesn't impact the configuration variable because the
4th clock is simply retrieved from DTS, saved in the driver structure
and prepare/unprepare/enable/disable, like other clocks.
Regards,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Mergnat <amergnat@baylibre.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: "Daniel Vetter" <daniel@ffwll.ch>, "CK Hu" <ck.hu@mediatek.com>,
"Jitao Shi" <jitao.shi@mediatek.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Xinlei Lee" <xinlei.lee@mediatek.com>,
"Guillaume La Roque" <glaroque@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
"Fabien Parent" <fparent@baylibre.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365
Date: Wed, 15 Mar 2023 10:26:23 +0100 [thread overview]
Message-ID: <CAFGrd9qVhJb--COXJmGHuW6NxDnXZGdQnxbHGRvaA5Jqhx-yNg@mail.gmail.com> (raw)
In-Reply-To: <CAAOTY_819JuuidLgTOm+Ps=WnueW0Quos+abEDjrx8q8GifGKA@mail.gmail.com>
Hi Chun-Kuang,
Le lun. 13 mars 2023 à 16:17, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
>
> Hi, Alexandre:
>
> Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道：
> >
> > From: Fabien Parent <fparent@baylibre.com>
> >
> > DPI for MT8365 is compatible with MT8192 but requires an additional
> > clock. Modify the documentation to requires this clock only on MT8365 SoCs.
>
> If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
> I think some part of MT8165 DPI works under the speed control by the
> DPI clock and this is different with MT8192 DPI, how could these two
> are compatible?
AFAII, The mtk_dpi driver manage the 4th clock as optional
dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
And all configuration variables for mt8192 are the same for mt8365.
These configuration clock variables (like cal_factor) aren't
correlated with the 4th clock.
The clock number doesn't impact the configuration variable because the
4th clock is simply retrieved from DTS, saved in the driver structure
and prepare/unprepare/enable/disable, like other clocks.
Regards,
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-15 9:26 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 14:22 [PATCH 00/21] Add display support for the MT8365-EVK board Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:41 ` Krzysztof Kozlowski
2023-03-10 8:41 ` Krzysztof Kozlowski
2023-03-10 8:41 ` Krzysztof Kozlowski
2023-03-13 15:02 ` Chun-Kuang Hu
2023-03-13 15:02 ` Chun-Kuang Hu
2023-03-13 15:02 ` Chun-Kuang Hu
2023-03-31 14:55 ` Matthias Brugger
2023-03-31 14:55 ` Matthias Brugger
2023-03-31 14:55 ` Matthias Brugger
2023-04-03 3:25 ` Chun-Kuang Hu
2023-04-03 3:25 ` Chun-Kuang Hu
2023-04-03 3:25 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 02/21] dt-bindings: display: mediatek: ccorr: " Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:29 ` Krzysztof Kozlowski
2023-03-10 8:29 ` Krzysztof Kozlowski
2023-03-10 8:29 ` Krzysztof Kozlowski
2023-03-13 14:54 ` Chun-Kuang Hu
2023-03-13 14:54 ` Chun-Kuang Hu
2023-03-13 14:54 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 03/21] dt-bindings: display: mediatek: color: " Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-13 14:58 ` Chun-Kuang Hu
2023-03-13 14:58 ` Chun-Kuang Hu
2023-03-13 14:58 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 04/21] dt-bindings: display: mediatek: dither: " Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-13 14:59 ` Chun-Kuang Hu
2023-03-13 14:59 ` Chun-Kuang Hu
2023-03-13 14:59 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 05/21] dt-bindings: display: mediatek: dsi: " Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-13 15:00 ` Chun-Kuang Hu
2023-03-13 15:00 ` Chun-Kuang Hu
2023-03-13 15:00 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 06/21] dt-bindings: display: mediatek: dpi: add power-domains property Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365 Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:17 ` Chun-Kuang Hu
2023-03-13 15:17 ` Chun-Kuang Hu
2023-03-13 15:17 ` Chun-Kuang Hu
2023-03-15 9:26 ` Alexandre Mergnat [this message]
2023-03-15 9:26 ` Alexandre Mergnat
2023-03-15 9:26 ` Alexandre Mergnat
2023-03-09 14:22 ` [PATCH 08/21] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:07 ` Chun-Kuang Hu
2023-03-13 15:07 ` Chun-Kuang Hu
2023-03-13 15:07 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 09/21] dt-bindings: display: mediatek: ovl: " Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:08 ` Chun-Kuang Hu
2023-03-13 15:08 ` Chun-Kuang Hu
2023-03-13 15:08 ` Chun-Kuang Hu
2023-03-09 14:22 ` [PATCH 10/21] dt-bindings: display: mediatek: rdma: " Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-09 14:22 ` Alexandre Mergnat
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:09 ` Chun-Kuang Hu
2023-03-13 15:09 ` Chun-Kuang Hu
2023-03-13 15:09 ` Chun-Kuang Hu
2023-03-09 14:23 ` [PATCH 11/21] dt-bindings: display: pannel: add startek kd070fhfid015 binding documentation Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` [PATCH 12/21] dt-bindings: pwm: add power-domains property Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` [PATCH 13/21] dt-bindings: pwm: add binding for mt8365 SoC Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-09 14:23 ` [PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-31 14:42 ` Matthias Brugger
2023-03-31 14:42 ` Matthias Brugger
2023-03-31 14:42 ` Matthias Brugger
2023-03-09 14:23 ` [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-10 8:39 ` Krzysztof Kozlowski
2023-03-10 8:39 ` Krzysztof Kozlowski
2023-03-10 8:39 ` Krzysztof Kozlowski
2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 8:17 ` Alexandre Mergnat
2023-03-15 8:17 ` Alexandre Mergnat
2023-03-15 8:17 ` Alexandre Mergnat
2023-03-15 13:17 ` Krzysztof Kozlowski
2023-03-15 13:17 ` Krzysztof Kozlowski
2023-03-15 13:17 ` Krzysztof Kozlowski
2023-03-15 13:22 ` Krzysztof Kozlowski
2023-03-15 13:22 ` Krzysztof Kozlowski
2023-03-15 13:22 ` Krzysztof Kozlowski
2023-03-31 17:51 ` Matthias Brugger
2023-03-31 17:51 ` Matthias Brugger
2023-03-31 17:51 ` Matthias Brugger
2023-03-09 14:23 ` [PATCH 16/21] arm64: dts: mediatek: add display blocks support for the " Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` [PATCH 17/21] arm64: dts: mediatek: add display support for mt8365-evk Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` [PATCH 18/21] drm/mediatek: dsi: Improves the DSI lane setup robustness Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-27 15:37 ` Chun-Kuang Hu
2023-03-27 15:37 ` Chun-Kuang Hu
2023-03-27 15:37 ` Chun-Kuang Hu
2023-03-09 14:23 ` [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-13 15:21 ` Chun-Kuang Hu
2023-03-13 15:21 ` Chun-Kuang Hu
2023-03-13 15:21 ` Chun-Kuang Hu
2023-03-15 9:35 ` Alexandre Mergnat
2023-03-15 9:35 ` Alexandre Mergnat
2023-03-15 9:35 ` Alexandre Mergnat
2023-03-15 14:17 ` Chun-Kuang Hu
2023-03-15 14:17 ` Chun-Kuang Hu
2023-03-15 14:17 ` Chun-Kuang Hu
2023-03-09 14:23 ` [PATCH 20/21] drm/mediatek: add MT8365 SoC support Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:23 ` Alexandre Mergnat
2023-03-09 14:51 ` Neil Armstrong
2023-03-09 14:51 ` Neil Armstrong
2023-03-09 14:51 ` Neil Armstrong
2023-03-15 15:59 ` Alexandre Mergnat
2023-03-15 15:59 ` Alexandre Mergnat
2023-03-15 15:59 ` Alexandre Mergnat
2023-03-15 17:12 ` neil.armstrong
2023-03-15 17:12 ` neil.armstrong
2023-03-15 17:12 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFGrd9qVhJb--COXJmGHuW6NxDnXZGdQnxbHGRvaA5Jqhx-yNg@mail.gmail.com \
--to=amergnat@baylibre.com \
--cc=airlied@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fparent@baylibre.com \
--cc=glaroque@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.