From: Brendan Higgins <brendanhiggins@google.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Andrew Jeffery <andrew@aj.id.au>, Jeremy Kerr <jk@ozlabs.org>,
Alistar Popple <alistair@popple.id.au>,
Eddie James <eajames@linux.ibm.com>,
linux-um <linux-um@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Gow <davidgow@google.com>,
linux-fsi@lists.ozlabs.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 16:30:03 -0800 [thread overview]
Message-ID: <CAFd5g45MFYMK-eZWPC5fhm2OkynUXKfArUVhbanYVH+qKRUwPg@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XctCb9Q2RaFVHEDuWxKDXpCWMWs-+vnKZ=SeTa3xRnT_g@mail.gmail.com>
On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@jms.id.au> wrote:
>
> On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@google.com> wrote:
> >
> > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the unspecified dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> order to build some ARM drivers under UM. Do you have plans to fix
> that too?
The only broken configs I found for UML are all listed on the cover
letter of this patch. I think fixing COMPILE_TEST on UM could be
worthwhile. Did you see any brokenness other than what I mentioned on
the cover letter?
> Do you want to get this in a fix for 5.5?
Preferably, yes.
> Acked-by: Joel Stanley <joel@jms.id.au>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Joel Stanley <joel@jms.id.au>
Cc: linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
Eddie James <eajames@linux.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-um <linux-um@lists.infradead.org>,
Jeremy Kerr <jk@ozlabs.org>, David Gow <davidgow@google.com>,
Alistar Popple <alistair@popple.id.au>,
linux-fsi@lists.ozlabs.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>
Subject: Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 16:30:03 -0800 [thread overview]
Message-ID: <CAFd5g45MFYMK-eZWPC5fhm2OkynUXKfArUVhbanYVH+qKRUwPg@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XctCb9Q2RaFVHEDuWxKDXpCWMWs-+vnKZ=SeTa3xRnT_g@mail.gmail.com>
On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@jms.id.au> wrote:
>
> On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@google.com> wrote:
> >
> > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the unspecified dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> order to build some ARM drivers under UM. Do you have plans to fix
> that too?
The only broken configs I found for UML are all listed on the cover
letter of this patch. I think fixing COMPILE_TEST on UM could be
worthwhile. Did you see any brokenness other than what I mentioned on
the cover letter?
> Do you want to get this in a fix for 5.5?
Preferably, yes.
> Acked-by: Joel Stanley <joel@jms.id.au>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-12 0:30 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
2019-12-16 8:42 ` Linus Walleij
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 10:39 ` Linus Walleij
2019-12-16 10:39 ` Linus Walleij
2020-01-23 22:15 ` Brendan Higgins
2020-01-23 22:15 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal
2020-01-09 15:23 ` Miquel Raynal
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal
2020-01-25 15:28 ` Miquel Raynal
2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
2020-01-30 19:55 ` Brendan Higgins
2020-01-30 19:55 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
2019-12-20 7:07 ` Herbert Xu
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
2019-12-12 19:36 ` LABBE Corentin
2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
2019-12-20 7:07 ` Herbert Xu
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-14 11:28 ` Greg Kroah-Hartman
2019-12-14 11:28 ` Greg Kroah-Hartman
2019-12-14 11:28 ` Greg Kroah-Hartman
2020-01-23 22:16 ` Brendan Higgins
2020-01-23 22:16 ` Brendan Higgins
2020-01-23 22:16 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:30 ` Brendan Higgins [this message]
2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
2020-01-27 9:46 ` Brendan Higgins
2020-01-31 3:43 ` Joel Stanley
2020-01-31 3:43 ` Joel Stanley
2019-12-11 20:06 ` [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Johannes Berg
2019-12-12 0:35 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g45MFYMK-eZWPC5fhm2OkynUXKfArUVhbanYVH+qKRUwPg@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davidgow@google.com \
--cc=eajames@linux.ibm.com \
--cc=jdike@addtoit.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.