From: Brendan Higgins <brendanhiggins@google.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alan Maguire <alan.maguire@oracle.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Arnd Bergmann <arnd@arndb.de>, David Gow <davidgow@google.com>,
Jeff Dike <jdike@addtoit.com>, Kees Cook <keescook@chromium.org>,
Richard Weinberger <richard@nod.at>,
rppt@linux.ibm.com, Shuah Khan <skhan@linuxfoundation.org>,
Iurii Zaikin <yzaikin@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
Logan Gunthorpe <logang@deltatee.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Knut Omang <knut.omang@oracle.com>,
linux-um <linux-um@lists.infradead.org>,
linux-arch@vger.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v1 4/6] init: main: add KUnit to kernel init
Date: Thu, 23 Jan 2020 14:45:43 -0800 [thread overview]
Message-ID: <CAFd5g47=FxbKtm9rA3zKvnipdTdP_VR8zJ3pad-QukL5Ottrjw@mail.gmail.com> (raw)
In-Reply-To: <20191217075836.C76942072D@mail.kernel.org>
Sorry for the late reply. I sent this thinking I would check in over
vacation, and then didn't.
On Mon, Dec 16, 2019 at 11:58 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Brendan Higgins (2019-12-16 14:05:53)
> > Remove KUnit from init calls entirely, instead call directly from
> > kernel_init().
>
> Yes, but why? Is it desired to run the unit tests earlier than opening
> the console or something?
I want to make sure it is called after late_init is done (so that you
can test things initialized in late_init). And I want to make sure it
runs before init*fs is loaded so that there is a mechanism to run
tests without having to put a userland together.
> > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
> > index 978086cfd257d..ca880224c0bab 100644
> > --- a/lib/kunit/executor.c
> > +++ b/lib/kunit/executor.c
> > @@ -32,12 +32,10 @@ static bool kunit_run_all_tests(void)
> > return !has_test_failed;
> > }
> >
> > -static int kunit_executor_init(void)
> > +int kunit_executor_init(void)
>
> Should be marked __init? Even before this patch presumably.
Just this function? No strong opinion.
If by "before this patch" you mean other stuff in this patchset?
> > {
> > if (kunit_run_all_tests())
> > return 0;
> > else
> > return -EFAULT;
> > }
> > -
> > -late_initcall(kunit_executor_init);
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alan Maguire <alan.maguire@oracle.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Arnd Bergmann <arnd@arndb.de>, David Gow <davidgow@google.com>,
Jeff Dike <jdike@addtoit.com>, Kees Cook <keescook@chromium.org>,
Richard Weinberger <richard@nod.at>,
rppt@linux.ibm.com, Shuah Khan <skhan@linuxfoundation.org>,
Iurii Zaikin <yzaikin@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
Logan Gunthorpe <logang@deltatee.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Knut Omang <knut.omang@oracle.com>,
linux-um <linux-um@lists.infradead.org>,
linux-arch@vger.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux
Subject: Re: [RFC v1 4/6] init: main: add KUnit to kernel init
Date: Thu, 23 Jan 2020 14:45:43 -0800 [thread overview]
Message-ID: <CAFd5g47=FxbKtm9rA3zKvnipdTdP_VR8zJ3pad-QukL5Ottrjw@mail.gmail.com> (raw)
In-Reply-To: <20191217075836.C76942072D@mail.kernel.org>
Sorry for the late reply. I sent this thinking I would check in over
vacation, and then didn't.
On Mon, Dec 16, 2019 at 11:58 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Brendan Higgins (2019-12-16 14:05:53)
> > Remove KUnit from init calls entirely, instead call directly from
> > kernel_init().
>
> Yes, but why? Is it desired to run the unit tests earlier than opening
> the console or something?
I want to make sure it is called after late_init is done (so that you
can test things initialized in late_init). And I want to make sure it
runs before init*fs is loaded so that there is a mechanism to run
tests without having to put a userland together.
> > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
> > index 978086cfd257d..ca880224c0bab 100644
> > --- a/lib/kunit/executor.c
> > +++ b/lib/kunit/executor.c
> > @@ -32,12 +32,10 @@ static bool kunit_run_all_tests(void)
> > return !has_test_failed;
> > }
> >
> > -static int kunit_executor_init(void)
> > +int kunit_executor_init(void)
>
> Should be marked __init? Even before this patch presumably.
Just this function? No strong opinion.
If by "before this patch" you mean other stuff in this patchset?
> > {
> > if (kunit_run_all_tests())
> > return 0;
> > else
> > return -EFAULT;
> > }
> > -
> > -late_initcall(kunit_executor_init);
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arch@vger.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>, Knut Omang <knut.omang@oracle.com>,
Luis Chamberlain <mcgrof@kernel.org>,
rppt@linux.ibm.com, linux-um <linux-um@lists.infradead.org>,
Logan Gunthorpe <logang@deltatee.com>,
KUnit Development <kunit-dev@googlegroups.com>,
David Gow <davidgow@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Iurii Zaikin <yzaikin@google.com>,
Alan Maguire <alan.maguire@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>
Subject: Re: [RFC v1 4/6] init: main: add KUnit to kernel init
Date: Thu, 23 Jan 2020 14:45:43 -0800 [thread overview]
Message-ID: <CAFd5g47=FxbKtm9rA3zKvnipdTdP_VR8zJ3pad-QukL5Ottrjw@mail.gmail.com> (raw)
In-Reply-To: <20191217075836.C76942072D@mail.kernel.org>
Sorry for the late reply. I sent this thinking I would check in over
vacation, and then didn't.
On Mon, Dec 16, 2019 at 11:58 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Brendan Higgins (2019-12-16 14:05:53)
> > Remove KUnit from init calls entirely, instead call directly from
> > kernel_init().
>
> Yes, but why? Is it desired to run the unit tests earlier than opening
> the console or something?
I want to make sure it is called after late_init is done (so that you
can test things initialized in late_init). And I want to make sure it
runs before init*fs is loaded so that there is a mechanism to run
tests without having to put a userland together.
> > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
> > index 978086cfd257d..ca880224c0bab 100644
> > --- a/lib/kunit/executor.c
> > +++ b/lib/kunit/executor.c
> > @@ -32,12 +32,10 @@ static bool kunit_run_all_tests(void)
> > return !has_test_failed;
> > }
> >
> > -static int kunit_executor_init(void)
> > +int kunit_executor_init(void)
>
> Should be marked __init? Even before this patch presumably.
Just this function? No strong opinion.
If by "before this patch" you mean other stuff in this patchset?
> > {
> > if (kunit_run_all_tests())
> > return 0;
> > else
> > return -EFAULT;
> > }
> > -
> > -late_initcall(kunit_executor_init);
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-01-23 22:45 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 22:05 [RFC v1 0/6] kunit: create a centralized executor to dispatch all KUnit tests Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-16 22:05 ` [RFC v1 1/6] vmlinux.lds.h: add linker section for KUnit test suites Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-17 8:21 ` Stephen Boyd
2019-12-17 8:21 ` Stephen Boyd
2019-12-17 8:21 ` Stephen Boyd
2019-12-16 22:05 ` [RFC v1 2/6] arch: um: " Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-17 8:21 ` Stephen Boyd
2019-12-17 8:21 ` Stephen Boyd
2019-12-17 8:21 ` Stephen Boyd
2019-12-16 22:05 ` [RFC v1 3/6] kunit: test: create a single centralized executor for all tests Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-17 8:04 ` Stephen Boyd
2019-12-17 8:04 ` Stephen Boyd
2019-12-17 8:04 ` Stephen Boyd
2020-01-23 22:54 ` Brendan Higgins
2020-01-23 22:54 ` Brendan Higgins
2020-01-23 22:54 ` Brendan Higgins
2020-01-23 22:54 ` Brendan Higgins
2019-12-16 22:05 ` [RFC v1 4/6] init: main: add KUnit to kernel init Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-17 7:58 ` Stephen Boyd
2019-12-17 7:58 ` Stephen Boyd
2019-12-17 7:58 ` Stephen Boyd
2020-01-23 22:45 ` Brendan Higgins [this message]
2020-01-23 22:45 ` Brendan Higgins
2020-01-23 22:45 ` Brendan Higgins
2020-01-23 22:45 ` Brendan Higgins
2019-12-16 22:05 ` [RFC v1 5/6] kunit: test: add test plan to KUnit TAP format Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-17 8:18 ` Stephen Boyd
2019-12-17 8:18 ` Stephen Boyd
2019-12-17 8:18 ` Stephen Boyd
2019-12-16 22:05 ` [RFC v1 6/6] kunit: Add 'kunit_shutdown' option Brendan Higgins
2019-12-16 22:05 ` Brendan Higgins
2019-12-17 8:06 ` Stephen Boyd
2019-12-17 8:06 ` Stephen Boyd
2019-12-17 8:06 ` Stephen Boyd
2020-01-23 22:56 ` Brendan Higgins
2020-01-23 22:56 ` Brendan Higgins
2020-01-23 22:56 ` Brendan Higgins
2020-01-23 22:56 ` Brendan Higgins
2020-01-06 22:40 ` [RFC v1 0/6] kunit: create a centralized executor to dispatch all KUnit tests Luis Chamberlain
2020-01-06 22:40 ` Luis Chamberlain
2020-01-23 22:40 ` Brendan Higgins
2020-01-23 22:40 ` Brendan Higgins
2020-01-23 22:40 ` Brendan Higgins
2020-01-23 22:40 ` Brendan Higgins
2020-01-27 17:40 ` Frank Rowand
2020-01-27 17:40 ` Frank Rowand
2020-01-27 17:40 ` Frank Rowand
2020-01-27 17:40 ` Frank Rowand
2020-01-28 7:19 ` Brendan Higgins
2020-01-28 7:19 ` Brendan Higgins
2020-01-28 7:19 ` Brendan Higgins
2020-01-28 7:19 ` Brendan Higgins
2020-01-28 18:36 ` Frank Rowand
2020-01-28 18:36 ` Frank Rowand
2020-01-28 18:36 ` Frank Rowand
2020-01-28 18:36 ` Frank Rowand
2020-01-28 19:35 ` Tim.Bird
2020-01-28 19:35 ` Tim.Bird
2020-01-28 19:35 ` Tim.Bird
2020-01-28 19:53 ` Brendan Higgins
2020-01-28 19:53 ` Brendan Higgins
2020-01-28 19:53 ` Brendan Higgins
2020-01-28 19:53 ` Brendan Higgins
2020-01-29 4:24 ` Frank Rowand
2020-01-29 4:24 ` Frank Rowand
2020-01-29 4:24 ` Frank Rowand
2020-01-29 4:24 ` Frank Rowand
2020-01-29 21:18 ` Brendan Higgins
2020-01-29 21:18 ` Brendan Higgins
2020-01-29 21:18 ` Brendan Higgins
2020-01-29 21:18 ` Brendan Higgins
2020-01-29 13:06 ` Alan Maguire
2020-01-29 13:06 ` Alan Maguire
2020-01-29 13:06 ` Alan Maguire
2020-01-29 13:06 ` Alan Maguire
2020-01-29 21:28 ` Brendan Higgins
2020-01-29 21:28 ` Brendan Higgins
2020-01-29 21:28 ` Brendan Higgins
2020-01-29 21:28 ` Brendan Higgins
2020-03-02 19:45 ` Luis Chamberlain
2020-03-02 19:45 ` Luis Chamberlain
2020-03-02 19:45 ` Luis Chamberlain
2020-03-02 19:45 ` Luis Chamberlain
2020-03-02 19:05 ` Luis Chamberlain
2020-03-02 19:05 ` Luis Chamberlain
2020-03-02 19:05 ` Luis Chamberlain
2020-03-02 19:05 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g47=FxbKtm9rA3zKvnipdTdP_VR8zJ3pad-QukL5Ottrjw@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=akpm@linux-foundation.org \
--cc=alan.maguire@oracle.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=keescook@chromium.org \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=mcgrof@kernel.org \
--cc=richard@nod.at \
--cc=rppt@linux.ibm.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.