From: John Snow <jsnow@redhat.com>
To: Wainer Moschetta <wainersm@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 09/12] python: add 'make check-dev' invocation
Date: Tue, 29 Jun 2021 13:43:25 -0400 [thread overview]
Message-ID: <CAFn=p-bOtBupzBnTNaav3iSTB1Roaidk4c5WsGAoEDLCStG6eA@mail.gmail.com> (raw)
In-Reply-To: <a63f357e-42c4-5385-fa40-82f291efac71@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2113 bytes --]
On Tue, Jun 29, 2021 at 1:34 PM Wainer dos Santos Moschetta <
wainersm@redhat.com> wrote:
>
> On 6/29/21 1:42 PM, John Snow wrote:
> > This is a *third* way to run the Python tests. Unlike the first two
> > (check-pipenv, check-tox), this version does not require any specific
> > interpreter version -- making it a lot easier to tell people to run it
> > as a quick smoketest prior to submission to GitLab CI.
> >
> > Summary:
> >
> > Checked via GitLab CI:
> > - check-pipenv: tests our oldest python & dependencies
> > - check-tox: tests newest dependencies on all non-EOL python
> versions
> > Executed only incidentally:
> > - check-dev: tests newest dependencies on whichever python version
> >
> > ('make check' does not set up any environment at all, it just runs the
> > tests in your current environment. All four invocations perform the
> > exact same tests, just in different execution environments.)
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > python/Makefile | 35 +++++++++++++++++++++++++++++++++--
> > 1 file changed, 33 insertions(+), 2 deletions(-)
> >
> > diff --git a/python/Makefile b/python/Makefile
> > index d34c4e35d9..8f8e1999c0 100644
> > --- a/python/Makefile
> > +++ b/python/Makefile
> > @@ -1,3 +1,5 @@
> > +QEMU_VENV_DIR=.dev-venv
> > +
>
> I gave `make check-dev` a try and `tests/flake8.sh` failed, because it
> is checking the python sources from the $QEMU_VENV_DIR itself.
>
> Either we keep $QEMU_VENV_DIR outside (as in the v1 series) or ...
>
> diff --git a/python/tests/flake8.sh b/python/tests/flake8.sh
> index 51e0788462..1cd7d40fad 100755
> --- a/python/tests/flake8.sh
> +++ b/python/tests/flake8.sh
> @@ -1,2 +1,2 @@
> #!/bin/sh -e
> -python3 -m flake8
> +python3 -m flake8 qemu/
>
> ... to ensure flake8 parses only the files from the 'qemu' directory
> (btw, this is how tests/pylint.sh is configured). I prefer the later.
>
Augh, oops. Good spot ...
OK, i'll just update the canonical flake8 invocation instead. I can remove
the .venv and .tox stuff in the flake8 section in setup.cfg, too.
[-- Attachment #2: Type: text/html, Size: 2835 bytes --]
next prev parent reply other threads:[~2021-06-29 17:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 16:42 [PATCH v2 00/12] Python: packaging cleanups John Snow
2021-06-29 16:42 ` [PATCH v2 01/12] python: expose typing information via PEP 561 John Snow
2021-06-29 16:42 ` [PATCH v2 02/12] python: Remove global pylint suppressions John Snow
2021-06-29 16:42 ` [PATCH v2 03/12] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-06-29 16:42 ` [PATCH v2 04/12] python: README.rst touchups John Snow
2021-06-29 16:42 ` [PATCH v2 05/12] python: Add no-install usage instructions John Snow
2021-06-29 16:42 ` [PATCH v2 06/12] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-06-29 16:42 ` [PATCH v2 07/12] python: update help text for check-tox John Snow
2021-06-29 16:51 ` Wainer dos Santos Moschetta
2021-06-29 20:23 ` Wainer dos Santos Moschetta
2021-06-29 21:27 ` John Snow
2021-06-30 18:55 ` Wainer dos Santos Moschetta
2021-06-29 16:42 ` [PATCH v2 08/12] python: Fix .PHONY Make specifiers John Snow
2021-06-29 16:53 ` Wainer dos Santos Moschetta
2021-06-29 18:06 ` Willian Rampazzo
2021-06-29 16:42 ` [PATCH v2 09/12] python: add 'make check-dev' invocation John Snow
2021-06-29 17:34 ` Wainer dos Santos Moschetta
2021-06-29 17:43 ` John Snow [this message]
2021-06-29 16:42 ` [PATCH v2 10/12] python: Update help text on 'make check', 'make develop' John Snow
2021-06-29 16:42 ` [PATCH v2 11/12] python: Update help text on 'make clean', 'make distclean' John Snow
2021-06-29 16:42 ` [PATCH v2 12/12] python: remove auto-generated pyproject.toml file John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-bOtBupzBnTNaav3iSTB1Roaidk4c5WsGAoEDLCStG6eA@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.