From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 08/12] python: Fix .PHONY Make specifiers
Date: Tue, 29 Jun 2021 13:53:30 -0300 [thread overview]
Message-ID: <fc0a7a03-8893-5083-4929-2d493f2bd629@redhat.com> (raw)
In-Reply-To: <20210629164253.1272763-9-jsnow@redhat.com>
On 6/29/21 1:42 PM, John Snow wrote:
> I missed the 'check-tox' target. Add that, but split the large .PHONY
> specifier at the top into its component pieces and move them near the
> targets they describe so that they're much harder to forget to update.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/Makefile | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
I didn't know .PHONY could be split. Nice!
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/python/Makefile b/python/Makefile
> index d2cfa6ad8f..d34c4e35d9 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -1,5 +1,4 @@
> -.PHONY: help pipenv check-pipenv check clean distclean develop
> -
> +.PHONY: help
> help:
> @echo "python packaging help:"
> @echo ""
> @@ -29,25 +28,32 @@ help:
> @echo " built distribution files, and everything"
> @echo " from 'make clean'."
>
> +.PHONY: pipenv
> pipenv: .venv
> .venv: Pipfile.lock
> @PIPENV_VENV_IN_PROJECT=1 pipenv sync --dev --keep-outdated
> @touch .venv
>
> +.PHONY: check-pipenv
> check-pipenv: pipenv
> @pipenv run make check
>
> +.PHONY: develop
> develop:
> pip3 install -e .[devel]
>
> +.PHONY: check
> check:
> @avocado --config avocado.cfg run tests/
>
> +.PHONY: check-tox
> check-tox:
> @tox
>
> +.PHONY: clean
> clean:
> python3 setup.py clean --all
>
> +.PHONY: distclean
> distclean: clean
> rm -rf qemu.egg-info/ .venv/ .tox/ dist/
next prev parent reply other threads:[~2021-06-29 16:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 16:42 [PATCH v2 00/12] Python: packaging cleanups John Snow
2021-06-29 16:42 ` [PATCH v2 01/12] python: expose typing information via PEP 561 John Snow
2021-06-29 16:42 ` [PATCH v2 02/12] python: Remove global pylint suppressions John Snow
2021-06-29 16:42 ` [PATCH v2 03/12] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-06-29 16:42 ` [PATCH v2 04/12] python: README.rst touchups John Snow
2021-06-29 16:42 ` [PATCH v2 05/12] python: Add no-install usage instructions John Snow
2021-06-29 16:42 ` [PATCH v2 06/12] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-06-29 16:42 ` [PATCH v2 07/12] python: update help text for check-tox John Snow
2021-06-29 16:51 ` Wainer dos Santos Moschetta
2021-06-29 20:23 ` Wainer dos Santos Moschetta
2021-06-29 21:27 ` John Snow
2021-06-30 18:55 ` Wainer dos Santos Moschetta
2021-06-29 16:42 ` [PATCH v2 08/12] python: Fix .PHONY Make specifiers John Snow
2021-06-29 16:53 ` Wainer dos Santos Moschetta [this message]
2021-06-29 18:06 ` Willian Rampazzo
2021-06-29 16:42 ` [PATCH v2 09/12] python: add 'make check-dev' invocation John Snow
2021-06-29 17:34 ` Wainer dos Santos Moschetta
2021-06-29 17:43 ` John Snow
2021-06-29 16:42 ` [PATCH v2 10/12] python: Update help text on 'make check', 'make develop' John Snow
2021-06-29 16:42 ` [PATCH v2 11/12] python: Update help text on 'make clean', 'make distclean' John Snow
2021-06-29 16:42 ` [PATCH v2 12/12] python: remove auto-generated pyproject.toml file John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc0a7a03-8893-5083-4929-2d493f2bd629@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.