From: Enric Balletbo Serra <eballetbo@gmail.com> To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Cc: Linux Media Mailing List <linux-media@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Collabora Kernel ML <kernel@collabora.com>, dafna3@gmail.com, Mauro Carvalho Chehab <mchehab@kernel.org>, Tomasz Figa <tfiga@chromium.org>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Minghsiu Tsai <minghsiu.tsai@mediatek.com>, Houlong Wei <houlong.wei@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Tiffany Lin <tiffany.lin@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Alexandre Courbot <acourbot@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Eizan Miyamoto <eizan@chromium.org> Subject: Re: [PATCH] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Date: Wed, 14 Jul 2021 16:03:56 +0200 [thread overview] Message-ID: <CAFqH_52s0qtPT5SE1BUQrsrwg1XB7hLSExeC-ER5nTggKaeeOA@mail.gmail.com> (raw) In-Reply-To: <20210714134850.402-1-dafna.hirschfeld@collabora.com> Hi Dafna, Thank you for working on this and sending the patch to upstream for further discussion. Missatge de Dafna Hirschfeld <dafna.hirschfeld@collabora.com> del dia dc., 14 de jul. 2021 a les 15:49: > > From: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Sorry to confuse you, but I'm not the author of this patch, my from is only here because I shared with you that patch that I really picked from a discussion that took place here: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2251840 It'd be really nice to continue the discussion here and set a proper fix and understand better the root cause and the fix. The patch really fixes an issue in mainline for mtk-vcodec driver on the mt8173 devices, I can confirm that without it doesn't work properly. Waiting for your thoughts, Enric > When running memcpy_toio: > memcpy_toio(send_obj->share_buf, buf, len); > it was found that errors appear if len is not a multiple of 8: > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > This patch ensure copy of a multile of 8 size by calling > round_up(len, 8) when copying > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.") > Reported-by: Alexandre Courbot <acourbot@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- > drivers/media/platform/mtk-vpu/mtk_vpu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c > index ec290dde59cf..b464d8192119 100644 > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > @@ -316,6 +316,7 @@ int vpu_ipi_send(struct platform_device *pdev, > { > struct mtk_vpu *vpu = platform_get_drvdata(pdev); > struct share_obj __iomem *send_obj = vpu->send_buf; > + unsigned char data[SHARE_BUF_SIZE]; > unsigned long timeout; > int ret = 0; > > @@ -349,7 +350,9 @@ int vpu_ipi_send(struct platform_device *pdev, > } > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > - memcpy_toio(send_obj->share_buf, buf, len); > + memset(data, 0, sizeof(data)); > + memcpy(data, buf, len); > + memcpy_toio(send_obj->share_buf, data, round_up(len, 8)); > writel(len, &send_obj->len); > writel(id, &send_obj->id); > > -- > 2.17.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Enric Balletbo Serra <eballetbo@gmail.com> To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Cc: Linux Media Mailing List <linux-media@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Collabora Kernel ML <kernel@collabora.com>, dafna3@gmail.com, Mauro Carvalho Chehab <mchehab@kernel.org>, Tomasz Figa <tfiga@chromium.org>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Minghsiu Tsai <minghsiu.tsai@mediatek.com>, Houlong Wei <houlong.wei@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Tiffany Lin <tiffany.lin@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Alexandre Courbot <acourbot@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Eizan Miyamoto <eizan@chromium.org> Subject: Re: [PATCH] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Date: Wed, 14 Jul 2021 16:03:56 +0200 [thread overview] Message-ID: <CAFqH_52s0qtPT5SE1BUQrsrwg1XB7hLSExeC-ER5nTggKaeeOA@mail.gmail.com> (raw) In-Reply-To: <20210714134850.402-1-dafna.hirschfeld@collabora.com> Hi Dafna, Thank you for working on this and sending the patch to upstream for further discussion. Missatge de Dafna Hirschfeld <dafna.hirschfeld@collabora.com> del dia dc., 14 de jul. 2021 a les 15:49: > > From: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Sorry to confuse you, but I'm not the author of this patch, my from is only here because I shared with you that patch that I really picked from a discussion that took place here: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2251840 It'd be really nice to continue the discussion here and set a proper fix and understand better the root cause and the fix. The patch really fixes an issue in mainline for mtk-vcodec driver on the mt8173 devices, I can confirm that without it doesn't work properly. Waiting for your thoughts, Enric > When running memcpy_toio: > memcpy_toio(send_obj->share_buf, buf, len); > it was found that errors appear if len is not a multiple of 8: > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > This patch ensure copy of a multile of 8 size by calling > round_up(len, 8) when copying > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.") > Reported-by: Alexandre Courbot <acourbot@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- > drivers/media/platform/mtk-vpu/mtk_vpu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c > index ec290dde59cf..b464d8192119 100644 > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > @@ -316,6 +316,7 @@ int vpu_ipi_send(struct platform_device *pdev, > { > struct mtk_vpu *vpu = platform_get_drvdata(pdev); > struct share_obj __iomem *send_obj = vpu->send_buf; > + unsigned char data[SHARE_BUF_SIZE]; > unsigned long timeout; > int ret = 0; > > @@ -349,7 +350,9 @@ int vpu_ipi_send(struct platform_device *pdev, > } > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > - memcpy_toio(send_obj->share_buf, buf, len); > + memset(data, 0, sizeof(data)); > + memcpy(data, buf, len); > + memcpy_toio(send_obj->share_buf, data, round_up(len, 8)); > writel(len, &send_obj->len); > writel(id, &send_obj->id); > > -- > 2.17.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-07-14 14:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-14 13:48 [PATCH] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Dafna Hirschfeld 2021-07-14 13:48 ` Dafna Hirschfeld 2021-07-14 14:03 ` Enric Balletbo Serra [this message] 2021-07-14 14:03 ` Enric Balletbo Serra 2021-07-20 12:33 ` Hans Verkuil 2021-07-20 12:33 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFqH_52s0qtPT5SE1BUQrsrwg1XB7hLSExeC-ER5nTggKaeeOA@mail.gmail.com \ --to=eballetbo@gmail.com \ --cc=acourbot@chromium.org \ --cc=andrew-ct.chen@mediatek.com \ --cc=dafna.hirschfeld@collabora.com \ --cc=dafna3@gmail.com \ --cc=eizan@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=houlong.wei@mediatek.com \ --cc=hsinyi@chromium.org \ --cc=hverkuil@xs4all.nl \ --cc=kernel@collabora.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=minghsiu.tsai@mediatek.com \ --cc=tfiga@chromium.org \ --cc=tiffany.lin@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.