From: Souptick Joarder <jrdr.linux@gmail.com> To: adaplas@gmail.com, b.zolnierkie@samsung.com Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sabyasachi Gupta <sabyasachi.linux@gmail.com> Subject: Re: [PATCH] video: fbdev: nvidia: Remove dead code Date: Mon, 22 Jul 2019 13:56:51 +0530 [thread overview] Message-ID: <CAFqt6zaNcNdxcT2WLOvL0LTX_R9ShRNx6UW6s4k+wc=Zj2MaSg@mail.gmail.com> (raw) In-Reply-To: <1562782586-3994-1-git-send-email-jrdr.linux@gmail.com> On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder <jrdr.linux@gmail.com> wrote: > > This is dead code since 3.15. If there is no plan to use it > further, this can be removed forever. Any comment on this patch ? > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c > index b17acd2..2fa6866 100644 > --- a/drivers/video/fbdev/nvidia/nv_setup.c > +++ b/drivers/video/fbdev/nvidia/nv_setup.c > @@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par) > { > return (VGA_RD08(par->PVIO, VGA_MIS_R)); > } > -#if 0 > -void NVEnablePalette(struct nvidia_par *par) > -{ > - volatile u8 tmp; > - > - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); > - VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00); > - par->paletteEnabled = 1; > -} > -void NVDisablePalette(struct nvidia_par *par) > -{ > - volatile u8 tmp; > - > - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); > - VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20); > - par->paletteEnabled = 0; > -} > -#endif /* 0 */ > void NVWriteDacMask(struct nvidia_par *par, u8 value) > { > VGA_WR08(par->PDIO, VGA_PEL_MSK, value); > } > -#if 0 > -u8 NVReadDacMask(struct nvidia_par *par) > -{ > - return (VGA_RD08(par->PDIO, VGA_PEL_MSK)); > -} > -#endif /* 0 */ > void NVWriteDacReadAddr(struct nvidia_par *par, u8 value) > { > VGA_WR08(par->PDIO, VGA_PEL_IR, value); > -- > 1.9.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com> To: adaplas@gmail.com, b.zolnierkie@samsung.com Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sabyasachi Gupta <sabyasachi.linux@gmail.com> Subject: Re: [PATCH] video: fbdev: nvidia: Remove dead code Date: Mon, 22 Jul 2019 08:38:51 +0000 [thread overview] Message-ID: <CAFqt6zaNcNdxcT2WLOvL0LTX_R9ShRNx6UW6s4k+wc=Zj2MaSg@mail.gmail.com> (raw) In-Reply-To: <1562782586-3994-1-git-send-email-jrdr.linux@gmail.com> On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder <jrdr.linux@gmail.com> wrote: > > This is dead code since 3.15. If there is no plan to use it > further, this can be removed forever. Any comment on this patch ? > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c > index b17acd2..2fa6866 100644 > --- a/drivers/video/fbdev/nvidia/nv_setup.c > +++ b/drivers/video/fbdev/nvidia/nv_setup.c > @@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par) > { > return (VGA_RD08(par->PVIO, VGA_MIS_R)); > } > -#if 0 > -void NVEnablePalette(struct nvidia_par *par) > -{ > - volatile u8 tmp; > - > - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); > - VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00); > - par->paletteEnabled = 1; > -} > -void NVDisablePalette(struct nvidia_par *par) > -{ > - volatile u8 tmp; > - > - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); > - VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20); > - par->paletteEnabled = 0; > -} > -#endif /* 0 */ > void NVWriteDacMask(struct nvidia_par *par, u8 value) > { > VGA_WR08(par->PDIO, VGA_PEL_MSK, value); > } > -#if 0 > -u8 NVReadDacMask(struct nvidia_par *par) > -{ > - return (VGA_RD08(par->PDIO, VGA_PEL_MSK)); > -} > -#endif /* 0 */ > void NVWriteDacReadAddr(struct nvidia_par *par, u8 value) > { > VGA_WR08(par->PDIO, VGA_PEL_IR, value); > -- > 1.9.1 >
next prev parent reply other threads:[~2019-07-22 8:27 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-10 18:16 [PATCH] video: fbdev: nvidia: Remove dead code Souptick Joarder 2019-07-10 18:28 ` Souptick Joarder 2019-07-22 8:26 ` Souptick Joarder [this message] 2019-07-22 8:38 ` Souptick Joarder 2019-07-23 15:36 ` Bartlomiej Zolnierkiewicz 2019-07-23 15:36 ` Bartlomiej Zolnierkiewicz 2019-07-23 15:36 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFqt6zaNcNdxcT2WLOvL0LTX_R9ShRNx6UW6s4k+wc=Zj2MaSg@mail.gmail.com' \ --to=jrdr.linux@gmail.com \ --cc=adaplas@gmail.com \ --cc=b.zolnierkie@samsung.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sabyasachi.linux@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.