From: Cheng-yi Chiang <cychiang@chromium.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
Oder Chiou <oder_chiou@realtek.com>,
Bard Liao <bardliao@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Matthias Kaehlcke <mka@chromium.org>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"
Date: Tue, 19 Dec 2017 15:38:30 +0800 [thread overview]
Message-ID: <CAFv8Nw+bcVSugD5hEBj7nQSg3VGj2E+ROpzf+5LxexEmFoX=oA@mail.gmail.com> (raw)
In-Reply-To: <20171218174235.GA113663@google.com>
Hi Brian, I am sorry for not using the plain text mode in the previous mail.
I agree with you on other points.
On Tue, Dec 19, 2017 at 1:42 AM, Brian Norris <briannorris@chromium.org> wrote:
> Hi!
>
> (By the way, your mail is HTML and likely will get rejected by many
> mailing lists and/or people reading these mailing lists.)
>
> On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote:
>> Hi Brian,
>> Oder has posted the same fix : [1]https://patchwork.kernel.org/
>> patch/10066257/ and it has been applied.
>
> OK cool. Obviously I'm biased, but I prefer mine, as it has less
> needless whitespace, and is appropriately documented ;) But it should be
> a fine replacement.
>
>> Perhaps you can cherry-pick it to v4.15 ?
>
> I have no say in that; that would be up to Mark, I think. It's most
> certainly a regression in 4.15-rc1, so IMO it should be given a proper
> 'Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule
> data copy in resume function")' tag and sent for 4.15, not 4.16.
>
> Brian
WARNING: multiple messages have this Message-ID (diff)
From: Cheng-yi Chiang <cychiang@chromium.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-rockchip@lists.infradead.org,
Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"
Date: Tue, 19 Dec 2017 15:38:30 +0800 [thread overview]
Message-ID: <CAFv8Nw+bcVSugD5hEBj7nQSg3VGj2E+ROpzf+5LxexEmFoX=oA@mail.gmail.com> (raw)
In-Reply-To: <20171218174235.GA113663@google.com>
Hi Brian, I am sorry for not using the plain text mode in the previous mail.
I agree with you on other points.
On Tue, Dec 19, 2017 at 1:42 AM, Brian Norris <briannorris@chromium.org> wrote:
> Hi!
>
> (By the way, your mail is HTML and likely will get rejected by many
> mailing lists and/or people reading these mailing lists.)
>
> On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote:
>> Hi Brian,
>> Oder has posted the same fix : [1]https://patchwork.kernel.org/
>> patch/10066257/ and it has been applied.
>
> OK cool. Obviously I'm biased, but I prefer mine, as it has less
> needless whitespace, and is appropriately documented ;) But it should be
> a fine replacement.
>
>> Perhaps you can cherry-pick it to v4.15 ?
>
> I have no say in that; that would be up to Mark, I think. It's most
> certainly a regression in 4.15-rc1, so IMO it should be given a proper
> 'Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule
> data copy in resume function")' tag and sent for 4.15, not 4.16.
>
> Brian
next prev parent reply other threads:[~2017-12-19 7:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 1:12 [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached" Brian Norris
2017-12-16 1:12 ` Brian Norris
2017-12-16 3:17 ` Brian Norris
2017-12-16 3:17 ` Brian Norris
2017-12-18 4:23 ` Cheng-yi Chiang
2017-12-18 17:42 ` Brian Norris
2017-12-18 17:42 ` Brian Norris
2017-12-19 7:38 ` Cheng-yi Chiang [this message]
2017-12-19 7:38 ` Cheng-yi Chiang
2017-12-19 10:58 ` Mark Brown
2017-12-19 10:58 ` Mark Brown
2017-12-19 17:31 ` Brian Norris
2018-01-24 15:36 ` Applied "ASoC: rt5514-spi: Check the validity of drvdata pointer on resume" to the asoc tree Mark Brown
2018-01-24 15:36 ` Mark Brown
2018-01-24 15:47 ` Mark Brown
2018-01-24 17:07 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFv8Nw+bcVSugD5hEBj7nQSg3VGj2E+ROpzf+5LxexEmFoX=oA@mail.gmail.com' \
--to=cychiang@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=jeffy.chen@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.