From: Daniel Kurtz <djkurtz@chromium.org> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>, Kevin Hilman <khilman@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-mediatek@lists.infradead.org, Sasha Hauer <kernel@pengutronix.de>, Matthias Brugger <matthias.bgg@gmail.com> Subject: Re: [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Date: Fri, 15 May 2015 22:17:43 +0800 [thread overview] Message-ID: <CAGS+omAWBHMgY45qrqU-ERDEniscoJ+NgVWVjT=kTKMHPdWyEw@mail.gmail.com> (raw) In-Reply-To: <1431349882-12260-5-git-send-email-s.hauer@pengutronix.de> On Mon, May 11, 2015 at 9:11 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > This adds the SCPSYS device node to the MT8173 dtsi file. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 924fdb6..3c569b5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -125,6 +125,18 @@ > <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>; > }; > > + scpsys: scpsys@10006000 { > + compatible = "mediatek,mt8173-scpsys"; > + #power-domain-cells = <1>; > + reg = <0 0x10006000 0 0x1000>; > + clocks = <&topckgen CLK_TOP_VDEC_SEL>, > + <&topckgen CLK_TOP_MFG_SEL>, > + <&topckgen CLK_TOP_VENC_SEL>, > + <&topckgen CLK_TOP_MM_SEL>, > + <&topckgen CLK_TOP_VENC_LT_SEL>; > + clock-names = "vdec", "mfg", "venc", "disp", "ven2"; (1) I think people like to align multi-line dts field values, so there should be one more ' ' before each <&topckgen ...>. (2) it is a bit awkward that these names do not match their clock names. This seems more straightforward: clock-names = "vdec", "mfg", "venc", "mm", "venc_lt"; (3) the scpsys binding patch does not list the clock fields. (4) I don't think a patch with these CLK_TOP_* has been sent to the list for review yet. Thanks, -Dan > + }; > + > sysirq: intpol-controller@10200620 { > compatible = "mediatek,mt8173-sysirq", > "mediatek,mt6577-sysirq"; > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Date: Fri, 15 May 2015 22:17:43 +0800 [thread overview] Message-ID: <CAGS+omAWBHMgY45qrqU-ERDEniscoJ+NgVWVjT=kTKMHPdWyEw@mail.gmail.com> (raw) In-Reply-To: <1431349882-12260-5-git-send-email-s.hauer@pengutronix.de> On Mon, May 11, 2015 at 9:11 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > This adds the SCPSYS device node to the MT8173 dtsi file. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 924fdb6..3c569b5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -125,6 +125,18 @@ > <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>; > }; > > + scpsys: scpsys at 10006000 { > + compatible = "mediatek,mt8173-scpsys"; > + #power-domain-cells = <1>; > + reg = <0 0x10006000 0 0x1000>; > + clocks = <&topckgen CLK_TOP_VDEC_SEL>, > + <&topckgen CLK_TOP_MFG_SEL>, > + <&topckgen CLK_TOP_VENC_SEL>, > + <&topckgen CLK_TOP_MM_SEL>, > + <&topckgen CLK_TOP_VENC_LT_SEL>; > + clock-names = "vdec", "mfg", "venc", "disp", "ven2"; (1) I think people like to align multi-line dts field values, so there should be one more ' ' before each <&topckgen ...>. (2) it is a bit awkward that these names do not match their clock names. This seems more straightforward: clock-names = "vdec", "mfg", "venc", "mm", "venc_lt"; (3) the scpsys binding patch does not list the clock fields. (4) I don't think a patch with these CLK_TOP_* has been sent to the list for review yet. Thanks, -Dan > + }; > + > sysirq: intpol-controller at 10200620 { > compatible = "mediatek,mt8173-sysirq", > "mediatek,mt6577-sysirq"; > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-05-15 14:18 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-11 13:11 [PATCH v2] Mediatek SCPSYS power domain support Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` [PATCH 1/4] dt-bindings: soc: Add documentation for the MediaTek SCPSYS unit Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-26 22:35 ` Kevin Hilman 2015-05-26 22:35 ` Kevin Hilman 2015-05-26 22:35 ` Kevin Hilman 2015-05-27 6:24 ` Sascha Hauer 2015-05-27 6:24 ` Sascha Hauer 2015-05-28 17:22 ` Kevin Hilman 2015-05-28 17:22 ` Kevin Hilman 2015-05-11 13:11 ` [PATCH 3/4] ARM64: MediaTek: Add generic pm domain support Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-11 13:11 ` [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Sascha Hauer 2015-05-11 13:11 ` Sascha Hauer 2015-05-15 14:17 ` Daniel Kurtz [this message] 2015-05-15 14:17 ` Daniel Kurtz 2015-05-15 14:17 ` Daniel Kurtz 2015-05-11 16:05 ` [PATCH v2] Mediatek SCPSYS power domain support Matthias Brugger_0 2015-05-11 16:05 ` Matthias Brugger_0 2015-05-11 16:05 ` Matthias Brugger_0 2015-05-11 19:24 ` Sascha Hauer 2015-05-11 19:24 ` Sascha Hauer -- strict thread matches above, loose matches on Subject: below -- 2015-06-24 6:17 [PATCH v6] " Sascha Hauer 2015-06-24 6:17 ` [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Sascha Hauer 2015-06-24 6:17 ` Sascha Hauer 2015-06-24 20:13 ` Matthias Brugger 2015-06-24 20:13 ` Matthias Brugger 2015-06-24 20:13 ` Matthias Brugger 2015-06-22 6:35 [PATCH v5] Mediatek SCPSYS power domain support Sascha Hauer 2015-06-22 6:35 ` [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Sascha Hauer 2015-06-22 6:35 ` Sascha Hauer 2015-06-22 6:35 ` Sascha Hauer 2015-03-10 15:40 [PATCH v1] Mediatek SCPSYS power domain support Sascha Hauer 2015-03-10 15:41 ` [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Sascha Hauer 2015-03-10 15:41 ` Sascha Hauer 2015-03-09 8:09 [RFC] Mediatek SCPSYS power domain support Sascha Hauer 2015-03-09 8:10 ` [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node Sascha Hauer 2015-03-09 8:10 ` Sascha Hauer 2015-03-09 8:10 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGS+omAWBHMgY45qrqU-ERDEniscoJ+NgVWVjT=kTKMHPdWyEw@mail.gmail.com' \ --to=djkurtz@chromium.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@pengutronix.de \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.