From: Chanwoo Choi <cwchoi00@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
a.hajda@samsung.com, linux-kernel <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433
Date: Thu, 12 Jan 2017 06:30:45 +0900 [thread overview]
Message-ID: <CAGTfZH1172CkN_EqMvZNvn8_LYYATYgNnW9PJrL7ArPr2SPMVQ@mail.gmail.com> (raw)
In-Reply-To: <20170111211503.6kwqaunb5mpe6eb2@rob-hp-laptop>
2017-01-12 6:15 GMT+09:00 Rob Herring <robh@kernel.org>:
> On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
>> This patch replaces the small letter of base address, offset and hex value
>> with the capital letter to keep the consistency on Exynos5433.
>
> You mean the other way around, right?
When I posted the dts patches, I got the comment that small letter is better
for base address/offset. (It doesn’t mean that all dts file in Linux Kernel
have to use the small letter of base address and offset.)
This dts uses the both capital and small letter for each base address/offset.
Almost hex value already uses the small letter. If possible, I hope to use
the one style (small letter).
>
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> index abaf6b4d599d..d7ed1a68b6fd 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> @@ -231,7 +231,7 @@
>> compatible = "arm,psci";
>> method = "smc";
>> cpu_off = <0x84000002>;
>> - cpu_on = <0xC4000003>;
>> + cpu_on = <0xc4000003>;
>> };
>>
>> reboot: syscon-reboot {
>> @@ -753,7 +753,7 @@
>>
>> dsi: dsi@13900000 {
>> compatible = "samsung,exynos5433-mipi-dsi";
>> - reg = <0x13900000 0xC0>;
>> + reg = <0x13900000 0xc0>;
>> interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
>> phys = <&mipi_phy 1>;
>> phy-names = "dsim";
>> @@ -880,9 +880,9 @@
>> iommus = <&sysmmu_jpeg>;
>> };
>>
>> - mfc: codec@152E0000 {
>> + mfc: codec@152e0000 {
>> compatible = "samsung,exynos5433-mfc";
>> - reg = <0x152E0000 0x10000>;
>> + reg = <0x152e0000 0x10000>;
>> interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "pclk", "aclk", "aclk_xiu";
>> clocks = <&cmu_mfc CLK_PCLK_MFC>,
>> @@ -914,7 +914,7 @@
>>
>> sysmmu_gscl0: sysmmu@13c80000 {
>> compatible = "samsung,exynos-sysmmu";
>> - reg = <0x13C80000 0x1000>;
>> + reg = <0x13c80000 0x1000>;
>> interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "aclk", "pclk";
>> clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL0>,
>> @@ -924,7 +924,7 @@
>>
>> sysmmu_gscl1: sysmmu@13c90000 {
>> compatible = "samsung,exynos-sysmmu";
>> - reg = <0x13C90000 0x1000>;
>> + reg = <0x13c90000 0x1000>;
>> interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "aclk", "pclk";
>> clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL1>,
>> @@ -934,7 +934,7 @@
>>
>> sysmmu_gscl2: sysmmu@13ca0000 {
>> compatible = "samsung,exynos-sysmmu";
>> - reg = <0x13CA0000 0x1000>;
>> + reg = <0x13ca0000 0x1000>;
>> interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "aclk", "pclk";
>> clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL2>,
>> --
>> 1.9.1
>>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: cwchoi00@gmail.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433
Date: Thu, 12 Jan 2017 06:30:45 +0900 [thread overview]
Message-ID: <CAGTfZH1172CkN_EqMvZNvn8_LYYATYgNnW9PJrL7ArPr2SPMVQ@mail.gmail.com> (raw)
In-Reply-To: <20170111211503.6kwqaunb5mpe6eb2@rob-hp-laptop>
2017-01-12 6:15 GMT+09:00 Rob Herring <robh@kernel.org>:
> On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
>> This patch replaces the small letter of base address, offset and hex value
>> with the capital letter to keep the consistency on Exynos5433.
>
> You mean the other way around, right?
When I posted the dts patches, I got the comment that small letter is better
for base address/offset. (It doesn?t mean that all dts file in Linux Kernel
have to use the small letter of base address and offset.)
This dts uses the both capital and small letter for each base address/offset.
Almost hex value already uses the small letter. If possible, I hope to use
the one style (small letter).
>
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> index abaf6b4d599d..d7ed1a68b6fd 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> @@ -231,7 +231,7 @@
>> compatible = "arm,psci";
>> method = "smc";
>> cpu_off = <0x84000002>;
>> - cpu_on = <0xC4000003>;
>> + cpu_on = <0xc4000003>;
>> };
>>
>> reboot: syscon-reboot {
>> @@ -753,7 +753,7 @@
>>
>> dsi: dsi at 13900000 {
>> compatible = "samsung,exynos5433-mipi-dsi";
>> - reg = <0x13900000 0xC0>;
>> + reg = <0x13900000 0xc0>;
>> interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
>> phys = <&mipi_phy 1>;
>> phy-names = "dsim";
>> @@ -880,9 +880,9 @@
>> iommus = <&sysmmu_jpeg>;
>> };
>>
>> - mfc: codec at 152E0000 {
>> + mfc: codec at 152e0000 {
>> compatible = "samsung,exynos5433-mfc";
>> - reg = <0x152E0000 0x10000>;
>> + reg = <0x152e0000 0x10000>;
>> interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "pclk", "aclk", "aclk_xiu";
>> clocks = <&cmu_mfc CLK_PCLK_MFC>,
>> @@ -914,7 +914,7 @@
>>
>> sysmmu_gscl0: sysmmu at 13c80000 {
>> compatible = "samsung,exynos-sysmmu";
>> - reg = <0x13C80000 0x1000>;
>> + reg = <0x13c80000 0x1000>;
>> interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "aclk", "pclk";
>> clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL0>,
>> @@ -924,7 +924,7 @@
>>
>> sysmmu_gscl1: sysmmu at 13c90000 {
>> compatible = "samsung,exynos-sysmmu";
>> - reg = <0x13C90000 0x1000>;
>> + reg = <0x13c90000 0x1000>;
>> interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "aclk", "pclk";
>> clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL1>,
>> @@ -934,7 +934,7 @@
>>
>> sysmmu_gscl2: sysmmu at 13ca0000 {
>> compatible = "samsung,exynos-sysmmu";
>> - reg = <0x13CA0000 0x1000>;
>> + reg = <0x13ca0000 0x1000>;
>> interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>;
>> clock-names = "aclk", "pclk";
>> clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL2>,
>> --
>> 1.9.1
>>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-01-11 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170111005552epcas1p4a1f6ed88022b46544dec4b3801583267@epcas1p4.samsung.com>
2017-01-11 0:55 ` [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433 Chanwoo Choi
2017-01-11 0:55 ` Chanwoo Choi
2017-01-11 1:11 ` Andi Shyti
2017-01-11 1:11 ` Andi Shyti
2017-01-11 16:26 ` Krzysztof Kozlowski
2017-01-11 16:26 ` Krzysztof Kozlowski
2017-01-11 21:22 ` Chanwoo Choi
2017-01-11 21:22 ` Chanwoo Choi
2017-01-12 6:34 ` Krzysztof Kozlowski
2017-01-12 6:34 ` Krzysztof Kozlowski
2017-01-12 6:34 ` Krzysztof Kozlowski
2017-01-11 21:15 ` Rob Herring
2017-01-11 21:15 ` Rob Herring
2017-01-11 21:30 ` Chanwoo Choi [this message]
2017-01-11 21:30 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGTfZH1172CkN_EqMvZNvn8_LYYATYgNnW9PJrL7ArPr2SPMVQ@mail.gmail.com \
--to=cwchoi00@gmail.com \
--cc=a.hajda@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.