From: keescook at chromium.org (Kees Cook) Subject: [PATCH 1/6] selftests: Extract single-test shell logic from lib.mk Date: Tue, 16 Apr 2019 18:16:23 -0500 [thread overview] Message-ID: <CAGXu5jJOG9Or_==aa0AMtv6n2=_MT_etLX7OCm22NpzT6d7W4g@mail.gmail.com> (raw) In-Reply-To: <714c1bf0-63a5-9cec-ccd6-7f3abb020574@kernel.org> On Tue, Apr 16, 2019 at 6:11 PM shuah <shuah at kernel.org> wrote: > > Hi Kees, > > Thanks for the patch. > > On 4/9/19 5:55 PM, Kees Cook wrote: > > In order to improve the reusability of the kselftest test running logic, > > this extracts the single-test logic from lib.mk into kselftest/runner.sh > > which lib.mk can call directly. No changes in output. > > > > As part of the change, this removes the unused "summary" Makefile variable > > (and tests). However, future merging with the "emit_tests" target needs > > to be able to redirect output, so a new "logfile" variable is introduced. > > Shouldn't the selftests/Makefile need update for "summary" removal?? > I didn't see anything using "summary" except as a --summary argument to the run_kselftests.sh script. Maybe I missed it? > > > > Signed-off-by: Kees Cook <keescook at chromium.org> > > --- > > tools/testing/selftests/.gitignore | 1 - > > tools/testing/selftests/kselftest/runner.sh | 31 +++++++++++++++++++ > > tools/testing/selftests/lib.mk | 33 ++------------------- > > 3 files changed, 34 insertions(+), 31 deletions(-) > > create mode 100644 tools/testing/selftests/kselftest/runner.sh > > > > diff --git a/tools/testing/selftests/.gitignore b/tools/testing/selftests/.gitignore > > index 91750352459d..8059ce834247 100644 > > --- a/tools/testing/selftests/.gitignore > > +++ b/tools/testing/selftests/.gitignore > > @@ -1,4 +1,3 @@ > > -kselftest > > gpiogpio-event-mon > > gpiogpio-hammer > > gpioinclude/ > > Please don't include this .gitignore change here. These are generated > in tools/gpio and this .gitignore isn't the right place for them. This change is only removing the "kselftest" entry, for which the target is long gone. Since I was adding a directory by that name, I needed to remove it from the .gitignore file. I have nothing to do with the gpio stuff. :) Thanks for looking this over! -- Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: keescook@chromium.org (Kees Cook) Subject: [PATCH 1/6] selftests: Extract single-test shell logic from lib.mk Date: Tue, 16 Apr 2019 18:16:23 -0500 [thread overview] Message-ID: <CAGXu5jJOG9Or_==aa0AMtv6n2=_MT_etLX7OCm22NpzT6d7W4g@mail.gmail.com> (raw) Message-ID: <20190416231623.AXHbI01SI9iXSTQIiObjQrPzTUjcEwLE4ClnGdzLCGQ@z> (raw) In-Reply-To: <714c1bf0-63a5-9cec-ccd6-7f3abb020574@kernel.org> On Tue, Apr 16, 2019@6:11 PM shuah <shuah@kernel.org> wrote: > > Hi Kees, > > Thanks for the patch. > > On 4/9/19 5:55 PM, Kees Cook wrote: > > In order to improve the reusability of the kselftest test running logic, > > this extracts the single-test logic from lib.mk into kselftest/runner.sh > > which lib.mk can call directly. No changes in output. > > > > As part of the change, this removes the unused "summary" Makefile variable > > (and tests). However, future merging with the "emit_tests" target needs > > to be able to redirect output, so a new "logfile" variable is introduced. > > Shouldn't the selftests/Makefile need update for "summary" removal?? > I didn't see anything using "summary" except as a --summary argument to the run_kselftests.sh script. Maybe I missed it? > > > > Signed-off-by: Kees Cook <keescook at chromium.org> > > --- > > tools/testing/selftests/.gitignore | 1 - > > tools/testing/selftests/kselftest/runner.sh | 31 +++++++++++++++++++ > > tools/testing/selftests/lib.mk | 33 ++------------------- > > 3 files changed, 34 insertions(+), 31 deletions(-) > > create mode 100644 tools/testing/selftests/kselftest/runner.sh > > > > diff --git a/tools/testing/selftests/.gitignore b/tools/testing/selftests/.gitignore > > index 91750352459d..8059ce834247 100644 > > --- a/tools/testing/selftests/.gitignore > > +++ b/tools/testing/selftests/.gitignore > > @@ -1,4 +1,3 @@ > > -kselftest > > gpiogpio-event-mon > > gpiogpio-hammer > > gpioinclude/ > > Please don't include this .gitignore change here. These are generated > in tools/gpio and this .gitignore isn't the right place for them. This change is only removing the "kselftest" entry, for which the target is long gone. Since I was adding a directory by that name, I needed to remove it from the .gitignore file. I have nothing to do with the gpio stuff. :) Thanks for looking this over! -- Kees Cook
next prev parent reply other threads:[~2019-04-16 23:16 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-09 23:55 [PATCH 0/6] selftests: Move test output to diagnostic lines keescook 2019-04-09 23:55 ` Kees Cook 2019-04-09 23:55 ` [PATCH 1/6] selftests: Extract single-test shell logic from lib.mk keescook 2019-04-09 23:55 ` Kees Cook 2019-04-16 23:11 ` shuah 2019-04-16 23:11 ` shuah 2019-04-16 23:16 ` keescook [this message] 2019-04-16 23:16 ` Kees Cook 2019-04-16 23:21 ` shuah 2019-04-16 23:21 ` shuah 2019-04-23 22:31 ` keescook 2019-04-23 22:31 ` Kees Cook 2019-04-23 22:47 ` shuah 2019-04-23 22:47 ` shuah 2019-04-24 2:43 ` keescook 2019-04-24 2:43 ` Kees Cook 2019-04-24 2:46 ` shuah 2019-04-24 2:46 ` shuah 2019-04-09 23:55 ` [PATCH 2/6] selftests: Use runner.sh for emit targets keescook 2019-04-09 23:55 ` Kees Cook 2019-04-09 23:55 ` [PATCH 3/6] selftests: Extract logic for multiple test runs keescook 2019-04-09 23:55 ` Kees Cook 2019-04-09 23:55 ` [PATCH 4/6] selftests/runner: Add plan line and fix result line syntax keescook 2019-04-09 23:55 ` Kees Cook 2019-04-09 23:55 ` [PATCH 5/6] selftests/runner: Distinguish between missing and non-executable keescook 2019-04-09 23:55 ` Kees Cook 2019-04-09 23:55 ` [PATCH 6/6] selftests: Move test output to diagnostic lines keescook 2019-04-09 23:55 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGXu5jJOG9Or_==aa0AMtv6n2=_MT_etLX7OCm22NpzT6d7W4g@mail.gmail.com' \ --to=unknown@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.