From: Kees Cook <keescook@chromium.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Mark D Rustad <mrustad@gmail.com>,
Tony Lindgren <tony@atomide.com>,
kernel-janitors@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-omap@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/11] mfd: Drop unnecessary static
Date: Mon, 24 Jul 2017 15:27:07 -0700 [thread overview]
Message-ID: <CAGXu5jKAO+9VjPnPWNUk3jH6iZwCy9+NPgYEQ+LFUdJciLJx0g@mail.gmail.com> (raw)
In-Reply-To: <20170724192026.GF32425@amd>
On Mon, Jul 24, 2017 at 12:20 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> > > Drop static on a local variable, when the variable is initialized before
>> > > any possible use. Thus, the static has no benefit.
>
> Actually... it has possible other benefit -- saving stack space. I've
> used static for that purpose before. So ... careful with the
> automation.
This means any functions like this must not be thread safe, though...
-Kees
--
Kees Cook
Pixel Security
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Mark D Rustad <mrustad@gmail.com>,
Tony Lindgren <tony@atomide.com>,
kernel-janitors@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-omap@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/11] mfd: Drop unnecessary static
Date: Mon, 24 Jul 2017 22:27:07 +0000 [thread overview]
Message-ID: <CAGXu5jKAO+9VjPnPWNUk3jH6iZwCy9+NPgYEQ+LFUdJciLJx0g@mail.gmail.com> (raw)
In-Reply-To: <20170724192026.GF32425@amd>
On Mon, Jul 24, 2017 at 12:20 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> > > Drop static on a local variable, when the variable is initialized before
>> > > any possible use. Thus, the static has no benefit.
>
> Actually... it has possible other benefit -- saving stack space. I've
> used static for that purpose before. So ... careful with the
> automation.
This means any functions like this must not be thread safe, though...
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-07-24 22:27 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 20:07 [PATCH 00/11] Drop unnecessary static Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` [PATCH 01/11] clk: mmp: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-18 1:31 ` Stephen Boyd
2017-07-18 1:31 ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 02/11] clk: moxart: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-18 1:31 ` Stephen Boyd
2017-07-18 1:31 ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 03/11] mtd: physmap_of: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-17 19:58 ` Boris Brezillon
2017-07-17 19:58 ` Boris Brezillon
2017-08-17 12:58 ` Boris Brezillon
2017-08-17 12:58 ` Boris Brezillon
2017-07-15 20:07 ` [PATCH 04/11] fbdev: da8xx-fb: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-08-01 13:09 ` Bartlomiej Zolnierkiewicz
2017-08-01 13:09 ` Bartlomiej Zolnierkiewicz
2017-07-15 20:07 ` [PATCH 05/11] irqchip/gic/realview: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-18 20:06 ` [tip:irq/urgent] " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 06/11] irqchip: mips-cpu: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:52 ` Mark D Rustad
2017-07-15 20:52 ` Mark D Rustad
2017-07-15 20:59 ` Julia Lawall
2017-07-15 20:59 ` Julia Lawall
2017-07-16 6:04 ` Mark D Rustad
2017-07-16 6:04 ` Mark D Rustad
2017-07-18 20:07 ` [tip:irq/urgent] irqchip/mips-cpu: " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 07/11] mfd: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:49 ` Mark D Rustad
2017-07-15 20:49 ` Mark D Rustad
2017-07-15 20:56 ` Julia Lawall
2017-07-15 20:56 ` Julia Lawall
2017-07-24 19:20 ` Pavel Machek
2017-07-24 19:20 ` Pavel Machek
2017-07-24 22:27 ` Kees Cook [this message]
2017-07-24 22:27 ` Kees Cook
2017-07-25 8:00 ` Lee Jones
2017-07-25 8:00 ` Lee Jones
2017-07-15 20:07 ` [PATCH 08/11] ata: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-08-02 8:23 ` Linus Walleij
2017-08-02 8:23 ` Linus Walleij
2017-08-02 15:12 ` Tejun Heo
2017-08-02 15:12 ` Tejun Heo
2017-07-15 20:07 ` [PATCH 09/11] iio: orientation: hid-sensor-rotation: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-17 20:45 ` Jonathan Cameron
2017-07-17 20:45 ` Jonathan Cameron
2017-07-15 20:07 ` [PATCH 10/11] irqchip: digicolor: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-16 4:49 ` Baruch Siach
2017-07-16 4:49 ` Baruch Siach
2017-07-16 4:49 ` Baruch Siach
2017-07-18 20:07 ` [tip:irq/urgent] irqchip/digicolor: " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 11/11] mfd: max8925-i2c: " Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-18 7:23 ` Lee Jones
2017-07-18 7:23 ` Lee Jones
2017-07-15 20:37 ` [PATCH 00/11] " Joe Perches
2017-07-15 20:37 ` Joe Perches
2017-07-15 20:37 ` Joe Perches
2017-07-15 21:00 ` Julia Lawall
2017-07-15 21:00 ` Julia Lawall
2017-07-15 21:00 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jKAO+9VjPnPWNUk3jH6iZwCy9+NPgYEQ+LFUdJciLJx0g@mail.gmail.com \
--to=keescook@chromium.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mrustad@gmail.com \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.