From: Chen-Yu Tsai <wenst@chromium.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Guillaume Ranquet <granquet@baylibre.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Markus Schneider-Pargmann <msp@baylibre.com>,
Bo-Chen Chen <rex-bc.chen@mediatek.com>,
linux-mediatek@lists.infradead.org,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
Date: Fri, 15 Sep 2023 13:28:04 +0800 [thread overview]
Message-ID: <CAGXv+5GJxEobJKKWuc_UN+Gf_z8g6eb6KWTz-L+RqtyLYKK3Jg@mail.gmail.com> (raw)
In-Reply-To: <20230914155317.2511876-1-jani.nikula@intel.com>
On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> The sads returned by drm_edid_to_sad() needs to be freed.
>
> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> Cc: Guillaume Ranquet <granquet@baylibre.com>
> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Looks correct to me.
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Guillaume Ranquet <granquet@baylibre.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Markus Schneider-Pargmann <msp@baylibre.com>,
Bo-Chen Chen <rex-bc.chen@mediatek.com>,
linux-mediatek@lists.infradead.org,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
Date: Fri, 15 Sep 2023 13:28:04 +0800 [thread overview]
Message-ID: <CAGXv+5GJxEobJKKWuc_UN+Gf_z8g6eb6KWTz-L+RqtyLYKK3Jg@mail.gmail.com> (raw)
In-Reply-To: <20230914155317.2511876-1-jani.nikula@intel.com>
On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> The sads returned by drm_edid_to_sad() needs to be freed.
>
> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> Cc: Guillaume Ranquet <granquet@baylibre.com>
> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Looks correct to me.
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Guillaume Ranquet <granquet@baylibre.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Markus Schneider-Pargmann <msp@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Bo-Chen Chen <rex-bc.chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection
Date: Fri, 15 Sep 2023 13:28:04 +0800 [thread overview]
Message-ID: <CAGXv+5GJxEobJKKWuc_UN+Gf_z8g6eb6KWTz-L+RqtyLYKK3Jg@mail.gmail.com> (raw)
In-Reply-To: <20230914155317.2511876-1-jani.nikula@intel.com>
On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> The sads returned by drm_edid_to_sad() needs to be freed.
>
> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> Cc: Guillaume Ranquet <granquet@baylibre.com>
> Cc: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Looks correct to me.
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
next prev parent reply other threads:[~2023-09-15 5:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 13:10 [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Jani Nikula
2023-09-14 13:10 ` Jani Nikula
2023-09-14 13:10 ` Jani Nikula
2023-09-14 13:38 ` Guillaume Ranquet
2023-09-14 13:38 ` Guillaume Ranquet
2023-09-14 13:38 ` Guillaume Ranquet
2023-09-14 15:53 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection Jani Nikula
2023-09-14 15:53 ` Jani Nikula
2023-09-14 15:53 ` Jani Nikula
2023-09-15 5:28 ` Chen-Yu Tsai [this message]
2023-09-15 5:28 ` Chen-Yu Tsai
2023-09-15 5:28 ` Chen-Yu Tsai
2023-09-19 11:02 ` Jani Nikula
2023-09-19 11:02 ` Jani Nikula
2023-09-19 11:02 ` Jani Nikula
2023-09-19 11:04 ` Chen-Yu Tsai
2023-09-19 11:04 ` Chen-Yu Tsai
2023-09-19 11:04 ` Chen-Yu Tsai
2023-09-22 9:44 ` Jani Nikula
2023-09-22 9:44 ` Jani Nikula
2023-09-22 9:44 ` Jani Nikula
2023-09-24 14:27 ` Chun-Kuang Hu
2023-09-24 14:27 ` Chun-Kuang Hu
2023-09-24 14:27 ` Chun-Kuang Hu
2023-09-24 14:40 ` [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path Chun-Kuang Hu
2023-09-24 14:40 ` Chun-Kuang Hu
2023-09-24 14:40 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXv+5GJxEobJKKWuc_UN+Gf_z8g6eb6KWTz-L+RqtyLYKK3Jg@mail.gmail.com \
--to=wenst@chromium.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jani.nikula@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=rex-bc.chen@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.