From: Chen-Yu Tsai <wens@csie.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Marcus Cooper" <codekipper@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Mylène Josserand" <mylene.josserand@free-electrons.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/9] ASoC: sun4i-i2s: Add quirk to handle fixed WSS
Date: Mon, 4 Dec 2017 08:43:33 +0800 [thread overview]
Message-ID: <CAGb2v64BpqPzj0WOeiY0mQkX9QXqKctUJyfD9DOVfaE_K6k39g@mail.gmail.com> (raw)
In-Reply-To: <20171203204157.20829-2-anarsoul@gmail.com>
Hi,
On Mon, Dec 4, 2017 at 4:41 AM, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> I2S for audio codec on sun50i-A64 always uses fixed word select size value,
> no matter what is sample width. Add quirk to support that.
Please clarify on this. Does this mean the WSS bitfield is useless and it
always sends out the same sample sizes regardless of the setting? Or it's
the codec that can only use a fixed sample width?
As far as I can tell, the code you added in this patch points to the latter.
In that case. this is the wrong way to go about it. The limitation is a
property of the codec, not the I2S controller. If the codec assumes 32 bits
per sample, then that is what you should setup in the code driver. See
sun8i_codec_dai in sound/soc/sunxi/sun8i-codec.c where you can set the
format. You'll likely need to make a copy of the data structure for A64,
and tie it to the compatible.
ChenYu
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] ASoC: sun4i-i2s: Add quirk to handle fixed WSS
Date: Mon, 4 Dec 2017 08:43:33 +0800 [thread overview]
Message-ID: <CAGb2v64BpqPzj0WOeiY0mQkX9QXqKctUJyfD9DOVfaE_K6k39g@mail.gmail.com> (raw)
In-Reply-To: <20171203204157.20829-2-anarsoul@gmail.com>
Hi,
On Mon, Dec 4, 2017 at 4:41 AM, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> I2S for audio codec on sun50i-A64 always uses fixed word select size value,
> no matter what is sample width. Add quirk to support that.
Please clarify on this. Does this mean the WSS bitfield is useless and it
always sends out the same sample sizes regardless of the setting? Or it's
the codec that can only use a fixed sample width?
As far as I can tell, the code you added in this patch points to the latter.
In that case. this is the wrong way to go about it. The limitation is a
property of the codec, not the I2S controller. If the codec assumes 32 bits
per sample, then that is what you should setup in the code driver. See
sun8i_codec_dai in sound/soc/sunxi/sun8i-codec.c where you can set the
format. You'll likely need to make a copy of the data structure for A64,
and tie it to the compatible.
ChenYu
next prev parent reply other threads:[~2017-12-04 0:44 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 20:41 [PATCH 0/9] Add audiocodec support for A64 SoC Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-03 20:41 ` [PATCH 1/9] ASoC: sun4i-i2s: Add quirk to handle fixed WSS Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-04 0:43 ` Chen-Yu Tsai [this message]
2017-12-04 0:43 ` Chen-Yu Tsai
2017-12-03 20:41 ` [PATCH 2/9] ASoC: sun4i-i2s: Add compatibility with A64 codec I2S Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-04 6:42 ` Code Kipper
2017-12-04 6:42 ` Code Kipper
2017-12-04 7:34 ` Vasily Khoruzhick
2017-12-04 7:34 ` Vasily Khoruzhick
2017-12-05 8:01 ` Maxime Ripard
2017-12-05 8:01 ` Maxime Ripard
2017-12-05 23:04 ` Vasily Khoruzhick
2017-12-05 23:04 ` Vasily Khoruzhick
2017-12-06 15:27 ` Maxime Ripard
2017-12-06 15:27 ` Maxime Ripard
2017-12-07 9:21 ` Code Kipper
2017-12-07 9:21 ` Code Kipper
2017-12-07 9:30 ` Chen-Yu Tsai
2017-12-07 9:30 ` Chen-Yu Tsai
2017-12-07 22:48 ` Vasily Khoruzhick
2017-12-07 22:48 ` Vasily Khoruzhick
2017-12-08 6:40 ` Code Kipper
2017-12-08 6:40 ` Code Kipper
2017-12-08 22:16 ` Vasily Khoruzhick
2017-12-08 22:16 ` Vasily Khoruzhick
2017-12-03 20:41 ` [PATCH 3/9] ASoC: sun8i-codec: Add quirk to specify aif1_lrck_div value Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-04 7:23 ` Code Kipper
2017-12-04 7:23 ` Code Kipper
2017-12-04 7:38 ` Chen-Yu Tsai
2017-12-04 7:38 ` Chen-Yu Tsai
2017-12-04 8:26 ` Chen-Yu Tsai
2017-12-04 8:26 ` Chen-Yu Tsai
2017-12-03 20:41 ` [PATCH 4/9] ASoC: sun8i-codec: Add support for A64 SoC Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-05 8:04 ` Maxime Ripard
2017-12-05 8:04 ` Maxime Ripard
2017-12-05 23:17 ` Vasily Khoruzhick
2017-12-05 23:17 ` Vasily Khoruzhick
2017-12-06 15:32 ` Maxime Ripard
2017-12-06 15:32 ` Maxime Ripard
2017-12-06 15:48 ` Mark Brown
2017-12-06 15:48 ` Mark Brown
2017-12-06 18:53 ` Maxime Ripard
2017-12-06 18:53 ` Maxime Ripard
2017-12-06 19:13 ` Mark Brown
2017-12-06 19:13 ` Mark Brown
2017-12-03 20:41 ` [PATCH 5/9] ASoC: sun8i-codec-analog: Use callbacks to add headphones and lineout outputs Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-03 20:41 ` [PATCH 6/9] ASoC: sun8i-codec-analog: Add component driver field to quirks structure Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-03 20:41 ` [PATCH 7/9] ASoC: sun8i-codec-analog: Add support for A64 SoC Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-03 20:41 ` [PATCH 8/9] arm64: dts: allwinner: a64: Add nodes necessary for analog sound support Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-03 20:41 ` [PATCH 9/9] arm64: dts: allwinner: a64: Enable sound on Pine64 and SoPine Vasily Khoruzhick
2017-12-03 20:41 ` Vasily Khoruzhick
2017-12-05 3:24 ` Chen-Yu Tsai
2017-12-05 3:24 ` Chen-Yu Tsai
2017-12-09 19:54 ` Vasily Khoruzhick
2017-12-09 19:54 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v64BpqPzj0WOeiY0mQkX9QXqKctUJyfD9DOVfaE_K6k39g@mail.gmail.com \
--to=wens@csie.org \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mylene.josserand@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.