From: Chen-Yu Tsai <wens@csie.org>
To: George Hilliard <thirtythreeforty@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Icenowy Zheng <icenowy@aosc.io>,
linux-usb <linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 3/5] musb: sunxi: add support for the suniv MUSB controller
Date: Thu, 12 Mar 2020 14:55:52 +0800 [thread overview]
Message-ID: <CAGb2v65LJUT1teBna7deKP7AfboUBcQDmiDgu3hrQY_+UzU0DA@mail.gmail.com> (raw)
In-Reply-To: <20200309204326.27403-4-thirtythreeforty@gmail.com>
On Tue, Mar 10, 2020 at 4:44 AM George Hilliard
<thirtythreeforty@gmail.com> wrote:
>
> The suniv SoC has a MUSB controller like the one in A33, but with a SRAM
> region to be claimed.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Same thing about the SoB and author.
> Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
> ---
> drivers/usb/musb/sunxi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index f3f76f2ac63f..76806b781844 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -714,14 +714,17 @@ static int sunxi_musb_probe(struct platform_device *pdev)
> INIT_WORK(&glue->work, sunxi_musb_work);
> glue->host_nb.notifier_call = sunxi_musb_host_notifier;
>
> - if (of_device_is_compatible(np, "allwinner,sun4i-a10-musb"))
> + if (of_device_is_compatible(np, "allwinner,sun4i-a10-musb") ||
> + of_device_is_compatible(np, "allwinner,suniv-f1c100s-musb")) {
> set_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags);
> + }
>
> if (of_device_is_compatible(np, "allwinner,sun6i-a31-musb"))
> set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
>
> if (of_device_is_compatible(np, "allwinner,sun8i-a33-musb") ||
> - of_device_is_compatible(np, "allwinner,sun8i-h3-musb")) {
> + of_device_is_compatible(np, "allwinner,sun8i-h3-musb") ||
> + of_device_is_compatible(np, "allwinner,suniv-f1c100s-musb")) {
> set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
> set_bit(SUNXI_MUSB_FL_NO_CONFIGDATA, &glue->flags);
> }
> @@ -814,6 +817,7 @@ static int sunxi_musb_remove(struct platform_device *pdev)
> }
>
> static const struct of_device_id sunxi_musb_match[] = {
> + { .compatible = "allwinner,suniv-f1c100s-musb", },
And same thing about the ordering.
Once resolved,
Acked-by: Chen-Yu Tsai <wens@csie.org>
> { .compatible = "allwinner,sun4i-a10-musb", },
> { .compatible = "allwinner,sun6i-a31-musb", },
> { .compatible = "allwinner,sun8i-a33-musb", },
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-03-12 6:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 20:43 [RESEND PATCH 0/5] Support the Allwinner F1C100s USB stack George Hilliard
2020-03-09 20:43 ` [RESEND PATCH 1/5] dt-bindings: Add new F1C100s compatible strings for USB George Hilliard
2020-03-12 6:53 ` Chen-Yu Tsai
2020-03-09 20:43 ` [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on suniv SoC George Hilliard
2020-03-12 6:51 ` Chen-Yu Tsai
2020-03-12 6:54 ` Chen-Yu Tsai
2020-03-12 12:06 ` George Hilliard
2020-03-13 4:07 ` Chen-Yu Tsai
2020-03-13 14:03 ` George Hilliard
2020-03-09 20:43 ` [RESEND PATCH 3/5] musb: sunxi: add support for the suniv MUSB controller George Hilliard
2020-03-12 6:55 ` Chen-Yu Tsai [this message]
2020-03-09 20:43 ` [RESEND PATCH 4/5] ARM: suniv: add USB-related device nodes George Hilliard
2020-03-09 20:43 ` [RESEND PATCH 5/5] ARM: suniv: f1c100s: enable USB on Lichee Pi Nano George Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v65LJUT1teBna7deKP7AfboUBcQDmiDgu3hrQY_+UzU0DA@mail.gmail.com \
--to=wens@csie.org \
--cc=icenowy@aosc.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thirtythreeforty@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.