Re: [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on suniv SoC - Chen-Yu Tsai

From: Chen-Yu Tsai <wens@csie.org>
To: George Hilliard <thirtythreeforty@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Icenowy Zheng <icenowy@aosc.io>,
	linux-usb <linux-usb@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on suniv SoC
Date: Fri, 13 Mar 2020 12:07:48 +0800	[thread overview]
Message-ID: <CAGb2v65RJUVb4fERTi8qM=qWQuhL4QWR5WpBB7kGS4tN67++aw@mail.gmail.com> (raw)
In-Reply-To: <CACmrr9hSK1CzDGQ9_v6gNF7TBH65J-QAL_pwQJdKCc4ZxF_-ww@mail.gmail.com>

On Thu, Mar 12, 2020 at 8:06 PM George Hilliard
<thirtythreeforty@gmail.com> wrote:
>
> Thanks for the review.
>
> On Thu, Mar 12, 2020 at 1:51 AM Chen-Yu Tsai <wens@csie.org> wrote:
> >
> > On Tue, Mar 10, 2020 at 4:43 AM George Hilliard
> > <thirtythreeforty@gmail.com> wrote:
> > >
> > > The suniv SoC has one USB OTG port connected to a MUSB controller.
> > >
> > > Add support for its USB PHY.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >
> > Not sure why Icenowy's SoB is here. If she was the original author, you
> > are supposed to keep her name as the author.
>
> So, I was unclear on the convention here.  This patch is based on her
> patch, but I've modified it and rebased those modifications back into
> a single change.  I'm happy to change the author field - does it need
> a "Co-authored-by: myself" here?

I suppose that really depends on how much you changed it. If it were just
stylistic changes I'd keep the original author. Also you should list any
changes you made to the patch by inserting

    [<who>: changed foo and bar]

before your SoB.

As for the Co-authored-by, I haven't really seen it used so I don't really
know.

ChenYu

> > >
> > >  static const struct of_device_id sun4i_usb_phy_of_match[] = {
> > > +       { .compatible = "allwinner,suniv-f1c100s-usb-phy",
> > > +         .data = &suniv_f1c100s_cfg },
> > >         { .compatible = "allwinner,sun4i-a10-usb-phy", .data = &sun4i_a10_cfg },
> >
> > Please use the same style (and ignore checkpatch.pl on this one).
>
> Very happy to change this, it was bugging me!
>
> George