From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
netdev <netdev@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Srinivas Kandagatla <srinivas.kandagatla@st.com>
Subject: Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware
Date: Mon, 9 Dec 2013 10:43:29 +0800 [thread overview]
Message-ID: <CAGb2v65YOSq_BMWSzSHX8w_hbo+0vwquBT2pnLuwNVZkWRfLvA@mail.gmail.com> (raw)
In-Reply-To: <20131207103335.GL24519@lukather>
Hi,
On Sat, Dec 7, 2013 at 6:33 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Sat, Dec 07, 2013 at 01:29:34AM +0800, Chen-Yu Tsai wrote:
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>
>> Guiseppe previously stated that the "stmmaceth" clock is the
>> main clock that drives the IP. The stmmac driver does not
>> enable this clock during the probe phase. When the driver is
>> built in to the kernel, this is fine because the clock maybe
>> on by default, or the boot loader had enabled it.
>>
>> If stmmac is built as a module, when the module is loaded,
>> the clock may be found unused and disabled by the kernel.
>
> This should be your commit log.
>
> And this is actually not related to the fact that we are building it
> as a module or not. You'd face the same issue with a statically built
> kernel if the bootloader didn't enable it.
Noted. Will revise commit log.
>
>>
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 24 +++++++++++++----------
>> 1 file changed, 14 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 8d4ccd3..7da71ed 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -2688,10 +2688,17 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> if ((phyaddr >= 0) && (phyaddr <= 31))
>> priv->plat->phy_addr = phyaddr;
>>
>> + priv->stmmac_clk = clk_get(priv->device, STMMAC_RESOURCE_NAME);
>
> You can probably use devm_clk_get to make the exit path smaller.
As it stands, the driver does not call clk_put in the exit path.
Using devm_clk_get here would be a good fix.
>
>> + if (IS_ERR(priv->stmmac_clk)) {
>> + pr_warn("%s: warning: cannot get CSR clock\n", __func__);
>
> And dev_warn here.
>
>> + goto error_clk_get;
>> + }
>> + clk_prepare_enable(priv->stmmac_clk);
>> +
>> /* Init MAC and get the capabilities */
>> ret = stmmac_hw_init(priv);
>> if (ret)
>> - goto error_free_netdev;
>> + goto error_hw_init;
>> ndev->netdev_ops = &stmmac_netdev_ops;
>>
>> @@ -2729,12 +2736,6 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> goto error_netdev_register;
>> }
>>
>> - priv->stmmac_clk = clk_get(priv->device, STMMAC_RESOURCE_NAME);
>> - if (IS_ERR(priv->stmmac_clk)) {
>> - pr_warn("%s: warning: cannot get CSR clock\n", __func__);
>> - goto error_clk_get;
>> - }
>> -
>> /* If a specific clk_csr value is passed from the platform
>> * this means that the CSR Clock Range selection cannot be
>> * changed at run-time and it is fixed. Viceversa the driver'll try to
>> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> }
>> }
>>
>> + clk_disable_unprepare(priv->stmmac_clk);
>> +
>
> Hu? Why do you disable the clock? don't you need it afterwards?
The clock is enabled in *_open (when the network interface is used),
and disabled in *_close.
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
Srinivas Kandagatla
<srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
Subject: Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware
Date: Mon, 9 Dec 2013 10:43:29 +0800 [thread overview]
Message-ID: <CAGb2v65YOSq_BMWSzSHX8w_hbo+0vwquBT2pnLuwNVZkWRfLvA@mail.gmail.com> (raw)
In-Reply-To: <20131207103335.GL24519@lukather>
Hi,
On Sat, Dec 7, 2013 at 6:33 PM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Hi,
>
> On Sat, Dec 07, 2013 at 01:29:34AM +0800, Chen-Yu Tsai wrote:
>> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
>> ---
>>
>> Guiseppe previously stated that the "stmmaceth" clock is the
>> main clock that drives the IP. The stmmac driver does not
>> enable this clock during the probe phase. When the driver is
>> built in to the kernel, this is fine because the clock maybe
>> on by default, or the boot loader had enabled it.
>>
>> If stmmac is built as a module, when the module is loaded,
>> the clock may be found unused and disabled by the kernel.
>
> This should be your commit log.
>
> And this is actually not related to the fact that we are building it
> as a module or not. You'd face the same issue with a statically built
> kernel if the bootloader didn't enable it.
Noted. Will revise commit log.
>
>>
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 24 +++++++++++++----------
>> 1 file changed, 14 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 8d4ccd3..7da71ed 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -2688,10 +2688,17 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> if ((phyaddr >= 0) && (phyaddr <= 31))
>> priv->plat->phy_addr = phyaddr;
>>
>> + priv->stmmac_clk = clk_get(priv->device, STMMAC_RESOURCE_NAME);
>
> You can probably use devm_clk_get to make the exit path smaller.
As it stands, the driver does not call clk_put in the exit path.
Using devm_clk_get here would be a good fix.
>
>> + if (IS_ERR(priv->stmmac_clk)) {
>> + pr_warn("%s: warning: cannot get CSR clock\n", __func__);
>
> And dev_warn here.
>
>> + goto error_clk_get;
>> + }
>> + clk_prepare_enable(priv->stmmac_clk);
>> +
>> /* Init MAC and get the capabilities */
>> ret = stmmac_hw_init(priv);
>> if (ret)
>> - goto error_free_netdev;
>> + goto error_hw_init;
>> ndev->netdev_ops = &stmmac_netdev_ops;
>>
>> @@ -2729,12 +2736,6 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> goto error_netdev_register;
>> }
>>
>> - priv->stmmac_clk = clk_get(priv->device, STMMAC_RESOURCE_NAME);
>> - if (IS_ERR(priv->stmmac_clk)) {
>> - pr_warn("%s: warning: cannot get CSR clock\n", __func__);
>> - goto error_clk_get;
>> - }
>> -
>> /* If a specific clk_csr value is passed from the platform
>> * this means that the CSR Clock Range selection cannot be
>> * changed at run-time and it is fixed. Viceversa the driver'll try to
>> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> }
>> }
>>
>> + clk_disable_unprepare(priv->stmmac_clk);
>> +
>
> Hu? Why do you disable the clock? don't you need it afterwards?
The clock is enabled in *_open (when the network interface is used),
and disabled in *_close.
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware
Date: Mon, 9 Dec 2013 10:43:29 +0800 [thread overview]
Message-ID: <CAGb2v65YOSq_BMWSzSHX8w_hbo+0vwquBT2pnLuwNVZkWRfLvA@mail.gmail.com> (raw)
In-Reply-To: <20131207103335.GL24519@lukather>
Hi,
On Sat, Dec 7, 2013 at 6:33 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Sat, Dec 07, 2013 at 01:29:34AM +0800, Chen-Yu Tsai wrote:
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>
>> Guiseppe previously stated that the "stmmaceth" clock is the
>> main clock that drives the IP. The stmmac driver does not
>> enable this clock during the probe phase. When the driver is
>> built in to the kernel, this is fine because the clock maybe
>> on by default, or the boot loader had enabled it.
>>
>> If stmmac is built as a module, when the module is loaded,
>> the clock may be found unused and disabled by the kernel.
>
> This should be your commit log.
>
> And this is actually not related to the fact that we are building it
> as a module or not. You'd face the same issue with a statically built
> kernel if the bootloader didn't enable it.
Noted. Will revise commit log.
>
>>
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 24 +++++++++++++----------
>> 1 file changed, 14 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 8d4ccd3..7da71ed 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -2688,10 +2688,17 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> if ((phyaddr >= 0) && (phyaddr <= 31))
>> priv->plat->phy_addr = phyaddr;
>>
>> + priv->stmmac_clk = clk_get(priv->device, STMMAC_RESOURCE_NAME);
>
> You can probably use devm_clk_get to make the exit path smaller.
As it stands, the driver does not call clk_put in the exit path.
Using devm_clk_get here would be a good fix.
>
>> + if (IS_ERR(priv->stmmac_clk)) {
>> + pr_warn("%s: warning: cannot get CSR clock\n", __func__);
>
> And dev_warn here.
>
>> + goto error_clk_get;
>> + }
>> + clk_prepare_enable(priv->stmmac_clk);
>> +
>> /* Init MAC and get the capabilities */
>> ret = stmmac_hw_init(priv);
>> if (ret)
>> - goto error_free_netdev;
>> + goto error_hw_init;
>> ndev->netdev_ops = &stmmac_netdev_ops;
>>
>> @@ -2729,12 +2736,6 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> goto error_netdev_register;
>> }
>>
>> - priv->stmmac_clk = clk_get(priv->device, STMMAC_RESOURCE_NAME);
>> - if (IS_ERR(priv->stmmac_clk)) {
>> - pr_warn("%s: warning: cannot get CSR clock\n", __func__);
>> - goto error_clk_get;
>> - }
>> -
>> /* If a specific clk_csr value is passed from the platform
>> * this means that the CSR Clock Range selection cannot be
>> * changed at run-time and it is fixed. Viceversa the driver'll try to
>> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device,
>> }
>> }
>>
>> + clk_disable_unprepare(priv->stmmac_clk);
>> +
>
> Hu? Why do you disable the clock? don't you need it afterwards?
The clock is enabled in *_open (when the network interface is used),
and disabled in *_close.
next prev parent reply other threads:[~2013-12-09 2:43 UTC|newest]
Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 17:29 [PATCH 00/10] net: stmmac: Add sun7i GMAC glue layer Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-07 10:33 ` Maxime Ripard
2013-12-07 10:33 ` Maxime Ripard
2013-12-07 10:33 ` Maxime Ripard
2013-12-09 2:43 ` Chen-Yu Tsai [this message]
2013-12-09 2:43 ` Chen-Yu Tsai
2013-12-09 2:43 ` Chen-Yu Tsai
2013-12-09 10:09 ` [linux-sunxi] " Hans de Goede
2013-12-09 10:09 ` Hans de Goede
2013-12-09 10:09 ` Hans de Goede
2013-12-10 20:05 ` Maxime Ripard
2013-12-10 20:05 ` Maxime Ripard
2013-12-10 20:05 ` Maxime Ripard
2013-12-12 4:31 ` Chen-Yu Tsai
2013-12-12 4:31 ` Chen-Yu Tsai
2013-12-12 4:31 ` Chen-Yu Tsai
2013-12-09 7:14 ` Giuseppe CAVALLARO
2013-12-09 7:14 ` Giuseppe CAVALLARO
2013-12-09 7:14 ` Giuseppe CAVALLARO
2013-12-09 7:26 ` Chen-Yu Tsai
2013-12-09 7:26 ` Chen-Yu Tsai
2013-12-09 7:26 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 02/10] net: stmmac: Honor DT parameter to force DMA store and forward mode Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 21:26 ` David Miller
2013-12-06 21:26 ` David Miller
[not found] ` <20131206.162606.2277176361893801778.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-12-07 1:19 ` Chen-Yu Tsai
2013-12-07 1:23 ` Chen-Yu Tsai
2013-12-07 1:23 ` Chen-Yu Tsai
2013-12-07 1:23 ` Chen-Yu Tsai
2013-12-07 10:07 ` maxime.ripard
2013-12-07 10:07 ` maxime.ripard
2013-12-07 10:07 ` maxime.ripard
2013-12-07 11:06 ` Tomasz Figa
2013-12-07 11:06 ` Tomasz Figa
2013-12-07 11:06 ` Tomasz Figa
2013-12-09 2:59 ` [linux-sunxi] " Chen-Yu Tsai
2013-12-09 2:59 ` Chen-Yu Tsai
2013-12-09 2:59 ` Chen-Yu Tsai
2013-12-10 20:10 ` [linux-sunxi] " maxime.ripard
2013-12-10 20:10 ` maxime.ripard
2013-12-10 20:10 ` maxime.ripard
2013-12-06 17:29 ` [PATCH 03/10] net: stmmac: Use platform data tied with compatible strings Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 21:26 ` David Miller
2013-12-06 21:26 ` David Miller
2013-12-07 2:13 ` Chen-Yu Tsai
2013-12-07 2:13 ` Chen-Yu Tsai
2013-12-07 2:13 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-07 10:27 ` Maxime Ripard
2013-12-07 10:27 ` Maxime Ripard
2013-12-07 10:27 ` Maxime Ripard
2013-12-07 11:12 ` Tomasz Figa
2013-12-07 11:12 ` Tomasz Figa
2013-12-07 11:12 ` Tomasz Figa
2013-12-07 11:46 ` Maxime Ripard
2013-12-07 11:46 ` Maxime Ripard
2013-12-07 11:46 ` Maxime Ripard
2013-12-07 12:50 ` Tomasz Figa
2013-12-07 12:50 ` Tomasz Figa
2013-12-07 12:50 ` Tomasz Figa
2013-12-07 13:34 ` [linux-sunxi] " Emilio López
2013-12-07 13:34 ` Emilio López
2013-12-07 13:34 ` Emilio López
2013-12-09 11:10 ` srinivas kandagatla
2013-12-09 11:10 ` srinivas kandagatla
2013-12-09 11:10 ` srinivas kandagatla
2013-12-09 16:16 ` [linux-sunxi] " Hans de Goede
2013-12-09 16:16 ` Hans de Goede
2013-12-09 16:16 ` Hans de Goede
2013-12-09 17:56 ` [linux-sunxi] " Chen-Yu Tsai
2013-12-09 17:56 ` Chen-Yu Tsai
2013-12-09 17:56 ` Chen-Yu Tsai
2013-12-09 19:04 ` [linux-sunxi] " Hans de Goede
2013-12-09 19:04 ` Hans de Goede
2013-12-09 19:04 ` Hans de Goede
2013-12-10 20:14 ` [linux-sunxi] " Maxime Ripard
2013-12-10 20:14 ` Maxime Ripard
2013-12-10 20:14 ` Maxime Ripard
2013-12-09 17:34 ` Chen-Yu Tsai
2013-12-09 17:34 ` Chen-Yu Tsai
2013-12-09 17:34 ` Chen-Yu Tsai
2013-12-10 14:59 ` srinivas kandagatla
2013-12-10 14:59 ` srinivas kandagatla
2013-12-10 14:59 ` srinivas kandagatla
2013-12-10 20:23 ` Maxime Ripard
2013-12-10 20:23 ` Maxime Ripard
2013-12-10 20:23 ` Maxime Ripard
2013-12-11 12:17 ` Chen-Yu Tsai
2013-12-11 12:17 ` Chen-Yu Tsai
2013-12-11 12:17 ` Chen-Yu Tsai
2013-12-11 14:45 ` srinivas kandagatla
2013-12-11 14:45 ` srinivas kandagatla
2013-12-11 14:45 ` srinivas kandagatla
2013-12-12 7:27 ` Chen-Yu Tsai
2013-12-12 7:27 ` Chen-Yu Tsai
2013-12-12 7:27 ` Chen-Yu Tsai
2013-12-12 9:04 ` Maxime Ripard
2013-12-12 9:04 ` Maxime Ripard
2013-12-12 9:04 ` Maxime Ripard
2013-12-12 10:31 ` Chen-Yu Tsai
2013-12-12 10:31 ` Chen-Yu Tsai
2013-12-12 10:31 ` Chen-Yu Tsai
2013-12-13 10:38 ` Maxime Ripard
2013-12-13 10:38 ` Maxime Ripard
2013-12-13 10:38 ` Maxime Ripard
2013-12-24 3:27 ` [linux-sunxi] " Chen-Yu Tsai
2013-12-24 3:27 ` Chen-Yu Tsai
2013-12-24 3:27 ` Chen-Yu Tsai
2014-01-02 13:11 ` [linux-sunxi] " srinivas kandagatla
2014-01-02 13:11 ` srinivas kandagatla
2014-01-02 13:11 ` srinivas kandagatla
2014-01-07 10:24 ` [linux-sunxi] " Chen-Yu Tsai
2014-01-07 10:24 ` Chen-Yu Tsai
2014-01-07 10:24 ` Chen-Yu Tsai
2013-12-09 11:21 ` srinivas kandagatla
2013-12-09 11:21 ` srinivas kandagatla
2013-12-09 11:21 ` srinivas kandagatla
2013-12-09 13:44 ` Sergei Shtylyov
2013-12-09 13:44 ` Sergei Shtylyov
2013-12-09 13:44 ` Sergei Shtylyov
2013-12-09 15:45 ` [linux-sunxi] " Chen-Yu Tsai
2013-12-09 15:45 ` Chen-Yu Tsai
2013-12-09 15:45 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 05/10] ARM: dts: sun7i: Add GMAC controller node to sun7i DTSI Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 06/10] ARM: dts: sun7i: Add pin muxing options for the GMAC Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 07/10] ARM: dts: sun7i: cubietruck: Enable " Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 21:09 ` Florian Fainelli
2013-12-06 21:09 ` Florian Fainelli
2013-12-06 21:09 ` Florian Fainelli
2013-12-07 1:35 ` Chen-Yu Tsai
2013-12-07 1:35 ` Chen-Yu Tsai
2013-12-07 1:35 ` Chen-Yu Tsai
2013-12-07 1:57 ` Florian Fainelli
2013-12-07 1:57 ` Florian Fainelli
2013-12-07 1:57 ` Florian Fainelli
2013-12-09 2:55 ` Chen-Yu Tsai
2013-12-09 2:55 ` Chen-Yu Tsai
2013-12-09 2:55 ` Chen-Yu Tsai
2013-12-09 17:48 ` Florian Fainelli
2013-12-09 17:48 ` Florian Fainelli
2013-12-09 17:48 ` Florian Fainelli
2013-12-10 4:11 ` Chen-Yu Tsai
2013-12-10 4:11 ` Chen-Yu Tsai
2013-12-10 4:11 ` Chen-Yu Tsai
2013-12-10 17:23 ` Florian Fainelli
2013-12-10 17:23 ` Florian Fainelli
2013-12-10 17:23 ` Florian Fainelli
2013-12-13 10:21 ` Giuseppe CAVALLARO
2013-12-13 10:21 ` Giuseppe CAVALLARO
2013-12-13 10:21 ` Giuseppe CAVALLARO
2013-12-13 10:21 ` Giuseppe CAVALLARO
2013-12-06 17:29 ` [PATCH 08/10] ARM: dts: sun7i: cubieboard2: Enable GMAC instead of EMAC Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 21:10 ` Florian Fainelli
2013-12-06 21:10 ` Florian Fainelli
2013-12-06 21:10 ` Florian Fainelli
2013-12-06 17:29 ` [PATCH 09/10] ARM: dts: sun7i: olinuxino-micro: " Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 10/10] ARM: dts: sun7i: Add ethernet alias for GMAC Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-06 17:29 ` Chen-Yu Tsai
2013-12-07 10:15 ` Maxime Ripard
2013-12-07 10:15 ` Maxime Ripard
2013-12-07 10:15 ` Maxime Ripard
2013-12-07 16:20 ` Chen-Yu Tsai
2013-12-07 16:20 ` Chen-Yu Tsai
2013-12-07 16:20 ` Chen-Yu Tsai
2013-12-06 20:52 ` [linux-sunxi] [PATCH 00/10] net: stmmac: Add sun7i GMAC glue layer Michal Suchanek
2013-12-06 20:52 ` Michal Suchanek
2013-12-06 20:52 ` Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v65YOSq_BMWSzSHX8w_hbo+0vwquBT2pnLuwNVZkWRfLvA@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rob.herring@calxeda.com \
--cc=srinivas.kandagatla@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.