From: Chen-Yu Tsai <wens@csie.org> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>, Boris Brezillon <boris.brezillon@free-electrons.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, dri-devel <dri-devel@lists.freedesktop.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org> Subject: Re: [PATCH 06/20] drm/sun4i: allow dclk to modify its parent rate Date: Tue, 17 May 2016 01:18:44 +0800 [thread overview] Message-ID: <CAGb2v65tiUt9FvmJ2RaZdXaAFEznKZZjycO+tZcP-4spOAjObQ@mail.gmail.com> (raw) In-Reply-To: <1463402840-17062-7-git-send-email-maxime.ripard@free-electrons.com> Hi, On Mon, May 16, 2016 at 8:47 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The pixel clock being only a divider of its parent clock, depending on the > resolution, it's expected to change its parent rate. Add that flag so that > the clock framework knows it. This should be squashed into the previous patch. Otherwise, the previous one doesn't really fix things, and probably makes things worse as it assumes the parent clock would be changed. ChenYu > Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/gpu/drm/sun4i/sun4i_dotclock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_dotclock.c b/drivers/gpu/drm/sun4i/sun4i_dotclock.c > index 1ddf6d7a7107..5b3463197c48 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_dotclock.c > +++ b/drivers/gpu/drm/sun4i/sun4i_dotclock.c > @@ -170,6 +170,7 @@ int sun4i_dclk_create(struct device *dev, struct sun4i_tcon *tcon) > init.ops = &sun4i_dclk_ops; > init.parent_names = &parent_name; > init.num_parents = 1; > + init.flags = CLK_SET_RATE_PARENT; > > dclk->regmap = tcon->regs; > dclk->hw.init = &init; > -- > 2.8.2 >
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/20] drm/sun4i: allow dclk to modify its parent rate Date: Tue, 17 May 2016 01:18:44 +0800 [thread overview] Message-ID: <CAGb2v65tiUt9FvmJ2RaZdXaAFEznKZZjycO+tZcP-4spOAjObQ@mail.gmail.com> (raw) In-Reply-To: <1463402840-17062-7-git-send-email-maxime.ripard@free-electrons.com> Hi, On Mon, May 16, 2016 at 8:47 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The pixel clock being only a divider of its parent clock, depending on the > resolution, it's expected to change its parent rate. Add that flag so that > the clock framework knows it. This should be squashed into the previous patch. Otherwise, the previous one doesn't really fix things, and probably makes things worse as it assumes the parent clock would be changed. ChenYu > Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/gpu/drm/sun4i/sun4i_dotclock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_dotclock.c b/drivers/gpu/drm/sun4i/sun4i_dotclock.c > index 1ddf6d7a7107..5b3463197c48 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_dotclock.c > +++ b/drivers/gpu/drm/sun4i/sun4i_dotclock.c > @@ -170,6 +170,7 @@ int sun4i_dclk_create(struct device *dev, struct sun4i_tcon *tcon) > init.ops = &sun4i_dclk_ops; > init.parent_names = &parent_name; > init.num_parents = 1; > + init.flags = CLK_SET_RATE_PARENT; > > dclk->regmap = tcon->regs; > dclk->hw.init = &init; > -- > 2.8.2 >
next prev parent reply other threads:[~2016-05-16 17:18 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-16 12:47 [PATCH 00/20] drm: Add Support for Passive RGB to VGA bridges Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 01/20] clk: fixed-factor: Pass clk rates change to the parent Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-06-10 12:30 ` Maxime Ripard 2016-06-10 12:30 ` Maxime Ripard [not found] ` <1463402840-17062-2-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-06-17 23:05 ` Michael Turquette 2016-06-17 23:05 ` Michael Turquette 2016-06-17 23:05 ` Michael Turquette 2016-06-20 8:54 ` Maxime Ripard 2016-06-20 8:54 ` Maxime Ripard 2016-06-20 8:54 ` Maxime Ripard 2016-06-20 19:57 ` Michael Turquette 2016-06-20 19:57 ` Michael Turquette 2016-06-20 19:57 ` Michael Turquette 2016-05-16 12:47 ` [PATCH 03/20] clk: sunxi: tcon-ch1: Do not return a negative error in get_parent Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 16:05 ` Chen-Yu Tsai 2016-05-16 16:05 ` Chen-Yu Tsai 2016-06-10 9:50 ` Maxime Ripard 2016-06-10 9:50 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 04/20] clk: sunxi: display: Add per-clock flags Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 15:21 ` Chen-Yu Tsai 2016-05-16 15:21 ` Chen-Yu Tsai 2016-06-10 9:50 ` Maxime Ripard 2016-06-10 9:50 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 05/20] drm/sun4i: request exact rates to our parents Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 06/20] drm/sun4i: allow dclk to modify its parent rate Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 17:18 ` Chen-Yu Tsai [this message] 2016-05-16 17:18 ` Chen-Yu Tsai 2016-05-25 12:01 ` Maxime Ripard 2016-05-25 12:01 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 07/20] drm/sun4i: rgb: Validate the clock rate Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 08/20] drm/sun4i: rgb: panel is an error pointer Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-17 3:51 ` Chen-Yu Tsai 2016-05-17 3:51 ` Chen-Yu Tsai 2016-05-25 12:06 ` Maxime Ripard 2016-05-25 12:06 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 09/20] drm/sun4i: defer only if we didn't find our panel Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard [not found] ` <1463402840-17062-10-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-05-17 3:52 ` Chen-Yu Tsai 2016-05-17 3:52 ` Chen-Yu Tsai 2016-05-17 3:52 ` Chen-Yu Tsai 2016-05-25 12:09 ` Maxime Ripard 2016-05-25 12:09 ` Maxime Ripard 2016-05-25 12:09 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 10/20] drm/sun4i: remove simplefb at probe Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 11/20] drm/sun4i: Convert to connector register helpers Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 12/20] drm/sun4i: Add bridge support Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 13:12 ` Daniel Vetter 2016-05-16 13:12 ` Daniel Vetter 2016-05-25 16:29 ` Maxime Ripard 2016-05-25 16:29 ` Maxime Ripard 2016-05-25 16:29 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 13/20] drm/bridge: Add RGB to VGA " Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 13:24 ` Laurent Pinchart 2016-05-16 13:24 ` Laurent Pinchart 2016-05-16 13:24 ` Laurent Pinchart 2016-05-26 8:53 ` Maxime Ripard 2016-05-26 8:53 ` Maxime Ripard 2016-05-26 9:16 ` Russell King - ARM Linux 2016-05-26 9:16 ` Russell King - ARM Linux 2016-05-16 14:07 ` Rob Herring 2016-05-16 14:07 ` Rob Herring 2016-05-16 14:07 ` Rob Herring 2016-05-26 9:38 ` Maxime Ripard 2016-05-26 9:38 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 14/20] ARM: sun5i: a13: Add LCD pins Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 17:13 ` Chen-Yu Tsai 2016-05-16 17:13 ` Chen-Yu Tsai 2016-05-25 12:33 ` Maxime Ripard 2016-05-25 12:33 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 16/20] ARM: sun5i: a13-olinuxino: Enable VGA bridge Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 17/20] ARM: multi_v7: Enable sun4i DRM driver Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-17 3:36 ` Chen-Yu Tsai 2016-05-17 3:36 ` Chen-Yu Tsai 2016-05-16 12:47 ` [PATCH 18/20] ARM: multi_v7: enable VGA bridge Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard [not found] ` <1463402840-17062-1-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-05-16 12:47 ` [PATCH 02/20] clk: multiplier: Prevent the multiplier from under / over flowing Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-06-10 12:31 ` Maxime Ripard 2016-06-10 12:31 ` Maxime Ripard 2016-06-20 20:50 ` Michael Turquette 2016-06-20 20:50 ` Michael Turquette 2016-06-20 20:50 ` Michael Turquette 2016-06-21 9:20 ` Maxime Ripard 2016-06-21 9:20 ` Maxime Ripard 2016-06-21 9:20 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 15/20] ARM: sun5i: Move display blocks to A13 Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` [PATCH 19/20] ARM: sunxi: Enable sun4i DRM driver Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 15:01 ` Chen-Yu Tsai 2016-05-16 15:01 ` Chen-Yu Tsai 2016-05-16 12:47 ` [PATCH 20/20] ARM: sunxi: Enable VGA bridge Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard 2016-05-16 12:47 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGb2v65tiUt9FvmJ2RaZdXaAFEznKZZjycO+tZcP-4spOAjObQ@mail.gmail.com \ --to=wens@csie.org \ --cc=airlied@linux.ie \ --cc=boris.brezillon@free-electrons.com \ --cc=daniel.vetter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.