Re: [PATCH 2/2] arm64: dts: allwinner: Transpeed 8K618-T: add WiFi nodes - Chen-Yu Tsai

From: Chen-Yu Tsai <wens@csie.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Andre Przywara <andre.przywara@arm.com>,
	linux-sunxi@lists.linux.dev,  devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 Nick Alilovic <nickalilovic@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: allwinner: Transpeed 8K618-T: add WiFi nodes
Date: Tue, 6 Feb 2024 09:03:21 +0800	[thread overview]
Message-ID: <CAGb2v66=s-k5xNtL9N_Tyzzk92u_32Hk_+V+rFVYne3=fnMjdA@mail.gmail.com> (raw)
In-Reply-To: <8371906.NyiUUSuA9g@jernej-laptop>

On Tue, Feb 6, 2024 at 2:26 AM Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
>
> Dne nedelja, 04. februar 2024 ob 10:32:55 CET je Andre Przywara napisal(a):
> > In contrast to other devices using Allwinner SoCs, the Transpeed 8K618-T
> > TV box uses a mainline supported WiFi chip: it's a Broadcom 4335
> > compatible, packaged by a company called Murata.
> > It works nicely with the Linux driver, when providing the respective
> > firmware files.
> >
> > Add the required DT nodes to let the kernel find the SDIO device.
>
> Can you reword message in a way to omit Linux?

Probably reword it to say "add nodes so that custom MAC addresses can be
associated with it"?

> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> >  .../sun50i-h618-transpeed-8k618-t.dts         | 23 +++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts
> > index 8ea1fd41aeba..7ec4098e707b 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts
> > @@ -16,6 +16,7 @@ / {
> >
> >       aliases {
> >               serial0 = &uart0;
> > +             ethernet1 = &sdio_wifi;
> >       };
> >
> >       chosen {
> > @@ -39,6 +40,15 @@ reg_vcc3v3: vcc3v3 {
> >               regulator-max-microvolt = <3300000>;
> >               regulator-always-on;
> >       };
> > +
> > +     wifi_pwrseq: wifi_pwrseq {
> > +             compatible = "mmc-pwrseq-simple";
> > +             clocks = <&rtc CLK_OSC32K_FANOUT>;
> > +             clock-names = "ext_clock";
> > +             pinctrl-0 = <&x32clk_fanout_pin>;
> > +             pinctrl-names = "default";
> > +             reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
> > +     };
> >  };
> >
> >  &ehci0 {
> > @@ -60,6 +70,19 @@ &mmc0 {
> >       status = "okay";
> >  };
> >
> > +&mmc1 {
> > +     vmmc-supply = <&reg_dldo1>;
> > +     vqmmc-supply = <&reg_aldo1>;
> > +     mmc-pwrseq = <&wifi_pwrseq>;
> > +     bus-width = <4>;
> > +     non-removable;
> > +     status = "okay";
> > +
> > +     sdio_wifi: wifi@1 {
> > +             reg = <1>;
> > +     };
>
> I don't think this node and alias are useful in any way. SDIO scan will find
> device regardless and potential mac property set up by bootloader will be
> ignored anyway.

If a node with the matching function number is found, the MMC core will
associate the node with the SDIO function device before calling the probe
function. It has worked correctly for quite some time.

If the driver isn't taking the MAC address given in the DT, then that's
a driver issue.

ChenYu

> Best regards,
> Jernej
>
> > +};
> > +
> >  &mmc2 {
> >       vmmc-supply = <&reg_dldo1>;
> >       vqmmc-supply = <&reg_aldo1>;
> >
>
>
>
>