From: Barry Song <21cnbao@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
LAK <linux-arm-kernel@lists.infradead.org>, x86 <x86@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Linux Doc Mailing List" <linux-doc@vger.kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Arnd Bergmann" <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
"Darren Hart" <darren@os.amperecomputing.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
huzhanyuan@oppo.com, "李培锋(wink)" <lipeifeng@oppo.com>,
"张诗明(Simon Zhang)" <zhangshiming@oppo.com>, 郭健 <guojian@oppo.com>,
"real mz" <realmz6@gmail.com>,
"Barry Song" <v-songbaohua@oppo.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, "Nadav Amit" <namit@vmware.com>,
"Mel Gorman" <mgorman@suse.de>
Subject: Re: [PATCH 3/4] mm: rmap: Extend tlbbatch APIs to fit new platforms
Date: Fri, 8 Jul 2022 09:12:14 +1200 [thread overview]
Message-ID: <CAGsJ_4zdAjBVbmWXC_M=530QwC=SnuK9783dcaNSCywZAJwgsw@mail.gmail.com> (raw)
In-Reply-To: <be65d342-0d4d-473c-2ba8-bc58b708bfac@intel.com>
On Fri, Jul 8, 2022 at 4:43 AM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 7/7/22 05:52, Barry Song wrote:
> > static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch,
> > - struct mm_struct *mm)
> > + struct mm_struct *mm,
> > + struct vm_area_struct *vma,
> > + unsigned long uaddr)
> > {
>
> It's not a huge deal, but could we pass 'vma' _instead_ of 'mm'? The
> implementations could then just use vma->vm_mm instead of the passed-in mm.
Yes, Dave. Peter made the same suggestion in 4/4.
will get this fixed in v2.
Thanks
Barry
WARNING: multiple messages have this Message-ID (diff)
From: Barry Song <21cnbao@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
LAK <linux-arm-kernel@lists.infradead.org>, x86 <x86@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Linux Doc Mailing List" <linux-doc@vger.kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Arnd Bergmann" <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
"Darren Hart" <darren@os.amperecomputing.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
huzhanyuan@oppo.com, "李培锋(wink)" <lipeifeng@oppo.com>,
"张诗明(Simon Zhang)" <zhangshiming@oppo.com>, 郭健 <guojian@oppo.com>,
"real mz" <realmz6@gmail.com>,
"Barry Song" <v-songbaohua@oppo.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, "Nadav Amit" <namit@vmware.com>,
"Mel Gorman" <mgorman@suse.de>
Subject: Re: [PATCH 3/4] mm: rmap: Extend tlbbatch APIs to fit new platforms
Date: Fri, 8 Jul 2022 09:12:14 +1200 [thread overview]
Message-ID: <CAGsJ_4zdAjBVbmWXC_M=530QwC=SnuK9783dcaNSCywZAJwgsw@mail.gmail.com> (raw)
In-Reply-To: <be65d342-0d4d-473c-2ba8-bc58b708bfac@intel.com>
On Fri, Jul 8, 2022 at 4:43 AM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 7/7/22 05:52, Barry Song wrote:
> > static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch,
> > - struct mm_struct *mm)
> > + struct mm_struct *mm,
> > + struct vm_area_struct *vma,
> > + unsigned long uaddr)
> > {
>
> It's not a huge deal, but could we pass 'vma' _instead_ of 'mm'? The
> implementations could then just use vma->vm_mm instead of the passed-in mm.
Yes, Dave. Peter made the same suggestion in 4/4.
will get this fixed in v2.
Thanks
Barry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-07 21:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 12:52 [PATCH 0/4] mm: arm64: bring up BATCHED_UNMAP_TLB_FLUSH Barry Song
2022-07-07 12:52 ` Barry Song
2022-07-07 12:52 ` [PATCH 1/4] Revert "Documentation/features: mark BATCHED_UNMAP_TLB_FLUSH doesn't apply to ARM64" Barry Song
2022-07-07 12:52 ` Barry Song
2022-07-07 12:52 ` [PATCH 2/4] mm: rmap: Allow platforms without mm_cpumask to defer TLB flush Barry Song
2022-07-07 12:52 ` Barry Song
2022-07-08 6:36 ` Nadav Amit
2022-07-08 6:36 ` Nadav Amit
2022-07-08 6:59 ` Barry Song
2022-07-08 6:59 ` Barry Song
2022-07-08 8:08 ` Nadav Amit
2022-07-08 8:08 ` Nadav Amit
2022-07-08 8:17 ` Barry Song
2022-07-08 8:17 ` Barry Song
2022-07-08 8:27 ` Peter Zijlstra
2022-07-08 8:27 ` Peter Zijlstra
2022-07-11 0:30 ` Barry Song
2022-07-11 0:30 ` Barry Song
2022-07-07 12:52 ` [PATCH 3/4] mm: rmap: Extend tlbbatch APIs to fit new platforms Barry Song
2022-07-07 12:52 ` Barry Song
2022-07-07 16:43 ` Dave Hansen
2022-07-07 16:43 ` Dave Hansen
2022-07-07 21:12 ` Barry Song [this message]
2022-07-07 21:12 ` Barry Song
2022-07-07 12:52 ` [PATCH 4/4] arm64: support batched/deferred tlb shootdown during page reclamation Barry Song
2022-07-07 12:52 ` Barry Song
2022-07-07 13:49 ` Peter Zijlstra
2022-07-07 13:49 ` Peter Zijlstra
2022-07-07 21:10 ` Barry Song
2022-07-07 21:10 ` Barry Song
2022-07-08 6:21 ` Yicong Yang
2022-07-08 6:21 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGsJ_4zdAjBVbmWXC_M=530QwC=SnuK9783dcaNSCywZAJwgsw@mail.gmail.com' \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=darren@os.amperecomputing.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=guojian@oppo.com \
--cc=hpa@zytor.com \
--cc=huzhanyuan@oppo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lipeifeng@oppo.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=realmz6@gmail.com \
--cc=tglx@linutronix.de \
--cc=v-songbaohua@oppo.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.