Re: [PATCH v2] ASoC: Intel: kbl_rt5663_rt5514_max98927: Add dmic format constraint - Yu-Hsuan Hsu

From: Yu-Hsuan Hsu <yuhsuan@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Tzung-Bi Shih <tzungbi@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: Intel: kbl_rt5663_rt5514_max98927: Add dmic format constraint
Date: Mon, 11 Nov 2019 10:04:26 +0800	[thread overview]
Message-ID: <CAGvk5PqdnJ61XZMw3e4ja8YZ5_LAwJP3n=fYyKHQRwv_A+Kdwg@mail.gmail.com> (raw)
In-Reply-To: <20190923162940.199580-1-yuhsuan@chromium.org>

Hi all,

Does anyone have time to review this patch? It should be easy to
review because it just a format constraint.

Thanks,
Yu-Hsuan

Yu-Hsuan Hsu <yuhsuan@chromium.org> 於 2019年9月24日 週二 上午12:29寫道：
>
> On KBL platform, the microphone is attached to external codec(rt5514)
> instead of PCH. However, TDM slot between PCH and codec is 16 bits only.
> In order to avoid setting wrong format, we should add a constraint to
> force to use 16 bits format forever.
>
> Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
> ---
> I have updated the commit message. Please see whether it is clear
> enough. Thanks.
>  sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> index 74dda8784f1a01..67b276a65a8d2d 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> @@ -400,6 +400,9 @@ static int kabylake_dmic_startup(struct snd_pcm_substream *substream)
>         snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
>                         dmic_constraints);
>
> +       runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
> +       snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
> +
>         return snd_pcm_hw_constraint_list(substream->runtime, 0,
>                         SNDRV_PCM_HW_PARAM_RATE, &constraints_rates);
>  }
> --
> 2.23.0.351.gc4317032e6-goog
>