Re: [PATCH 7/8] drm/radeon: remove radeon_bo_clear_va

From: Jerome Glisse <j.glisse@gmail.com>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 7/8] drm/radeon: remove radeon_bo_clear_va
Date: Tue, 11 Sep 2012 12:12:19 -0400	[thread overview]
Message-ID: <CAH3drwYUHcEx_ngTDaLhTh4+tyLzn2FNRSqCOy4uFbkUstph6w@mail.gmail.com> (raw)
In-Reply-To: <1347372604-26557-7-git-send-email-deathsimple@vodafone.de>

On Tue, Sep 11, 2012 at 10:10 AM, Christian König
<deathsimple@vodafone.de> wrote:
> It is unnecessary when we remove the va in drm_close.
>
> Signed-off-by: Christian König <deathsimple@vodafone.de>

NAK there is case for which drm_close is not call like ib pool and
other iirc. This clear va is really a safety net.

> ---
>  drivers/gpu/drm/radeon/radeon_object.c |   11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 8d23b7e..d210fe5 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -46,16 +46,6 @@ static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>   * function are calling it.
>   */
>
> -void radeon_bo_clear_va(struct radeon_bo *bo)
> -{
> -       struct radeon_bo_va *bo_va, *tmp;
> -
> -       list_for_each_entry_safe(bo_va, tmp, &bo->va, bo_list) {
> -               /* remove from all vm address space */
> -               radeon_vm_bo_rmv(bo->rdev, bo_va->vm, bo);
> -       }
> -}
> -
>  static void radeon_ttm_bo_destroy(struct ttm_buffer_object *tbo)
>  {
>         struct radeon_bo *bo;
> @@ -65,7 +55,6 @@ static void radeon_ttm_bo_destroy(struct ttm_buffer_object *tbo)
>         list_del_init(&bo->list);
>         mutex_unlock(&bo->rdev->gem.mutex);
>         radeon_bo_clear_surface_reg(bo);
> -       radeon_bo_clear_va(bo);
>         drm_gem_object_release(&bo->gem_base);
>         kfree(bo);
>  }
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel