Re: [PATCH 15/16] drm/radeon: implement ring commit tracking

From: Jerome Glisse <j.glisse@gmail.com>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 15/16] drm/radeon: implement ring commit tracking
Date: Mon, 9 Jul 2012 12:12:24 -0400	[thread overview]
Message-ID: <CAH3drwYi9dQLNC0bSU5AVe==UA=0ukMq1OJsQK52KR=VMz6f4w@mail.gmail.com> (raw)
In-Reply-To: <4FFAFD68.8030205@vodafone.de>

On Mon, Jul 9, 2012 at 11:48 AM, Christian König
<deathsimple@vodafone.de> wrote:
> On 09.07.2012 17:36, Jerome Glisse wrote:
>>
>> On Mon, Jul 9, 2012 at 6:42 AM, Christian König <deathsimple@vodafone.de>
>> wrote:
>>>
>>> Signed-off-by: Christian König <deathsimple@vodafone.de>
>>
>> Bit too complex to my taste, what about attached patch, it's lot
>> simpler. (Haven't tested
>> the patch but it should work)
>
> Cool idea! Depending on the writeback mechanism might not be the best part
> of it, but in general speaking all rings should have more than enough
> scratch registers for that!!!
>
> Going to change it.
>
> Thanks,
> Christian.
>

Note that i haven't included the fence emit intentionally idea being
if you resume ring you fence to emit the last fence as soon as
possible and just pretend that the faulty ib succeeded.

Cheers,
Jerome