From: Adam Ford <aford173@gmail.com> To: linux-fbdev@vger.kernel.org Cc: Linux-OMAP <linux-omap@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Adam Ford <adam.ford@logicpd.com>, stable <stable@vger.kernel.org> Subject: Re: [PATCH] fbdev/omap: fix max fclk divider for omap36xx Date: Fri, 8 Nov 2019 07:10:45 -0600 [thread overview] Message-ID: <CAHCN7xJ9aAHjHToM5mGixWvJb7hAOenST7Fkett84nNQdUghmA@mail.gmail.com> (raw) In-Reply-To: <20191018130507.29893-1-aford173@gmail.com> On Fri, Oct 18, 2019 at 8:05 AM Adam Ford <aford173@gmail.com> wrote: > > The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk > (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not > correct, and using divider of 32 breaks DSS with a flood or underflows > and sync losts. Dividers up to 31 seem to work fine. > > There is another patch to the DT files to limit the divider correctly, > but as the DSS driver also needs to know the maximum divider to be able > to iteratively find good rates, we also need to do the fix in the DSS > driver. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: stable@vger.kernel.org # linux-4.4.y only This is basically the same patch as the only Tomi reviewed for 4.9, but it is based on 4.4. Is there any way these can be integrated? thank you, adam > > diff --git a/drivers/video/fbdev/omap2/dss/dss.c b/drivers/video/fbdev/omap2/dss/dss.c > index 9200a8668b49..a57c3a5f4bf8 100644 > --- a/drivers/video/fbdev/omap2/dss/dss.c > +++ b/drivers/video/fbdev/omap2/dss/dss.c > @@ -843,7 +843,7 @@ static const struct dss_features omap34xx_dss_feats = { > }; > > static const struct dss_features omap3630_dss_feats = { > - .fck_div_max = 32, > + .fck_div_max = 31, > .dss_fck_multiplier = 1, > .parent_clk_name = "dpll4_ck", > .dpi_select_source = &dss_dpi_select_source_omap2_omap3, > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com> To: linux-fbdev@vger.kernel.org Cc: Linux-OMAP <linux-omap@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Adam Ford <adam.ford@logicpd.com>, stable <stable@vger.kernel.org> Subject: Re: [PATCH] fbdev/omap: fix max fclk divider for omap36xx Date: Fri, 08 Nov 2019 13:10:45 +0000 [thread overview] Message-ID: <CAHCN7xJ9aAHjHToM5mGixWvJb7hAOenST7Fkett84nNQdUghmA@mail.gmail.com> (raw) In-Reply-To: <20191018130507.29893-1-aford173@gmail.com> On Fri, Oct 18, 2019 at 8:05 AM Adam Ford <aford173@gmail.com> wrote: > > The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk > (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not > correct, and using divider of 32 breaks DSS with a flood or underflows > and sync losts. Dividers up to 31 seem to work fine. > > There is another patch to the DT files to limit the divider correctly, > but as the DSS driver also needs to know the maximum divider to be able > to iteratively find good rates, we also need to do the fix in the DSS > driver. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: stable@vger.kernel.org # linux-4.4.y only This is basically the same patch as the only Tomi reviewed for 4.9, but it is based on 4.4. Is there any way these can be integrated? thank you, adam > > diff --git a/drivers/video/fbdev/omap2/dss/dss.c b/drivers/video/fbdev/omap2/dss/dss.c > index 9200a8668b49..a57c3a5f4bf8 100644 > --- a/drivers/video/fbdev/omap2/dss/dss.c > +++ b/drivers/video/fbdev/omap2/dss/dss.c > @@ -843,7 +843,7 @@ static const struct dss_features omap34xx_dss_feats = { > }; > > static const struct dss_features omap3630_dss_feats = { > - .fck_div_max = 32, > + .fck_div_max = 31, > .dss_fck_multiplier = 1, > .parent_clk_name = "dpll4_ck", > .dpi_select_source = &dss_dpi_select_source_omap2_omap3, > -- > 2.17.1 >
next prev parent reply other threads:[~2019-11-08 13:10 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-18 13:05 [PATCH] fbdev/omap: fix max fclk divider for omap36xx Adam Ford 2019-10-18 13:05 ` Adam Ford 2019-10-21 8:44 ` Tomi Valkeinen 2019-10-21 8:44 ` Tomi Valkeinen 2019-10-21 8:44 ` Tomi Valkeinen 2019-10-21 11:07 ` Adam Ford 2019-10-21 11:07 ` Adam Ford 2019-11-08 13:10 ` Adam Ford [this message] 2019-11-08 13:10 ` Adam Ford -- strict thread matches above, loose matches on Subject: below -- 2019-10-18 12:49 Adam Ford 2019-10-18 12:49 ` Adam Ford 2019-10-21 8:42 ` Tomi Valkeinen 2019-10-21 8:42 ` Tomi Valkeinen 2019-10-21 8:42 ` Tomi Valkeinen 2019-11-08 13:09 ` Adam Ford 2019-11-08 13:09 ` Adam Ford
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHCN7xJ9aAHjHToM5mGixWvJb7hAOenST7Fkett84nNQdUghmA@mail.gmail.com \ --to=aford173@gmail.com \ --cc=adam.ford@logicpd.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=stable@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.