From: Adam Ford <aford173@gmail.com> To: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, David Lechner <david@lechnology.com>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: Re: [PATCH v2 1/4] ARM: davinci: fix cpufreq registration on da850-evm Date: Tue, 26 Mar 2019 09:00:21 -0500 [thread overview] Message-ID: <CAHCN7xJj_aA8XFR6=ZxO-WrfkJRY5fS6NgjHbeqpdfhUnn1apA@mail.gmail.com> (raw) In-Reply-To: <20190322133105.5945-2-brgl@bgdev.pl> On Fri, Mar 22, 2019 at 8:31 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > The system_rev variable is never set on davinci and is always 0, so > we're using the default max operating point of 300MHz. The cvdd supply > comes from the tps6507 pmic and the voltage can go all the way to 1.3V > so the maximum supported rate should be 456MHz. My understanding is that only certain revisions of the silicon can go to 456MHz. The L138's Datasheet lists both a 456 and 375 version. I cannot find a way to read a register to determine which version of the silicon is available. Maybe Sekhar can confirm. adam > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/mach-davinci/board-da850-evm.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c > index 1fdc9283a8c5..58b2a485b527 100644 > --- a/arch/arm/mach-davinci/board-da850-evm.c > +++ b/arch/arm/mach-davinci/board-da850-evm.c > @@ -1155,17 +1155,7 @@ static struct edma_rsv_info *da850_edma_rsv[2] = { > #ifdef CONFIG_CPU_FREQ > static __init int da850_evm_init_cpufreq(void) > { > - switch (system_rev & 0xF) { > - case 3: > - da850_max_speed = 456000; > - break; > - case 2: > - da850_max_speed = 408000; > - break; > - case 1: > - da850_max_speed = 372000; > - break; > - } > + da850_max_speed = 456000; > > return da850_register_cpufreq("pll0_sysclk3"); > } > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com> To: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, David Lechner <david@lechnology.com>, Kevin Hilman <khilman@kernel.org>, Sekhar Nori <nsekhar@ti.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Rob Herring <robh+dt@kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 1/4] ARM: davinci: fix cpufreq registration on da850-evm Date: Tue, 26 Mar 2019 09:00:21 -0500 [thread overview] Message-ID: <CAHCN7xJj_aA8XFR6=ZxO-WrfkJRY5fS6NgjHbeqpdfhUnn1apA@mail.gmail.com> (raw) In-Reply-To: <20190322133105.5945-2-brgl@bgdev.pl> On Fri, Mar 22, 2019 at 8:31 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > The system_rev variable is never set on davinci and is always 0, so > we're using the default max operating point of 300MHz. The cvdd supply > comes from the tps6507 pmic and the voltage can go all the way to 1.3V > so the maximum supported rate should be 456MHz. My understanding is that only certain revisions of the silicon can go to 456MHz. The L138's Datasheet lists both a 456 and 375 version. I cannot find a way to read a register to determine which version of the silicon is available. Maybe Sekhar can confirm. adam > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/mach-davinci/board-da850-evm.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c > index 1fdc9283a8c5..58b2a485b527 100644 > --- a/arch/arm/mach-davinci/board-da850-evm.c > +++ b/arch/arm/mach-davinci/board-da850-evm.c > @@ -1155,17 +1155,7 @@ static struct edma_rsv_info *da850_edma_rsv[2] = { > #ifdef CONFIG_CPU_FREQ > static __init int da850_evm_init_cpufreq(void) > { > - switch (system_rev & 0xF) { > - case 3: > - da850_max_speed = 456000; > - break; > - case 2: > - da850_max_speed = 408000; > - break; > - case 1: > - da850_max_speed = 372000; > - break; > - } > + da850_max_speed = 456000; > > return da850_register_cpufreq("pll0_sysclk3"); > } > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-26 14:00 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-22 13:31 [PATCH v2 0/4] ARM: da850: enable cpufreq in DT mode Bartosz Golaszewski 2019-03-22 13:31 ` Bartosz Golaszewski 2019-03-22 13:31 ` [PATCH v2 1/4] ARM: davinci: fix cpufreq registration on da850-evm Bartosz Golaszewski 2019-03-22 13:31 ` Bartosz Golaszewski 2019-03-22 13:31 ` Bartosz Golaszewski 2019-03-26 14:00 ` Adam Ford [this message] 2019-03-26 14:00 ` Adam Ford 2019-03-26 17:51 ` Bartosz Golaszewski 2019-03-26 17:51 ` Bartosz Golaszewski 2019-03-27 11:14 ` Sekhar Nori 2019-03-27 11:14 ` Sekhar Nori 2019-04-03 12:50 ` Bartosz Golaszewski 2019-04-03 12:50 ` Bartosz Golaszewski 2019-04-03 15:49 ` Adam Ford 2019-04-03 15:49 ` Adam Ford 2019-04-04 10:01 ` Bartosz Golaszewski 2019-04-04 10:01 ` Bartosz Golaszewski 2019-04-04 11:14 ` Adam Ford 2019-04-04 11:14 ` Adam Ford 2019-04-04 11:14 ` Adam Ford 2019-04-08 8:48 ` Sekhar Nori 2019-04-08 8:48 ` Sekhar Nori 2019-03-22 13:31 ` [PATCH v2 2/4] ARM: dts: da850: add cpu node and operating points to DT Bartosz Golaszewski 2019-03-22 13:31 ` Bartosz Golaszewski 2019-03-22 13:31 ` [PATCH v2 3/4] ARM: dts: da850-evm: enable cpufreq Bartosz Golaszewski 2019-03-22 13:31 ` Bartosz Golaszewski 2019-03-26 14:15 ` Adam Ford 2019-03-26 14:15 ` Adam Ford 2019-03-22 13:31 ` [PATCH v2 4/4] ARM: davinci_all_defconfig: Enable CPUFREQ_DT Bartosz Golaszewski 2019-03-22 13:31 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHCN7xJj_aA8XFR6=ZxO-WrfkJRY5fS6NgjHbeqpdfhUnn1apA@mail.gmail.com' \ --to=aford173@gmail.com \ --cc=bgolaszewski@baylibre.com \ --cc=brgl@bgdev.pl \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nsekhar@ti.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.