From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [RFC v3 42/45] nfs: Add richacl support
Date: Fri, 29 May 2015 09:15:07 -0400 [thread overview]
Message-ID: <CAHQdGtQCPqC=L1bxVzEQgwE16P6SX79c02Ex4=D02EQ5BgdGRA@mail.gmail.com> (raw)
In-Reply-To: <CAHQdGtQyEH9V_XJaQQgPkKGJLy__D0J6cmAHASeEXCZkCCrBjg@mail.gmail.com>
On Thu, May 28, 2015 at 7:06 PM, Trond Myklebust
<trond.myklebust@primarydata.com> wrote:
> On Fri, Apr 24, 2015 at 7:04 AM, Andreas Gruenbacher
> <andreas.gruenbacher@gmail.com> wrote:
>> Changes nfs to support the "system.richacl" xattr instead of "system.nfs4_acl".
>>
>
> NACK.
>
> You may declare a userspace syscall ABI that is more than 10 years old
> to be deprecated, but you are not allowed to remove it.
>
So having revisited the reasons why I chose the system.nfs4_acl
interface when we did NFSv4 ACLs, I'm not sure we should implement
system.richacl for the NFS client at all.
The problem is that you are 100% reliant on an accurate idmapper in
order to convert the name@domain to a _correct_ uid/gid. It isn't
sufficient to convert to just any valid uid/gid, because if your ACL
tool is trying to edit the ACL, you can end up converting all those
DENY modes for user 'Johnny_Rotten@blackhats.are.us' into DENY modes
for user 'nobody'.
...and yes, libnfsidmap will happily convert all unknown
user/groupnames into whatever uid/gid corresponds to 'nobody' without
returning an error.
Your assertion that "when symbolic user@domain and group@domain names
are used in the acl, user-space needs to perform ID mapping in the
same way as the kernel" is WRONG. User space needs do no such thing,
and that was the whole point of the interface; to allow the user to
specify ACLs in a format that is checked only on the _server_, and not
on the client.
Trond
next prev parent reply other threads:[~2015-05-29 13:15 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 11:03 [RFC v3 00/45] Richacls Andreas Gruenbacher
2015-04-24 11:03 ` Andreas Gruenbacher
2015-04-24 11:03 ` [RFC v3 01/45] vfs: Minor documentation fix Andreas Gruenbacher
2015-04-24 11:03 ` [RFC v3 02/45] uapi: Remove kernel internal declaration Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 03/45] nfsd: Checking for acl support does not require fetching any acls Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 04/45] vfs: Shrink struct posix_acl Andreas Gruenbacher
2015-04-25 7:56 ` Rasmus Villemoes
2015-04-27 10:27 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 05/45] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 06/45] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 07/45] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 08/45] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 09/45] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 10/45] richacl: In-memory representation and helper functions Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 11/45] richacl: Permission mapping functions Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 12/45] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2015-05-12 21:44 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 13/45] richacl: Update the file masks in chmod() Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 14/45] richacl: Permission check algorithm Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-05-22 21:08 ` J. Bruce Fields
2015-05-27 11:25 ` Andreas Grünbacher
2015-05-27 15:05 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 15/45] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 16/45] vfs: Cache richacl in struct inode Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 17/45] richacl: Create-time inheritance Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 18/45] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls Andreas Gruenbacher
2015-05-14 19:28 ` J. Bruce Fields
2015-05-15 20:04 ` J. Bruce Fields
2015-05-15 20:04 ` J. Bruce Fields
2015-05-15 20:51 ` J. Bruce Fields
2015-05-15 20:51 ` J. Bruce Fields
2015-05-27 9:24 ` Andreas Grünbacher
2015-05-27 15:06 ` J. Bruce Fields
2015-05-27 15:06 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 20/45] richacl: Automatic Inheritance Andreas Gruenbacher
2015-05-13 18:01 ` Frank Filz
2015-05-13 18:01 ` Frank Filz
2015-05-13 20:22 ` Andreas Grünbacher
2015-05-13 20:22 ` Andreas Grünbacher
2015-05-13 20:28 ` Jeremy Allison
2015-05-13 20:28 ` Jeremy Allison
2015-05-13 20:47 ` Andreas Grünbacher
2015-05-13 20:47 ` Andreas Grünbacher
2015-05-13 20:55 ` Jeremy Allison
2015-05-13 20:55 ` Jeremy Allison
2015-05-13 21:15 ` Andreas Grünbacher
2015-05-13 21:15 ` Andreas Grünbacher
2015-05-13 20:38 ` Frank Filz
2015-05-13 20:38 ` Frank Filz
2015-05-13 21:05 ` Andreas Grünbacher
2015-05-13 22:56 ` Frank Filz
2015-05-13 22:56 ` Frank Filz
2015-05-13 23:52 ` Andreas Grünbacher
2015-05-14 15:09 ` J. Bruce Fields
2015-05-14 15:09 ` J. Bruce Fields
2015-05-18 20:39 ` Andreas Grünbacher
2015-05-18 20:39 ` Andreas Grünbacher
2015-05-18 20:43 ` J. Bruce Fields
2015-05-18 20:43 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 21/45] richacl: xattr mapping functions Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 22/45] vfs: Add richacl permission checking Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 23/45] ext4: Add richacl support Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 24/45] ext4: Add richacl feature flag Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 25/45] richacl: acl editing helper functions Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-05-15 21:33 ` J. Bruce Fields
2015-05-15 21:33 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 26/45] richacl: Move everyone@ aces down the acl Andreas Gruenbacher
2015-05-18 21:20 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 27/45] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 28/45] richacl: Isolate the owner and group classes Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 29/45] richacl: Apply the file masks to a richacl Andreas Gruenbacher
2015-05-26 21:56 ` J. Bruce Fields
2015-05-26 21:56 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 30/45] richacl: Create richacl from mode values Andreas Gruenbacher
2015-05-28 19:24 ` J. Bruce Fields
2015-05-28 19:24 ` J. Bruce Fields
2015-05-28 19:25 ` J. Bruce Fields
2015-05-28 19:58 ` Andreas Grünbacher
2015-05-28 19:58 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 31/45] richacl: Create acl with masks applied in richacl_from_mode() Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 32/45] nfsd: Remove dead declarations Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher
2015-05-28 19:52 ` J. Bruce Fields
2015-05-28 19:52 ` J. Bruce Fields
2015-05-28 20:28 ` Andreas Grünbacher
2015-05-28 20:28 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 34/45] nfsd: Use richacls as internal acl representation Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 35/45] nfsd: Add richacl support Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 36/45] NFSv4: Fix GETATTR bitmap verification Andreas Gruenbacher
2015-05-28 20:33 ` J. Bruce Fields
2015-05-28 20:33 ` J. Bruce Fields
2015-05-28 20:50 ` Trond Myklebust
2015-05-28 20:50 ` Trond Myklebust
2015-05-28 21:05 ` Andreas Grünbacher
2015-05-28 21:05 ` Andreas Grünbacher
2015-05-28 21:40 ` Trond Myklebust
2015-05-28 21:40 ` Trond Myklebust
2015-05-28 21:55 ` Trond Myklebust
2015-05-28 21:55 ` Trond Myklebust
2015-05-28 22:09 ` Andreas Grünbacher
2015-05-28 22:09 ` Andreas Grünbacher
2015-05-28 22:24 ` Trond Myklebust
2015-05-28 22:24 ` Trond Myklebust
2015-05-28 22:28 ` Andreas Grünbacher
2015-05-28 21:15 ` Andreas Grünbacher
2015-05-28 21:28 ` Andreas Grünbacher
2015-05-28 21:28 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 37/45] nfs/sunrpc: No more encode and decode function pointer casting Andreas Gruenbacher
2015-05-28 23:11 ` Trond Myklebust
2015-05-28 23:40 ` Andreas Grünbacher
2015-05-29 0:37 ` Trond Myklebust
2015-05-29 0:37 ` Trond Myklebust
2015-05-29 15:30 ` Andreas Grünbacher
2015-05-29 15:30 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 38/45] nfs/sunrpc: Return status code from encode functions Andreas Gruenbacher
2015-05-28 23:39 ` Trond Myklebust
2015-05-28 23:39 ` Trond Myklebust
2015-04-24 11:04 ` [RFC v3 39/45] nfs3: Return posix acl encode errors Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 40/45] nfs: Remove unused xdr page offsets in getacl/setacl arguments Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 41/45] rpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher
2015-05-28 23:24 ` Trond Myklebust
2015-05-28 23:24 ` Trond Myklebust
2015-05-29 15:46 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 42/45] nfs: Add richacl support Andreas Gruenbacher
2015-05-28 23:06 ` Trond Myklebust
2015-05-28 23:29 ` Andreas Grünbacher
2015-05-29 13:15 ` Trond Myklebust [this message]
2015-05-29 15:00 ` Andreas Grünbacher
2015-05-29 15:24 ` Trond Myklebust
2015-05-29 15:45 ` Andreas Grünbacher
2015-05-29 15:54 ` Trond Myklebust
2015-05-29 15:54 ` Trond Myklebust
2015-05-29 15:54 ` Frank Filz
2015-05-29 15:54 ` Frank Filz
2016-06-23 16:37 ` Weston Andros Adamson
2016-06-23 17:15 ` Frank Filz
2016-07-15 8:00 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 43/45] uapi/nfs: Add NFSv4.1 ACL definitions Andreas Gruenbacher
2015-05-29 14:57 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 44/45] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 45/45] nfs: " Andreas Gruenbacher
2015-05-23 15:50 ` [RFC v3 00/45] Richacls Jeremy Allison
2015-05-23 15:50 ` Jeremy Allison
2015-05-23 15:56 ` Andreas Grünbacher
2015-05-23 15:56 ` Andreas Grünbacher
2015-06-25 20:03 ` Stefan (metze) Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQdGtQCPqC=L1bxVzEQgwE16P6SX79c02Ex4=D02EQ5BgdGRA@mail.gmail.com' \
--to=trond.myklebust@primarydata.com \
--cc=andreas.gruenbacher@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.