From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com> To: Frank Filz <ffilzlnx@mindspring.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [RFC v3 20/45] richacl: Automatic Inheritance Date: Wed, 13 May 2015 22:22:21 +0200 [thread overview] Message-ID: <CAHpGcMLBb+s7iSv9SN1eRX-46VU_wnbGX1nXrNkuaYVp8v0jYw@mail.gmail.com> (raw) In-Reply-To: <0b2401d08da6$dad0d0f0$907272d0$@mindspring.com> 2015-05-13 20:01 GMT+02:00 Frank Filz <ffilzlnx@mindspring.com>: > You might want to edit your commit message to use RICHACL_ instead of ACL4_ > constants... Indeed, thanks. >> Linux does not have a way of creating files without setting the file permission >> bits, so all files created inside a directory with ACL4_AUTO_INHERIT set will >> also have the ACL4_PROTECTED flag set. This effectively disables Automatic >> Inheritance. >> >> Protocols which support creating files without specifying permissions can >> explicitly clear the ACL4_PROTECTED flag after creating a file and reset the file >> masks to "undo" applying the create mode; see >> richacl_compute_max_masks(). >> This is a workaround; a mechanism that would allow a process to indicate to >> the kernel to ignore the create mode when there are inherited permissions >> would fix this problem. > > I'm unclear what will actually be supported for inherited ACLs here. Is this > saying that on a pure-Linux system even with Linux NFS client and Linux NFS > server, we still would not see inheritance since the mode will always be > present on create? What do you mean by "we still would not see inheritance"? Inheritance at file create time will still happen; a few extra flags will be set when Automatic Inheritance is "on" in the parent directory as indicated by the RICHACL_AUTO_INHERIT flag. Files are inevitably created with defined permissions (the mode parameter to system calls like creat and mkdir), which means that the RICHACL_PROTECTED flag needs to be set, though. When someone changes the permissions of an entire directory tree, that change will not propagate to or below files with the protected flag set. That being said, a daemon like Samba can "fake" full Automatic Inheritance by creating files and then updating the inherited acls appropriately. This will inevitably be racy, but unless someone implements a way to create files without a mode, that's the closest Samba can get. Creating files atomically with explicitly defined acls is another operation which NFSv4 does but the Linux kernel does not support. > My interest here is in how we will tie the Ganesha user space NFS server > into this feature. I don't know, what do you currently do when somebody creates a file without defining the permissions (mode, acl or dacl)? That's the relevant case. The kernel nfs daemon currently creates a file with mode 0 --- which doesn't seem right. Andreas
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Grünbacher" <andreas.gruenbacher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Frank Filz <ffilzlnx-mn4gwa5WIIQysxA8WJXlww@public.gmane.org> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [RFC v3 20/45] richacl: Automatic Inheritance Date: Wed, 13 May 2015 22:22:21 +0200 [thread overview] Message-ID: <CAHpGcMLBb+s7iSv9SN1eRX-46VU_wnbGX1nXrNkuaYVp8v0jYw@mail.gmail.com> (raw) In-Reply-To: <0b2401d08da6$dad0d0f0$907272d0$@mindspring.com> 2015-05-13 20:01 GMT+02:00 Frank Filz <ffilzlnx-mn4gwa5WIIQysxA8WJXlww@public.gmane.org>: > You might want to edit your commit message to use RICHACL_ instead of ACL4_ > constants... Indeed, thanks. >> Linux does not have a way of creating files without setting the file permission >> bits, so all files created inside a directory with ACL4_AUTO_INHERIT set will >> also have the ACL4_PROTECTED flag set. This effectively disables Automatic >> Inheritance. >> >> Protocols which support creating files without specifying permissions can >> explicitly clear the ACL4_PROTECTED flag after creating a file and reset the file >> masks to "undo" applying the create mode; see >> richacl_compute_max_masks(). >> This is a workaround; a mechanism that would allow a process to indicate to >> the kernel to ignore the create mode when there are inherited permissions >> would fix this problem. > > I'm unclear what will actually be supported for inherited ACLs here. Is this > saying that on a pure-Linux system even with Linux NFS client and Linux NFS > server, we still would not see inheritance since the mode will always be > present on create? What do you mean by "we still would not see inheritance"? Inheritance at file create time will still happen; a few extra flags will be set when Automatic Inheritance is "on" in the parent directory as indicated by the RICHACL_AUTO_INHERIT flag. Files are inevitably created with defined permissions (the mode parameter to system calls like creat and mkdir), which means that the RICHACL_PROTECTED flag needs to be set, though. When someone changes the permissions of an entire directory tree, that change will not propagate to or below files with the protected flag set. That being said, a daemon like Samba can "fake" full Automatic Inheritance by creating files and then updating the inherited acls appropriately. This will inevitably be racy, but unless someone implements a way to create files without a mode, that's the closest Samba can get. Creating files atomically with explicitly defined acls is another operation which NFSv4 does but the Linux kernel does not support. > My interest here is in how we will tie the Ganesha user space NFS server > into this feature. I don't know, what do you currently do when somebody creates a file without defining the permissions (mode, acl or dacl)? That's the relevant case. The kernel nfs daemon currently creates a file with mode 0 --- which doesn't seem right. Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-13 20:22 UTC|newest] Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-24 11:03 [RFC v3 00/45] Richacls Andreas Gruenbacher 2015-04-24 11:03 ` Andreas Gruenbacher 2015-04-24 11:03 ` [RFC v3 01/45] vfs: Minor documentation fix Andreas Gruenbacher 2015-04-24 11:03 ` [RFC v3 02/45] uapi: Remove kernel internal declaration Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 03/45] nfsd: Checking for acl support does not require fetching any acls Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 04/45] vfs: Shrink struct posix_acl Andreas Gruenbacher 2015-04-25 7:56 ` Rasmus Villemoes 2015-04-27 10:27 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 05/45] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 06/45] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 07/45] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 08/45] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 09/45] vfs: Add permission flags for setting file attributes Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 10/45] richacl: In-memory representation and helper functions Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 11/45] richacl: Permission mapping functions Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 12/45] richacl: Compute maximum file masks from an acl Andreas Gruenbacher 2015-05-12 21:44 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 13/45] richacl: Update the file masks in chmod() Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 14/45] richacl: Permission check algorithm Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-05-22 21:08 ` J. Bruce Fields 2015-05-27 11:25 ` Andreas Grünbacher 2015-05-27 15:05 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 15/45] vfs: Cache base_acl objects in inodes Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 16/45] vfs: Cache richacl in struct inode Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 17/45] richacl: Create-time inheritance Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 18/45] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls Andreas Gruenbacher 2015-05-14 19:28 ` J. Bruce Fields 2015-05-15 20:04 ` J. Bruce Fields 2015-05-15 20:04 ` J. Bruce Fields 2015-05-15 20:51 ` J. Bruce Fields 2015-05-15 20:51 ` J. Bruce Fields 2015-05-27 9:24 ` Andreas Grünbacher 2015-05-27 15:06 ` J. Bruce Fields 2015-05-27 15:06 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 20/45] richacl: Automatic Inheritance Andreas Gruenbacher 2015-05-13 18:01 ` Frank Filz 2015-05-13 18:01 ` Frank Filz 2015-05-13 20:22 ` Andreas Grünbacher [this message] 2015-05-13 20:22 ` Andreas Grünbacher 2015-05-13 20:28 ` Jeremy Allison 2015-05-13 20:28 ` Jeremy Allison 2015-05-13 20:47 ` Andreas Grünbacher 2015-05-13 20:47 ` Andreas Grünbacher 2015-05-13 20:55 ` Jeremy Allison 2015-05-13 20:55 ` Jeremy Allison 2015-05-13 21:15 ` Andreas Grünbacher 2015-05-13 21:15 ` Andreas Grünbacher 2015-05-13 20:38 ` Frank Filz 2015-05-13 20:38 ` Frank Filz 2015-05-13 21:05 ` Andreas Grünbacher 2015-05-13 22:56 ` Frank Filz 2015-05-13 22:56 ` Frank Filz 2015-05-13 23:52 ` Andreas Grünbacher 2015-05-14 15:09 ` J. Bruce Fields 2015-05-14 15:09 ` J. Bruce Fields 2015-05-18 20:39 ` Andreas Grünbacher 2015-05-18 20:39 ` Andreas Grünbacher 2015-05-18 20:43 ` J. Bruce Fields 2015-05-18 20:43 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 21/45] richacl: xattr mapping functions Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 22/45] vfs: Add richacl permission checking Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 23/45] ext4: Add richacl support Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 24/45] ext4: Add richacl feature flag Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 25/45] richacl: acl editing helper functions Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-05-15 21:33 ` J. Bruce Fields 2015-05-15 21:33 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 26/45] richacl: Move everyone@ aces down the acl Andreas Gruenbacher 2015-05-18 21:20 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 27/45] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 28/45] richacl: Isolate the owner and group classes Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 29/45] richacl: Apply the file masks to a richacl Andreas Gruenbacher 2015-05-26 21:56 ` J. Bruce Fields 2015-05-26 21:56 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 30/45] richacl: Create richacl from mode values Andreas Gruenbacher 2015-05-28 19:24 ` J. Bruce Fields 2015-05-28 19:24 ` J. Bruce Fields 2015-05-28 19:25 ` J. Bruce Fields 2015-05-28 19:58 ` Andreas Grünbacher 2015-05-28 19:58 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 31/45] richacl: Create acl with masks applied in richacl_from_mode() Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 32/45] nfsd: Remove dead declarations Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher 2015-05-28 19:52 ` J. Bruce Fields 2015-05-28 19:52 ` J. Bruce Fields 2015-05-28 20:28 ` Andreas Grünbacher 2015-05-28 20:28 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 34/45] nfsd: Use richacls as internal acl representation Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 35/45] nfsd: Add richacl support Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 36/45] NFSv4: Fix GETATTR bitmap verification Andreas Gruenbacher 2015-05-28 20:33 ` J. Bruce Fields 2015-05-28 20:33 ` J. Bruce Fields 2015-05-28 20:50 ` Trond Myklebust 2015-05-28 20:50 ` Trond Myklebust 2015-05-28 21:05 ` Andreas Grünbacher 2015-05-28 21:05 ` Andreas Grünbacher 2015-05-28 21:40 ` Trond Myklebust 2015-05-28 21:40 ` Trond Myklebust 2015-05-28 21:55 ` Trond Myklebust 2015-05-28 21:55 ` Trond Myklebust 2015-05-28 22:09 ` Andreas Grünbacher 2015-05-28 22:09 ` Andreas Grünbacher 2015-05-28 22:24 ` Trond Myklebust 2015-05-28 22:24 ` Trond Myklebust 2015-05-28 22:28 ` Andreas Grünbacher 2015-05-28 21:15 ` Andreas Grünbacher 2015-05-28 21:28 ` Andreas Grünbacher 2015-05-28 21:28 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 37/45] nfs/sunrpc: No more encode and decode function pointer casting Andreas Gruenbacher 2015-05-28 23:11 ` Trond Myklebust 2015-05-28 23:40 ` Andreas Grünbacher 2015-05-29 0:37 ` Trond Myklebust 2015-05-29 0:37 ` Trond Myklebust 2015-05-29 15:30 ` Andreas Grünbacher 2015-05-29 15:30 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 38/45] nfs/sunrpc: Return status code from encode functions Andreas Gruenbacher 2015-05-28 23:39 ` Trond Myklebust 2015-05-28 23:39 ` Trond Myklebust 2015-04-24 11:04 ` [RFC v3 39/45] nfs3: Return posix acl encode errors Andreas Gruenbacher 2015-04-24 11:04 ` Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 40/45] nfs: Remove unused xdr page offsets in getacl/setacl arguments Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 41/45] rpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher 2015-05-28 23:24 ` Trond Myklebust 2015-05-28 23:24 ` Trond Myklebust 2015-05-29 15:46 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 42/45] nfs: Add richacl support Andreas Gruenbacher 2015-05-28 23:06 ` Trond Myklebust 2015-05-28 23:29 ` Andreas Grünbacher 2015-05-29 13:15 ` Trond Myklebust 2015-05-29 15:00 ` Andreas Grünbacher 2015-05-29 15:24 ` Trond Myklebust 2015-05-29 15:45 ` Andreas Grünbacher 2015-05-29 15:54 ` Trond Myklebust 2015-05-29 15:54 ` Trond Myklebust 2015-05-29 15:54 ` Frank Filz 2015-05-29 15:54 ` Frank Filz 2016-06-23 16:37 ` Weston Andros Adamson 2016-06-23 17:15 ` Frank Filz 2016-07-15 8:00 ` Andreas Grünbacher 2015-04-24 11:04 ` [RFC v3 43/45] uapi/nfs: Add NFSv4.1 ACL definitions Andreas Gruenbacher 2015-05-29 14:57 ` J. Bruce Fields 2015-04-24 11:04 ` [RFC v3 44/45] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher 2015-04-24 11:04 ` [RFC v3 45/45] nfs: " Andreas Gruenbacher 2015-05-23 15:50 ` [RFC v3 00/45] Richacls Jeremy Allison 2015-05-23 15:50 ` Jeremy Allison 2015-05-23 15:56 ` Andreas Grünbacher 2015-05-23 15:56 ` Andreas Grünbacher 2015-06-25 20:03 ` Stefan (metze) Metzmacher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHpGcMLBb+s7iSv9SN1eRX-46VU_wnbGX1nXrNkuaYVp8v0jYw@mail.gmail.com \ --to=andreas.gruenbacher@gmail.com \ --cc=ffilzlnx@mindspring.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.