From: Mina Almasry <almasrymina@google.com>
To: David Rientjes <rientjes@google.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Shakeel Butt <shakeelb@google.com>, shuah <shuah@kernel.org>,
Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
cgroups@vger.kernel.org,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH v10 1/8] hugetlb_cgroup: Add hugetlb_cgroup reservation counter
Date: Mon, 3 Feb 2020 15:16:21 -0800 [thread overview]
Message-ID: <CAHS8izNq17U6i-RzHZ6tCOVQza_CGngJc0X2ZmqPHTH7y4kfdg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001291303230.175731@chino.kir.corp.google.com>
> > Proposed Solution:
> > A new page counter named
> > 'hugetlb.xMB.reservation_[limit|usage|max_usage]_in_bytes'. This counter has
> > slightly different semantics than
> > 'hugetlb.xMB.[limit|usage|max_usage]_in_bytes':
> >
>
> Changelog looks like it needs to be updated with the new resv naming.
>
I updated to the rsvd naming, which you suggested earlier and Mike
agreed was better.
> > +
> > static inline
> > struct hugetlb_cgroup *hugetlb_cgroup_from_css(struct cgroup_subsys_state *s)
> > {
>
> Small nit: hugetlb_cgroup_get_counter(), to me, implies incrementing a
> reference count, perhaps a better name would be in order. No strong
> preference.
>
Changed
> > /* Add the events file */
> > - cft = &h->cgroup_files_dfl[2];
> > + cft = &h->cgroup_files_dfl[4];
> > snprintf(cft->name, MAX_CFTYPE_NAME, "%s.events", buf);
> > cft->private = MEMFILE_PRIVATE(idx, 0);
> > cft->seq_show = hugetlb_events_show;
>
> Any cleanup to __hugetlb_cgroup_file_dfl_init() and
> __hugetlb_cgroup_file_legacy_init() that is possible would be great in a
> follow-up patch :)
>
Will do!
> Other than that, this looks very straight forward.
>
> Acked-by: David Rientjes <rientjes@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mina Almasry <almasrymina-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Mike Kravetz
<mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
shuah <shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Greg Thelen <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Aneesh Kumar
<aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH v10 1/8] hugetlb_cgroup: Add hugetlb_cgroup reservation counter
Date: Mon, 3 Feb 2020 15:16:21 -0800 [thread overview]
Message-ID: <CAHS8izNq17U6i-RzHZ6tCOVQza_CGngJc0X2ZmqPHTH7y4kfdg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001291303230.175731-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
> > Proposed Solution:
> > A new page counter named
> > 'hugetlb.xMB.reservation_[limit|usage|max_usage]_in_bytes'. This counter has
> > slightly different semantics than
> > 'hugetlb.xMB.[limit|usage|max_usage]_in_bytes':
> >
>
> Changelog looks like it needs to be updated with the new resv naming.
>
I updated to the rsvd naming, which you suggested earlier and Mike
agreed was better.
> > +
> > static inline
> > struct hugetlb_cgroup *hugetlb_cgroup_from_css(struct cgroup_subsys_state *s)
> > {
>
> Small nit: hugetlb_cgroup_get_counter(), to me, implies incrementing a
> reference count, perhaps a better name would be in order. No strong
> preference.
>
Changed
> > /* Add the events file */
> > - cft = &h->cgroup_files_dfl[2];
> > + cft = &h->cgroup_files_dfl[4];
> > snprintf(cft->name, MAX_CFTYPE_NAME, "%s.events", buf);
> > cft->private = MEMFILE_PRIVATE(idx, 0);
> > cft->seq_show = hugetlb_events_show;
>
> Any cleanup to __hugetlb_cgroup_file_dfl_init() and
> __hugetlb_cgroup_file_legacy_init() that is possible would be great in a
> follow-up patch :)
>
Will do!
> Other than that, this looks very straight forward.
>
> Acked-by: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2020-02-03 23:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 1:26 [PATCH v10 1/8] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-15 1:26 ` [PATCH v10 2/8] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-17 19:26 ` Mike Kravetz
2020-01-17 19:34 ` Mina Almasry
2020-01-17 19:34 ` Mina Almasry
2020-01-29 21:21 ` David Rientjes
2020-01-29 21:21 ` David Rientjes
2020-01-29 21:21 ` David Rientjes
2020-01-30 0:41 ` Mike Kravetz
2020-01-15 1:26 ` [PATCH v10 3/8] hugetlb_cgroup: add reservation accounting for private mappings Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-17 22:57 ` Mike Kravetz
2020-01-29 21:28 ` David Rientjes
2020-01-29 21:28 ` David Rientjes
2020-01-29 21:28 ` David Rientjes
2020-02-03 23:17 ` Mina Almasry
2020-02-03 23:17 ` Mina Almasry
2020-01-15 1:26 ` [PATCH v10 4/8] hugetlb: disable region_add file_region coalescing Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-21 18:50 ` Mike Kravetz
2020-01-15 1:26 ` [PATCH v10 5/8] hugetlb_cgroup: add accounting for shared mappings Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-15 1:26 ` [PATCH v10 6/8] hugetlb_cgroup: support noreserve mappings Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-15 1:26 ` [PATCH v10 7/8] hugetlb_cgroup: Add hugetlb_cgroup reservation tests Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-23 9:15 ` Sandipan Das
2020-01-23 9:15 ` Sandipan Das
2020-01-23 20:05 ` Mina Almasry
2020-01-23 20:05 ` Mina Almasry
2020-01-29 21:00 ` David Rientjes
2020-01-29 21:00 ` David Rientjes
2020-01-29 21:00 ` David Rientjes
2020-01-30 6:11 ` Sandipan Das
2020-02-03 23:18 ` Mina Almasry
2020-02-03 23:18 ` Mina Almasry
2020-02-03 23:18 ` Mina Almasry
2020-01-15 1:26 ` [PATCH v10 8/8] hugetlb_cgroup: Add hugetlb_cgroup reservation docs Mina Almasry
2020-01-15 1:26 ` Mina Almasry
2020-01-16 22:44 ` [PATCH v10 1/8] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Mike Kravetz
2020-01-16 22:44 ` Mike Kravetz
2020-01-29 21:09 ` David Rientjes
2020-01-29 21:09 ` David Rientjes
2020-01-29 21:09 ` David Rientjes
2020-02-03 23:16 ` Mina Almasry [this message]
2020-02-03 23:16 ` Mina Almasry
2020-02-03 23:16 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHS8izNq17U6i-RzHZ6tCOVQza_CGngJc0X2ZmqPHTH7y4kfdg@mail.gmail.com \
--to=almasrymina@google.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.