From: Jens Wiklander <jens.wiklander@linaro.org>
To: "Thomas, Rijo-john" <Rijo-john.Thomas@amd.com>
Cc: Colin King <colin.king@canonical.com>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Gary R Hook <gary.hook@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee
Date: Fri, 17 Jan 2020 13:16:03 +0100 [thread overview]
Message-ID: <CAHUa44FFshAu+4Ue3Q4MDb_+sHCr20KjM3N=usJZsANvdr47eg@mail.gmail.com> (raw)
In-Reply-To: <e6fd526e-316f-539d-9f5e-c039041c4f2e@amd.com>
On Fri, Jan 17, 2020 at 7:40 AM Thomas, Rijo-john
<Rijo-john.Thomas@amd.com> wrote:
>
>
>
> On 16/01/20 9:18 pm, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the memory allocation failure checks on drv_data and
> > amdtee are using IS_ERR rather than checking for a null pointer.
> > Fix these checks to use the conventional null pointer check.
> >
> > Addresses-Coverity: ("Dereference null return")
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Thanks,
Jens
>
> Thanks,
> Rijo
>
> > ---
> > V2: update to apply against cryptodev-2.6 tree tip
> > ---
> > drivers/tee/amdtee/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> > index be8937eb5d43..6370bb55f512 100644
> > --- a/drivers/tee/amdtee/core.c
> > +++ b/drivers/tee/amdtee/core.c
> > @@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
> > }
> >
> > drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> > - if (IS_ERR(drv_data))
> > + if (!drv_data)
> > return -ENOMEM;
> >
> > amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
> > - if (IS_ERR(amdtee)) {
> > + if (!amdtee) {
> > rc = -ENOMEM;
> > goto err_kfree_drv_data;
> > }
> >
WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: "Thomas, Rijo-john" <Rijo-john.Thomas@amd.com>
Cc: Colin King <colin.king@canonical.com>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Gary R Hook <gary.hook@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee
Date: Fri, 17 Jan 2020 12:16:03 +0000 [thread overview]
Message-ID: <CAHUa44FFshAu+4Ue3Q4MDb_+sHCr20KjM3N=usJZsANvdr47eg@mail.gmail.com> (raw)
In-Reply-To: <e6fd526e-316f-539d-9f5e-c039041c4f2e@amd.com>
On Fri, Jan 17, 2020 at 7:40 AM Thomas, Rijo-john
<Rijo-john.Thomas@amd.com> wrote:
>
>
>
> On 16/01/20 9:18 pm, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the memory allocation failure checks on drv_data and
> > amdtee are using IS_ERR rather than checking for a null pointer.
> > Fix these checks to use the conventional null pointer check.
> >
> > Addresses-Coverity: ("Dereference null return")
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Thanks,
Jens
>
> Thanks,
> Rijo
>
> > ---
> > V2: update to apply against cryptodev-2.6 tree tip
> > ---
> > drivers/tee/amdtee/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> > index be8937eb5d43..6370bb55f512 100644
> > --- a/drivers/tee/amdtee/core.c
> > +++ b/drivers/tee/amdtee/core.c
> > @@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
> > }
> >
> > drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> > - if (IS_ERR(drv_data))
> > + if (!drv_data)
> > return -ENOMEM;
> >
> > amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
> > - if (IS_ERR(amdtee)) {
> > + if (!amdtee) {
> > rc = -ENOMEM;
> > goto err_kfree_drv_data;
> > }
> >
next prev parent reply other threads:[~2020-01-17 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 15:48 [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee Colin King
2020-01-17 6:40 ` Thomas, Rijo-john
2020-01-17 6:52 ` Thomas, Rijo-john
2020-01-17 12:16 ` Jens Wiklander [this message]
2020-01-17 12:16 ` Jens Wiklander
2020-01-22 10:14 ` Herbert Xu
2020-01-22 10:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHUa44FFshAu+4Ue3Q4MDb_+sHCr20KjM3N=usJZsANvdr47eg@mail.gmail.com' \
--to=jens.wiklander@linaro.org \
--cc=Devaraj.Rangasamy@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=colin.king@canonical.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.