Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

From: Mike Lothian <mike@fireburn.co.uk>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: dwmw@amazon.co.uk, iommu@lists.linux-foundation.org,
	joro@8bytes.org, linux-kernel@vger.kernel.org,
	suravee.suthikulpanit@amd.com, tglx@linutronix.de,
	will@kernel.org
Subject: Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume
Date: Thu, 27 Jan 2022 10:50:18 +0000	[thread overview]
Message-ID: <CAHbf0-Ew=LPpYx6MT_Gb8oM-4egTvXuz0H7cYKZxFjFeBz=9Tw@mail.gmail.com> (raw)
In-Reply-To: <495878a237748e3652619e692706b9352969f435.camel@redhat.com>

On Thu, 27 Jan 2022 at 10:22, Maxim Levitsky <mlevitsk@redhat.com> wrote:
>
> On Thu, 2022-01-27 at 00:39 +0000, Mike Lothian wrote:
> > On Wed, 26 Jan 2022 at 10:12, Maxim Levitsky <mlevitsk@redhat.com> wrote:
> > > Great, your system does seem to support GA log
> > > (but a patch to check if, other that assume blindly that it is supported is
> > > something that should be done).
> > >
> > > So could you bump the LOOP_TIMEOUT like by 10x or so and see if the problem goes away?
> > >
> > > (that code should be rewritten to time based wait and not just blindly loop like that,
> > > I also can prepare a patch for that as well).
> > >
> > > Best regards,
> > >         Maxim Levitsky
> > >
> >
> > Hi
> >
> > I've done quite a few restarts with the LOOP_TIMEOUT increased and
> > I've not seen the issue since
>
> Great, so the problem is solved I guess.
> Thanks for the help!
>
>
> I'll send a patch for this in few days to replace this and other similiar timeouts
> with a proper udelay() wait.
>

Thanks for your help