From: Andreas Gruenbacher <agruenba@redhat.com> To: Alexander Viro <viro@zeniv.linux.org.uk>, "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>, "J. Bruce Fields" <bfields@fieldses.org>, Jeff Layton <jlayton@poochiereds.net>, Trond Myklebust <trond.myklebust@primarydata.com>, Anna Schumaker <anna.schumaker@netapp.com>, Dave Chinner <david@fromorbit.com>, linux-ext4 <linux-ext4@vger.kernel.org>, XFS Developers <xfs@oss.sgi.com>, LKML <linux-kernel@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Linux NFS Mailing List <linux-nfs@vger.kernel.org>, linux-cifs@vger.kernel.org, Linux API <linux-api@vger.kernel.org> Cc: Andreas Gruenbacher <agruenba@redhat.com> Subject: Re: [PATCH v15 19/22] richacl: Add richacl xattr handler Date: Wed, 11 Nov 2015 02:16:33 +0100 [thread overview] Message-ID: <CAHc6FU7hZdo7aoz2TmhSuw1Gkr=-+YhP2MLz408w8ZDrf-Y_6A@mail.gmail.com> (raw) In-Reply-To: <1447067343-31479-20-git-send-email-agruenba@redhat.com> On Mon, Nov 9, 2015 at 12:09 PM, Andreas Gruenbacher <agruenba@redhat.com> wrote: > Add richacl xattr handler implementing the xattr operations based on the > get_richacl and set_richacl inode operations. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> > --- > fs/richacl_xattr.c | 78 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/richacl_xattr.h | 2 ++ > 2 files changed, 80 insertions(+) > > diff --git a/fs/richacl_xattr.c b/fs/richacl_xattr.c > index 38473b6..767c1f7 100644 > --- a/fs/richacl_xattr.c > +++ b/fs/richacl_xattr.c > @@ -18,7 +18,9 @@ > #include <linux/fs.h> > #include <linux/slab.h> > #include <linux/module.h> > +#include <linux/xattr.h> > #include <linux/richacl_xattr.h> > +#include <uapi/linux/xattr.h> > > MODULE_LICENSE("GPL"); > > @@ -161,6 +163,82 @@ richacl_to_xattr(struct user_namespace *user_ns, > } > EXPORT_SYMBOL_GPL(richacl_to_xattr); > > +static size_t > +richacl_xattr_list(struct dentry *dentry, char *list, size_t list_len, > + const char *name, size_t name_len, int handler_flags) > +{ > + const size_t size = sizeof(XATTR_NAME_RICHACL); > + > + if (!IS_RICHACL(d_backing_inode(dentry))) > + return 0; > + if (list && size <= list_len) > + memcpy(list, XATTR_NAME_RICHACL, size); > + return size; > +} > + > +static int > +richacl_xattr_get(struct dentry *dentry, const char *name, void *buffer, > + size_t buffer_size, int handler_flags) > +{ > + struct inode *inode = d_backing_inode(dentry); > + struct richacl *acl; > + int error; > + > + if (strcmp(name, "") != 0) > + return -EINVAL; > + if (!IS_RICHACL(inode)) > + return EOPNOTSUPP; This should have been -EOPNOTSUPP instead. > + if (S_ISLNK(inode->i_mode)) > + return -EOPNOTSUPP; > + acl = get_richacl(inode); > + if (IS_ERR(acl)) > + return PTR_ERR(acl); > + if (acl == NULL) > + return -ENODATA; > + error = richacl_to_xattr(&init_user_ns, acl, buffer, buffer_size); > + richacl_put(acl); > + return error; > +} > + > +static int > +richacl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int handler_flags) > +{ > + struct inode *inode = d_backing_inode(dentry); > + struct richacl *acl = NULL; > + int ret; > + > + if (strcmp(name, "") != 0) > + return -EINVAL; > + if (!IS_RICHACL(inode)) > + return -EOPNOTSUPP; > + if (!inode->i_op->set_richacl) > + return -EOPNOTSUPP; > + > + if (!uid_eq(current_fsuid(), inode->i_uid) && > + inode_permission(inode, MAY_CHMOD) && > + !capable(CAP_FOWNER)) > + return -EPERM; > + > + if (value) { > + acl = richacl_from_xattr(&init_user_ns, value, size); > + if (IS_ERR(acl)) > + return PTR_ERR(acl); > + } > + > + ret = inode->i_op->set_richacl(inode, acl); > + richacl_put(acl); > + return ret; > +} > + > +struct xattr_handler richacl_xattr_handler = { > + .prefix = XATTR_NAME_RICHACL, > + .list = richacl_xattr_list, > + .get = richacl_xattr_get, > + .set = richacl_xattr_set, > +}; > +EXPORT_SYMBOL(richacl_xattr_handler); > + > /* > * Fix up the uids and gids in richacl extended attributes in place. > */ > diff --git a/include/linux/richacl_xattr.h b/include/linux/richacl_xattr.h > index 7fc5ca8..45ec27a 100644 > --- a/include/linux/richacl_xattr.h > +++ b/include/linux/richacl_xattr.h > @@ -39,4 +39,6 @@ static inline void richacl_fix_xattr_to_user(void *value, size_t size) > } > #endif > > +extern struct xattr_handler richacl_xattr_handler; > + > #endif /* __RICHACL_XATTR_H */ > -- > 2.5.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com> To: Alexander Viro <viro@zeniv.linux.org.uk>, Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>, "J. Bruce Fields" <bfields@fieldses.org>, Jeff Layton <jlayton@poochiereds.net>, Trond Myklebust <trond.myklebust@primarydata.com>, Anna Schumaker <anna.schumaker@netapp.com>, Dave Chinner <david@fromorbit.com>, linux-ext4 <linux-ext4@vger.kernel.org>, XFS Developers <xfs@oss.sgi.com>, LKML <linux-kernel@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Linux NFS Mailing List <linux-nfs@vger.kernel.org>, linux-cifs@vger.kernel.org, Linux API <linux-api@vger.kernel.org> Cc: Andreas Gruenbacher <agruenba@redhat.com> Subject: Re: [PATCH v15 19/22] richacl: Add richacl xattr handler Date: Wed, 11 Nov 2015 02:16:33 +0100 [thread overview] Message-ID: <CAHc6FU7hZdo7aoz2TmhSuw1Gkr=-+YhP2MLz408w8ZDrf-Y_6A@mail.gmail.com> (raw) In-Reply-To: <1447067343-31479-20-git-send-email-agruenba@redhat.com> On Mon, Nov 9, 2015 at 12:09 PM, Andreas Gruenbacher <agruenba@redhat.com> wrote: > Add richacl xattr handler implementing the xattr operations based on the > get_richacl and set_richacl inode operations. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> > --- > fs/richacl_xattr.c | 78 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/richacl_xattr.h | 2 ++ > 2 files changed, 80 insertions(+) > > diff --git a/fs/richacl_xattr.c b/fs/richacl_xattr.c > index 38473b6..767c1f7 100644 > --- a/fs/richacl_xattr.c > +++ b/fs/richacl_xattr.c > @@ -18,7 +18,9 @@ > #include <linux/fs.h> > #include <linux/slab.h> > #include <linux/module.h> > +#include <linux/xattr.h> > #include <linux/richacl_xattr.h> > +#include <uapi/linux/xattr.h> > > MODULE_LICENSE("GPL"); > > @@ -161,6 +163,82 @@ richacl_to_xattr(struct user_namespace *user_ns, > } > EXPORT_SYMBOL_GPL(richacl_to_xattr); > > +static size_t > +richacl_xattr_list(struct dentry *dentry, char *list, size_t list_len, > + const char *name, size_t name_len, int handler_flags) > +{ > + const size_t size = sizeof(XATTR_NAME_RICHACL); > + > + if (!IS_RICHACL(d_backing_inode(dentry))) > + return 0; > + if (list && size <= list_len) > + memcpy(list, XATTR_NAME_RICHACL, size); > + return size; > +} > + > +static int > +richacl_xattr_get(struct dentry *dentry, const char *name, void *buffer, > + size_t buffer_size, int handler_flags) > +{ > + struct inode *inode = d_backing_inode(dentry); > + struct richacl *acl; > + int error; > + > + if (strcmp(name, "") != 0) > + return -EINVAL; > + if (!IS_RICHACL(inode)) > + return EOPNOTSUPP; This should have been -EOPNOTSUPP instead. > + if (S_ISLNK(inode->i_mode)) > + return -EOPNOTSUPP; > + acl = get_richacl(inode); > + if (IS_ERR(acl)) > + return PTR_ERR(acl); > + if (acl == NULL) > + return -ENODATA; > + error = richacl_to_xattr(&init_user_ns, acl, buffer, buffer_size); > + richacl_put(acl); > + return error; > +} > + > +static int > +richacl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int handler_flags) > +{ > + struct inode *inode = d_backing_inode(dentry); > + struct richacl *acl = NULL; > + int ret; > + > + if (strcmp(name, "") != 0) > + return -EINVAL; > + if (!IS_RICHACL(inode)) > + return -EOPNOTSUPP; > + if (!inode->i_op->set_richacl) > + return -EOPNOTSUPP; > + > + if (!uid_eq(current_fsuid(), inode->i_uid) && > + inode_permission(inode, MAY_CHMOD) && > + !capable(CAP_FOWNER)) > + return -EPERM; > + > + if (value) { > + acl = richacl_from_xattr(&init_user_ns, value, size); > + if (IS_ERR(acl)) > + return PTR_ERR(acl); > + } > + > + ret = inode->i_op->set_richacl(inode, acl); > + richacl_put(acl); > + return ret; > +} > + > +struct xattr_handler richacl_xattr_handler = { > + .prefix = XATTR_NAME_RICHACL, > + .list = richacl_xattr_list, > + .get = richacl_xattr_get, > + .set = richacl_xattr_set, > +}; > +EXPORT_SYMBOL(richacl_xattr_handler); > + > /* > * Fix up the uids and gids in richacl extended attributes in place. > */ > diff --git a/include/linux/richacl_xattr.h b/include/linux/richacl_xattr.h > index 7fc5ca8..45ec27a 100644 > --- a/include/linux/richacl_xattr.h > +++ b/include/linux/richacl_xattr.h > @@ -39,4 +39,6 @@ static inline void richacl_fix_xattr_to_user(void *value, size_t size) > } > #endif > > +extern struct xattr_handler richacl_xattr_handler; > + > #endif /* __RICHACL_XATTR_H */ > -- > 2.5.0 > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-11-11 1:16 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-09 11:08 [PATCH v15 00/22] Richacls (Core and Ext4) Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 01/22] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 04/22] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 05/22] vfs: Add permission flags for setting file attributes Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 06/22] richacl: In-memory representation and helper functions Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 07/22] richacl: Permission mapping functions Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 08/22] richacl: Compute maximum file masks from an acl Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 09/22] richacl: Permission check algorithm Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 10/22] posix_acl: Unexport acl_by_type and make it static Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher [not found] ` <1447067343-31479-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-11-09 11:08 ` [PATCH v15 11/22] vfs: Cache base_acl objects in inodes Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:09 ` [PATCH v15 22/22] ext4: Add richacl feature flag Andreas Gruenbacher 2015-11-09 11:09 ` Andreas Gruenbacher 2015-11-09 11:09 ` Andreas Gruenbacher 2015-11-10 11:29 ` [PATCH v15 00/22] Richacls (Core and Ext4) Christoph Hellwig 2015-11-10 11:29 ` Christoph Hellwig 2015-11-10 11:29 ` Christoph Hellwig [not found] ` <20151110112943.GA17038-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2015-11-10 12:39 ` Andreas Gruenbacher 2015-11-10 12:39 ` Andreas Gruenbacher 2015-11-10 12:39 ` Andreas Gruenbacher [not found] ` <CAHc6FU5g7=wd1Wt4+GCaLJjNu7giruZyAON3VcYn-A=ffYMsmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-11-10 16:43 ` Steve French 2015-11-10 16:43 ` Steve French 2015-11-10 16:43 ` Steve French 2015-11-10 17:07 ` J. Bruce Fields 2015-11-10 17:07 ` J. Bruce Fields 2015-11-10 17:58 ` Andreas Gruenbacher 2015-11-10 17:58 ` Andreas Gruenbacher [not found] ` <CAHc6FU6aWsWO1SOSyNVnbObE0GoE4dr5a3WVTgvX4xn0wum1Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-11-10 19:17 ` J. Bruce Fields 2015-11-10 19:17 ` J. Bruce Fields 2015-11-10 19:17 ` J. Bruce Fields 2015-11-11 7:57 ` Christoph Hellwig 2015-11-11 7:57 ` Christoph Hellwig 2015-11-11 7:57 ` Christoph Hellwig [not found] ` <20151111075707.GA23752-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2015-11-11 13:59 ` Andreas Gruenbacher 2015-11-11 13:59 ` Andreas Gruenbacher 2015-11-11 13:59 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 12/22] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 13/22] vfs: Cache richacl in struct inode Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 14/22] richacl: Update the file masks in chmod() Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 15/22] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 16/22] richacl: Create-time inheritance Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 17/22] richacl: Automatic Inheritance Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:08 ` [PATCH v15 18/22] richacl: xattr mapping functions Andreas Gruenbacher 2015-11-09 11:08 ` Andreas Gruenbacher 2015-11-09 11:09 ` [PATCH v15 19/22] richacl: Add richacl xattr handler Andreas Gruenbacher 2015-11-09 11:09 ` Andreas Gruenbacher 2015-11-11 1:16 ` Andreas Gruenbacher [this message] 2015-11-11 1:16 ` Andreas Gruenbacher 2015-11-09 11:09 ` [PATCH v15 20/22] vfs: Add richacl permission checking Andreas Gruenbacher 2015-11-09 11:09 ` Andreas Gruenbacher 2015-11-09 11:09 ` [PATCH v15 21/22] ext4: Add richacl support Andreas Gruenbacher 2015-11-09 11:09 ` Andreas Gruenbacher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHc6FU7hZdo7aoz2TmhSuw1Gkr=-+YhP2MLz408w8ZDrf-Y_6A@mail.gmail.com' \ --to=agruenba@redhat.com \ --cc=adilger.kernel@dilger.ca \ --cc=anna.schumaker@netapp.com \ --cc=bfields@fieldses.org \ --cc=david@fromorbit.com \ --cc=jlayton@poochiereds.net \ --cc=linux-api@vger.kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=trond.myklebust@primarydata.com \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.