From: Linus Torvalds <torvalds@linux-foundation.org> To: David Howells <dhowells@redhat.com> Cc: Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nicolas Dichtel <nicolas.dichtel@6wind.com>, raven@themaw.net, Christian Brauner <christian@brauner.io>, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block <linux-block@vger.kernel.org>, LSM List <linux-security-module@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Linux API <linux-api@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH 00/21] pipe: Keyrings, Block and USB notifications Date: Tue, 15 Oct 2019 15:32:08 -0700 [thread overview] Message-ID: <CAHk-=whfCy+WCZ5SXZGi4QEhxXm=EjZjj4R9+o4q-QR3saMyfg@mail.gmail.com> (raw) In-Reply-To: <157117606853.15019.15459271147790470307.stgit@warthog.procyon.org.uk> Aside from the two small comments, the pipe side looked reasonable, but I stopped looking when the patches moved on to the notificaiton part, and maybe I missed something in the earlier ones too. Which does bring me to the meat of this email: can we please keep the pipe cleanups and prepwork (and benchmarking) as a separate patch series? I'd like that to be done separately from the notification code, since it's re-organization and cleanup - while the eventual goal is to be able to add messages to the pipe atomically, I think the series makes sense (and should make sense) on its own. Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org> To: David Howells <dhowells@redhat.com> Cc: Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nicolas Dichtel <nicolas.dichtel@6wind.com>, raven@themaw.net, Christian Brauner <christian@brauner.io>, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block <linux-block@vger.kernel.org>, LSM List <linux-security-module@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Linux API <linux-api@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH 00/21] pipe: Keyrings, Block and USB notifications Date: Tue, 15 Oct 2019 22:32:08 +0000 [thread overview] Message-ID: <CAHk-=whfCy+WCZ5SXZGi4QEhxXm=EjZjj4R9+o4q-QR3saMyfg@mail.gmail.com> (raw) In-Reply-To: <157117606853.15019.15459271147790470307.stgit@warthog.procyon.org.uk> Aside from the two small comments, the pipe side looked reasonable, but I stopped looking when the patches moved on to the notificaiton part, and maybe I missed something in the earlier ones too. Which does bring me to the meat of this email: can we please keep the pipe cleanups and prepwork (and benchmarking) as a separate patch series? I'd like that to be done separately from the notification code, since it's re-organization and cleanup - while the eventual goal is to be able to add messages to the pipe atomically, I think the series makes sense (and should make sense) on its own. Linus
next prev parent reply other threads:[~2019-10-15 22:32 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 21:47 [RFC PATCH 00/21] pipe: Keyrings, Block and USB notifications David Howells 2019-10-15 21:47 ` David Howells 2019-10-15 21:47 ` David Howells 2019-10-15 21:47 ` [RFC PATCH 01/21] pipe: Reduce #inclusion of pipe_fs_i.h David Howells 2019-10-15 21:47 ` David Howells 2019-10-15 21:47 ` David Howells 2019-10-15 21:48 ` [RFC PATCH 02/21] Add a prelocked wake-up David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 22:14 ` Linus Torvalds 2019-10-15 22:14 ` Linus Torvalds 2019-10-16 17:02 ` Tim Chen 2019-10-16 17:02 ` Tim Chen 2019-10-15 22:33 ` David Howells 2019-10-15 22:33 ` David Howells 2019-10-16 14:26 ` David Howells 2019-10-16 14:26 ` David Howells 2019-10-16 15:31 ` Linus Torvalds 2019-10-16 15:31 ` Linus Torvalds 2019-10-15 21:48 ` [RFC PATCH 03/21] pipe: Use head and tail pointers for the ring, not cursor and length David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` David Howells 2019-10-16 7:46 ` Rasmus Villemoes 2019-10-16 7:46 ` Rasmus Villemoes 2019-10-17 10:53 ` David Howells 2019-10-17 10:53 ` David Howells 2019-10-15 21:48 ` [RFC PATCH 04/21] pipe: Advance tail pointer inside of wait spinlock in pipe_read() David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` [RFC PATCH 05/21] pipe: Conditionalise wakeup " David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` [RFC PATCH 06/21] pipe: Rearrange sequence in pipe_write() to preallocate slot David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` [RFC PATCH 07/21] pipe: Remove redundant wakeup from pipe_write() David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:48 ` David Howells 2019-10-15 21:49 ` [RFC PATCH 08/21] pipe: Check for ring full inside of the spinlock in pipe_write() David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 22:20 ` Linus Torvalds 2019-10-15 22:20 ` Linus Torvalds 2019-10-15 21:49 ` [RFC PATCH 09/21] uapi: General notification queue definitions David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` [RFC PATCH 10/21] security: Add hooks to rule on setting a watch David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` [RFC PATCH 11/21] security: Add a hook for the point of notification insertion David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` [RFC PATCH 12/21] pipe: Add general notification queue support David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` [RFC PATCH 13/21] keys: Add a notification facility David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` [RFC PATCH 14/21] Add sample notification program David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:49 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 15/21] pipe: Allow buffers to be marked read-whole-or-error for notifications David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 16/21] pipe: Add notification lossage handling David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 17/21] Add a general, global device notification watch list David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 18/21] block: Add block layer notifications David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 19/21] usb: Add USB subsystem notifications David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 20/21] selinux: Implement the watch_key security hook David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` [RFC PATCH 21/21] smack: Implement the watch_key and post_notification hooks David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 21:50 ` David Howells 2019-10-15 22:11 ` [RFC PATCH 00/21] pipe: Keyrings, Block and USB notifications James Morris 2019-10-15 22:11 ` James Morris 2019-10-15 22:11 ` James Morris 2019-10-15 22:32 ` Linus Torvalds [this message] 2019-10-15 22:32 ` Linus Torvalds
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHk-=whfCy+WCZ5SXZGi4QEhxXm=EjZjj4R9+o4q-QR3saMyfg@mail.gmail.com' \ --to=torvalds@linux-foundation.org \ --cc=casey@schaufler-ca.com \ --cc=christian@brauner.io \ --cc=dhowells@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=keyrings@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nicolas.dichtel@6wind.com \ --cc=raven@themaw.net \ --cc=sds@tycho.nsa.gov \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.