All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Joe Perches <joe@perches.com>
Cc: Waiman Long <longman@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	David Rientjes <rientjes@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	David Sterba <dsterba@suse.cz>, Linux-MM <linux-mm@kvack.org>,
	keyrings@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	linux-pm@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-amlogic@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org,
	virtualization@lists.linux-foundation.org,
	Netdev <netdev@vger.kernel.org>,
	linux-ppp@vger.kernel.org,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-cifs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
	ecryptfs@vger.kernel.org, kasan-dev@googlegroups.com,
	linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
	linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	linux-security-module <linux-security-module@vger.kernel.org>,
	linux-integrity@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 13:46:46 -0600	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel@perches.com>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-btrfs@vger.kernel.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	David Sterba <dsterba@suse.cz>,
	David Howells <dhowells@redhat.com>,
	Linux-MM <linux-mm@kvack.org>,
	linux-sctp@vger.kernel.org, keyrings@vger.kernel.org,
	kasan-dev@googlegroups.com,
	linux-stm32@st-md-mailman.stormreply.com,
	devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
	linux-scsi@vger.kernel.org, James Morris <jmorris@namei.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-wpan@vger.kernel.org, David Rientjes <rientjes@google.com>,
	Waiman Long <longman@redhat.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
	linux-fscrypt@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	target-devel@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Netdev <netdev@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	linux-ppp@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 19:46:46 +0000	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel@perches.com>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-btrfs@vger.kernel.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	David Sterba <dsterba@suse.cz>,
	David Howells <dhowells@redhat.com>,
	Linux-MM <linux-mm@kvack.org>,
	linux-sctp@vger.kernel.org, keyrings@vger.kernel.org,
	kasan-dev@googlegroups.com,
	linux-stm32@st-md-mailman.stormreply.com,
	devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
	linux-scsi@vger.kernel.org, James Morris <jmorris@namei.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-wpan@vger.kernel.org, David Rientjes <rientjes@google.com>,
	Waiman Long <longman@redhat.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
	linux-fscrypt@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	target-devel@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Netdev <netdev@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	linux-ppp@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 13:46:46 -0600	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel@perches.com>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-btrfs@vger.kernel.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	David Sterba <dsterba@suse.cz>,
	David Howells <dhowells@redhat.com>,
	Linux-MM <linux-mm@kvack.org>,
	linux-sctp@vger.kernel.org, keyrings@vger.kernel.org,
	kasan-dev@googlegroups.com,
	linux-stm32@st-md-mailman.stormreply.com,
	devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
	linux-scsi@vger.kernel.org, James Morris <jmorris@namei.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-wpan@vger.kernel.org, David Rientjes <rientjes@google.com>,
	Waiman Long <longman@redhat.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
	linux-fscrypt@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	target-devel@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Netdev <netdev@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	linux-ppp@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 13:46:46 -0600	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel@perches.com>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-btrfs@vger.kernel.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	David Sterba <dsterba@suse.cz>,
	David Howells <dhowells@redhat.com>,
	Linux-MM <linux-mm@kvack.org>,
	linux-sctp@vger.kernel.org, keyrings@vger.kernel.org,
	kasan-dev@googlegroups.com,
	linux-stm32@st-md-mailman.stormreply.com,
	devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
	linux-scsi@vger.kernel.org, James Morris <jmorris@namei.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-wpan@vger.kernel.org, David Rientjes <rientjes@google.com>,
	Waiman Long <longman@redhat.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
	linux-fscrypt@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	target-devel@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Netdev <netdev@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	linux-ppp@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 13:46:46 -0600	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel@perches.com>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason-OnJsPKxuuEcAvxtiuMwx3w@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	James Morris <jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>,
	"Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>,
	Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Dan Carpenter
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	David Sterba <dsterba-AlSwsSmVLrQ@public.gmane.org>,
	Linux-MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Crypto Mailing List
	<linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 13:46:46 -0600	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-btrfs@vger.kernel.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	David Sterba <dsterba@suse.cz>,
	David Howells <dhowells@redhat.com>,
	Linux-MM <linux-mm@kvack.org>,
	linux-sctp@vger.kernel.org, keyrings@vger.kernel.org,
	kasan-dev@googlegroups.com,
	linux-stm32@st-md-mailman.stormreply.com,
	devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
	linux-scsi@vger.kernel.org, James Morris <jmorris@namei.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-wpan@vger.kernel.org, David Rientjes <rientjes@google.com>,
	Waiman Long <longman@redhat.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	linux-pm@vger.kernel.org, ecryptfs@vger.kernel.org,
	linux-fscrypt@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	target-devel@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Netdev <netdev@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	linux-ppp@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()
Date: Tue, 16 Jun 2020 13:46:46 -0600	[thread overview]
Message-ID: <CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com> (raw)
In-Reply-To: <fe3b9a437be4aeab3bac68f04193cb6daaa5bee4.camel@perches.com>

On Tue, Jun 16, 2020 at 12:54 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> >  v4:
> >   - Break out the memzero_explicit() change as suggested by Dan Carpenter
> >     so that it can be backported to stable.
> >   - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for
> >     now as there can be a bit more discussion on what is best. It will be
> >     introduced as a separate patch later on after this one is merged.
>
> To this larger audience and last week without reply:
> https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/
>
> Are there _any_ fastpath uses of kfree or vfree?

The networking stack has various places where there will be a quick
kmalloc followed by a kfree for an incoming or outgoing packet. One
place that comes to mind would be esp_alloc_tmp, which does a quick
allocation of some temporary kmalloc memory, processes some packet
things inside of that, and then frees it, sometimes in the same
function, and sometimes later in an async callback. I don't know how
"fastpath" you consider this, but usually packet processing is
something people want to do with minimal overhead, considering how
fast NICs are these days.

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2020-06-16 19:47 UTC|newest]

Thread overview: 203+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16  1:57 [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive() Waiman Long
2020-06-16  1:57 ` Waiman Long
2020-06-16  1:57 ` Waiman Long
2020-06-16  1:57 ` Waiman Long
2020-06-16  1:57 ` Waiman Long
2020-06-16  1:57 ` Waiman Long
2020-06-16  1:57 ` Waiman Long
2020-06-16  1:57 ` [PATCH v4 1/3] mm/slab: Use memzero_explicit() in kzfree() Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  3:30   ` Eric Biggers
2020-06-16  3:30     ` Eric Biggers
2020-06-16  3:30     ` Eric Biggers
2020-06-16  3:30     ` Eric Biggers
2020-06-16  3:30     ` Eric Biggers
2020-06-16  3:30     ` Eric Biggers
2020-06-16  3:30     ` Eric Biggers
2020-06-16 13:05     ` Waiman Long
2020-06-16 13:05       ` Waiman Long
2020-06-16 13:05       ` Waiman Long
2020-06-16 13:05       ` Waiman Long
2020-06-16 13:05       ` Waiman Long
2020-06-16 13:05       ` Waiman Long
2020-06-16 13:05       ` Waiman Long
2020-06-16 15:46     ` David Howells
2020-06-16 15:46       ` David Howells
2020-06-16 15:46       ` David Howells
2020-06-16 15:46       ` David Howells
2020-06-16 15:46       ` David Howells
2020-06-16 15:46       ` David Howells
2020-06-16 15:46       ` David Howells
2020-06-16  6:42   ` Michal Hocko
2020-06-16  6:42     ` Michal Hocko
2020-06-16  6:42     ` Michal Hocko
2020-06-16  6:42     ` Michal Hocko
2020-06-16  6:42     ` Michal Hocko
2020-06-16  6:42     ` Michal Hocko
2020-06-16  6:42     ` Michal Hocko
2020-06-16  9:08     ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  9:08       ` Dan Carpenter
2020-06-16  1:57 ` [PATCH v4 2/3] mm, treewide: Rename kzfree() to kfree_sensitive() Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16 14:26   ` Dan Carpenter
2020-06-16 14:26     ` Dan Carpenter
2020-06-16 14:26     ` Dan Carpenter
2020-06-16 14:26     ` Dan Carpenter
2020-06-16 14:26     ` Dan Carpenter
2020-06-16 14:26     ` Dan Carpenter
2020-06-16 14:26     ` Dan Carpenter
2020-06-16 15:05     ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16  1:57 ` [PATCH v4 3/3] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info() Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16  1:57   ` Waiman Long
2020-06-16 14:48   ` David Sterba
2020-06-16 14:48     ` David Sterba
2020-06-16 14:48     ` David Sterba
2020-06-16 14:48     ` David Sterba
2020-06-16 14:48     ` David Sterba
2020-06-16 14:48     ` David Sterba
2020-06-16 14:48     ` David Sterba
2020-06-16 15:05     ` Waiman Long
2020-06-16 15:05     ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 15:05       ` Waiman Long
2020-06-16 18:53 ` [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive() Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 18:53   ` Joe Perches
2020-06-16 19:43   ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:43     ` Waiman Long
2020-06-16 19:46   ` Jason A. Donenfeld [this message]
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 19:46     ` Jason A. Donenfeld
2020-06-16 20:01   ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 20:01     ` Waiman Long
2020-06-16 21:14   ` Matthew Wilcox
2020-06-16 21:14     ` Matthew Wilcox
2020-06-16 21:14     ` Matthew Wilcox
2020-06-16 21:14     ` Matthew Wilcox
2020-06-16 21:14     ` Matthew Wilcox
2020-06-16 21:14     ` Matthew Wilcox
2020-06-16 21:14     ` Matthew Wilcox
2020-06-16 23:01   ` David Sterba
2020-06-16 23:01     ` David Sterba
2020-06-16 23:01     ` David Sterba
2020-06-16 23:01     ` David Sterba
2020-06-16 23:01     ` David Sterba
2020-06-16 23:01     ` David Sterba
2020-06-16 23:01     ` David Sterba
2020-06-17  0:37     ` Matthew Wilcox
2020-06-17  0:37     ` Matthew Wilcox
2020-06-17  0:37       ` Matthew Wilcox
2020-06-17  0:37       ` Matthew Wilcox
2020-06-17  0:37       ` Matthew Wilcox
2020-06-17  0:37       ` Matthew Wilcox
2020-06-17  0:37       ` Matthew Wilcox
2020-06-17  7:12       ` Michal Hocko
2020-06-17  7:12         ` Michal Hocko
2020-06-17  7:12         ` Michal Hocko
2020-06-17  7:12         ` Michal Hocko
2020-06-17  7:12         ` Michal Hocko
2020-06-17  7:12         ` Michal Hocko
2020-06-17  7:12         ` Michal Hocko
2020-06-17 11:08         ` Matthew Wilcox
2020-06-17 11:08           ` Matthew Wilcox
2020-06-17 11:08           ` Matthew Wilcox
2020-06-17 11:08           ` Matthew Wilcox
2020-06-17 11:08           ` Matthew Wilcox
2020-06-17 11:08           ` Matthew Wilcox
2020-06-17 11:08           ` Matthew Wilcox
2020-06-17 11:31           ` Michal Hocko
2020-06-17 11:31             ` Michal Hocko
2020-06-17 11:31             ` Michal Hocko
2020-06-17 11:31             ` Michal Hocko
2020-06-17 11:31             ` Michal Hocko
2020-06-17 11:31             ` Michal Hocko
2020-06-17 11:31             ` Michal Hocko
2020-06-17 12:23             ` Matthew Wilcox
2020-06-17 12:23               ` Matthew Wilcox
2020-06-17 12:23               ` Matthew Wilcox
2020-06-17 12:23               ` Matthew Wilcox
2020-06-17 12:23               ` Matthew Wilcox
2020-06-17 12:23               ` Matthew Wilcox
2020-06-17 12:23               ` Matthew Wilcox
2020-06-17 12:55               ` Michal Hocko
2020-06-17 12:55                 ` Michal Hocko
2020-06-17 12:55                 ` Michal Hocko
2020-06-17 12:55                 ` Michal Hocko
2020-06-17 12:55                 ` Michal Hocko
2020-06-17 12:55                 ` Michal Hocko
2020-06-17 12:55                 ` Michal Hocko
2020-06-17  8:03       ` Jo -l
2020-06-17  8:03         ` Jo -l
2020-06-17  8:03         ` Jo -l
2020-06-17  8:03         ` Jo -l
2020-06-17  8:03         ` Jo -l
2020-06-17  8:03         ` Jo -l
2020-06-17  8:03         ` Jo -l
2020-06-17 21:31   ` Denis Efremov
2020-06-17 21:31     ` Denis Efremov
2020-06-17 21:31     ` Denis Efremov
2020-06-17 21:31     ` Denis Efremov
2020-06-17 21:31     ` Denis Efremov
2020-06-17 21:31     ` Denis Efremov
2020-06-17 21:31     ` Denis Efremov
2020-06-17 23:12     ` Joe Perches
2020-06-17 23:12       ` Joe Perches
2020-06-17 23:12       ` Joe Perches
2020-06-17 23:12       ` Joe Perches
2020-06-17 23:12       ` Joe Perches
2020-06-17 23:12       ` Joe Perches
2020-06-17 23:12       ` Joe Perches
2020-06-17 23:12       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9rCD1KJNguthAhZ+OAVZTpBwEvGRLRV0tvQjBaEYG1bHQ@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=dhowells@redhat.com \
    --cc=dsterba@suse.cz \
    --cc=ecryptfs@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jmorris@namei.org \
    --cc=joe@perches.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=longman@redhat.com \
    --cc=mhocko@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=serge@hallyn.com \
    --cc=steffen.klassert@secunet.com \
    --cc=target-devel@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.