From: Andy Shevchenko <andy.shevchenko@gmail.com> To: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Calvin Johnson <calvin.johnson@oss.nxp.com>, Grant Likely <grant.likely@arm.com>, Jeremy Linton <jeremy.linton@arm.com>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Cristi Sovaiala <cristian.sovaiala@nxp.com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Ioana Ciornei <ioana.ciornei@nxp.com>, Madalin Bucur <madalin.bucur@oss.nxp.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Jon <jon@solid-run.com>, Diana Madalina Craciun <diana.craciun@nxp.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, netdev <netdev@vger.kernel.org>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, "linux.cj" <linux.cj@gmail.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Randy Dunlap <rdunlap@infradead.org>, Saravana Kannan <saravanak@google.com> Subject: Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id() Date: Wed, 20 Jan 2021 20:45:30 +0200 [thread overview] Message-ID: <CAHp75Vc=b8tXmv7yussXNVKPOovmpKAB1b9cWSAw5rpKDcvLiQ@mail.gmail.com> (raw) In-Reply-To: <CAJZ5v0hic-Yf74Rn06kui4z+KZBES_uiH-pRmmRcFcYjuDZ=CA@mail.gmail.com> On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > On Tue, Jan 12, 2021 at 4:47 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Tue, Jan 12, 2021 at 3:42 PM Calvin Johnson > > <calvin.johnson@oss.nxp.com> wrote: ... > > > +int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id) > > > +{ > > > +#ifdef CONFIG_ACPI > > > + unsigned long long adr; > > > + acpi_status status; > > > +#endif > > > + int ret; > > > + > > > + ret = fwnode_property_read_u32(fwnode, "reg", id); > > > + if (!(ret && is_acpi_node(fwnode))) > > > + return ret; > > > + > > > +#ifdef CONFIG_ACPI > > > + status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode), > > > + METHOD_NAME__ADR, NULL, &adr); > > > + if (ACPI_FAILURE(status)) > > > + return -EINVAL; > > > + *id = (u32)adr; > > > > Shouldn't be > > > > return 0; > > #else > > return -EINVAL; > > #endif > > > > ? > > > > Yes, it's a theoretical case when is_acpi_node() returns true when > > CONFIG_ACPI=n. > > How so? is_acpi_node() is defined as a static inline returning false then. I understand that, that's why it's pure theoretical when, for example, the semantics is changed. But I believe it's unlucky to happen. -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Andrew Lunn <andrew@lunn.ch>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Grant Likely <grant.likely@arm.com>, Calvin Johnson <calvin.johnson@oss.nxp.com>, Ioana Ciornei <ioana.ciornei@nxp.com>, Florian Fainelli <f.fainelli@gmail.com>, Saravana Kannan <saravanak@google.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Jon <jon@solid-run.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Diana Madalina Craciun <diana.craciun@nxp.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Madalin Bucur <madalin.bucur@oss.nxp.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, netdev <netdev@vger.kernel.org>, Randy Dunlap <rdunlap@infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Cristi Sovaiala <cristian.sovaiala@nxp.com>, "linux.cj" <linux.cj@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id() Date: Wed, 20 Jan 2021 20:45:30 +0200 [thread overview] Message-ID: <CAHp75Vc=b8tXmv7yussXNVKPOovmpKAB1b9cWSAw5rpKDcvLiQ@mail.gmail.com> (raw) In-Reply-To: <CAJZ5v0hic-Yf74Rn06kui4z+KZBES_uiH-pRmmRcFcYjuDZ=CA@mail.gmail.com> On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > On Tue, Jan 12, 2021 at 4:47 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Tue, Jan 12, 2021 at 3:42 PM Calvin Johnson > > <calvin.johnson@oss.nxp.com> wrote: ... > > > +int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id) > > > +{ > > > +#ifdef CONFIG_ACPI > > > + unsigned long long adr; > > > + acpi_status status; > > > +#endif > > > + int ret; > > > + > > > + ret = fwnode_property_read_u32(fwnode, "reg", id); > > > + if (!(ret && is_acpi_node(fwnode))) > > > + return ret; > > > + > > > +#ifdef CONFIG_ACPI > > > + status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode), > > > + METHOD_NAME__ADR, NULL, &adr); > > > + if (ACPI_FAILURE(status)) > > > + return -EINVAL; > > > + *id = (u32)adr; > > > > Shouldn't be > > > > return 0; > > #else > > return -EINVAL; > > #endif > > > > ? > > > > Yes, it's a theoretical case when is_acpi_node() returns true when > > CONFIG_ACPI=n. > > How so? is_acpi_node() is defined as a static inline returning false then. I understand that, that's why it's pure theoretical when, for example, the semantics is changed. But I believe it's unlucky to happen. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-20 19:31 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-12 13:40 [net-next PATCH v3 00/15] ACPI support for dpaa2 driver Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-18 22:12 ` Randy Dunlap 2021-01-18 22:12 ` Randy Dunlap 2021-01-12 13:40 ` [net-next PATCH v3 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 15:48 ` Andy Shevchenko 2021-01-12 15:48 ` Andy Shevchenko 2021-01-20 18:17 ` Rafael J. Wysocki 2021-01-20 18:17 ` Rafael J. Wysocki 2021-01-20 18:45 ` Andy Shevchenko [this message] 2021-01-20 18:45 ` Andy Shevchenko 2021-01-20 19:12 ` Rafael J. Wysocki 2021-01-20 19:12 ` Rafael J. Wysocki 2021-01-12 17:30 ` Saravana Kannan 2021-01-12 17:30 ` Saravana Kannan 2021-01-12 18:03 ` Andy Shevchenko 2021-01-12 18:03 ` Andy Shevchenko 2021-01-20 18:18 ` Rafael J. Wysocki 2021-01-20 18:18 ` Rafael J. Wysocki 2021-01-20 18:52 ` Andy Shevchenko 2021-01-20 18:52 ` Andy Shevchenko 2021-01-20 19:15 ` Rafael J. Wysocki 2021-01-20 19:15 ` Rafael J. Wysocki 2021-01-20 20:01 ` Saravana Kannan 2021-01-20 20:01 ` Saravana Kannan 2021-01-22 16:34 ` Rafael J. Wysocki 2021-01-22 16:34 ` Rafael J. Wysocki 2021-01-22 20:58 ` Saravana Kannan 2021-01-22 20:58 ` Saravana Kannan 2021-01-22 21:06 ` Andy Shevchenko 2021-01-22 21:06 ` Andy Shevchenko 2021-01-22 21:07 ` Saravana Kannan 2021-01-22 21:07 ` Saravana Kannan 2021-01-15 10:47 ` Calvin Johnson 2021-01-15 10:47 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 15:52 ` Andy Shevchenko 2021-01-12 15:52 ` Andy Shevchenko 2021-01-12 13:40 ` [net-next PATCH v3 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 15:53 ` Andy Shevchenko 2021-01-12 15:53 ` Andy Shevchenko 2021-01-12 13:40 ` [net-next PATCH v3 13/15] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 15:55 ` Andy Shevchenko 2021-01-12 15:55 ` Andy Shevchenko 2021-01-19 4:05 ` Calvin Johnson 2021-01-19 4:05 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson 2021-01-12 15:57 ` Andy Shevchenko 2021-01-12 15:57 ` Andy Shevchenko 2021-01-19 4:08 ` Calvin Johnson 2021-01-19 4:08 ` Calvin Johnson 2021-01-12 13:40 ` [net-next PATCH v3 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson 2021-01-12 13:40 ` Calvin Johnson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75Vc=b8tXmv7yussXNVKPOovmpKAB1b9cWSAw5rpKDcvLiQ@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=andrew@lunn.ch \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bgolaszewski@baylibre.com \ --cc=calvin.johnson@oss.nxp.com \ --cc=cristian.sovaiala@nxp.com \ --cc=diana.craciun@nxp.com \ --cc=f.fainelli@gmail.com \ --cc=florinlaurentiu.chiculita@nxp.com \ --cc=grant.likely@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=ioana.ciornei@nxp.com \ --cc=jeremy.linton@arm.com \ --cc=jon@solid-run.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=laurentiu.tudor@nxp.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux.cj@gmail.com \ --cc=linux@armlinux.org.uk \ --cc=madalin.bucur@oss.nxp.com \ --cc=mw@semihalf.com \ --cc=netdev@vger.kernel.org \ --cc=pieter.jansenvv@bamboosystems.io \ --cc=rafael@kernel.org \ --cc=rdunlap@infradead.org \ --cc=saravanak@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.