Re: [PATCH v3 12/15] iio: adc: qcom-spmi-adc5: convert to device properties

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	openbmc@lists.ozlabs.org, linux-imx@nxp.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-iio@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	chrome-platform@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	linux-arm-msm@vger.kernel.org,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Patrick Venture" <venture@google.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Nancy Yuen" <yuenn@google.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Christophe Branchereau" <cbranchereau@gmail.com>,
	"Cai Huoqing" <cai.huoqing@linux.dev>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Eugen Hristev" <eugen.hristev@microchip.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Andy Gross" <agross@kernel.org>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Haibo Chen" <haibo.chen@nxp.com>
Subject: Re: [PATCH v3 12/15] iio: adc: qcom-spmi-adc5: convert to device properties
Date: Tue, 17 Jan 2023 11:06:05 +0200	[thread overview]
Message-ID: <CAHp75VdTftm1BE21rH1HVHiwUye-0Dvc66uCK2LE2qF4_zA6hg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdX9sFgn9STyzwcDCK1KYbU00ejFNcEP3FVnLk5J=Pktg@mail.gmail.com>

On Tue, Jan 17, 2023 at 10:53 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Jan 16, 2023 at 10:44 PM Marijn Suijten
> <marijn.suijten@somainline.org> wrote:
> >
> > On 2022-08-06 19:20:48, Jonathan Cameron wrote:
> > > On Fri, 15 Jul 2022 14:29:00 +0200
> > > Nuno Sá <nuno.sa@analog.com> wrote:
> > >
> > > > Make the conversion to firmware agnostic device properties. As part of
> > > > the conversion the IIO inkern interface 'of_xlate()' is also converted to
> > > > 'fwnode_xlate()'. The goal is to completely drop 'of_xlate' and hence OF
> > > > dependencies from IIO.
> > > >
> > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > +CC Marijin who happend to post a patch for this driver that I just accepted
> > > and hence probably has hardware access.  Any chance of a test for this series?
> > >
> > > If not, no problem as this is fairly mechanical and we have testing on some of
> > > the other drivers using the new code.
> > >
> > > I'll probably queue this up in the meantime but it won't end up upstream
> > > for a few weeks yet.
> >
> > Jonathan,
> >
> > This CC just surfaced in my inbox while searching for our current
> > discussion around missing labels in qcom-spmi-vadc - and on the side a
> > userspace @xx label name ABI break (in qcom-spmi-adc5) caused by this
> > patch's fwnode_get_name change - we could've caught it if I had not
> > accidentally marked it as read and/or forgot about it.  My apologies.
>
> Does the following addition to the top of the
> adc5_get_fw_channel_data() fix the issue?
>
> +       name = devm_kasprintf(adc->dev, GFP_KERNEL, "%pfwP", fwnode);
> +       if (!name)
> +               return -ENOMEM;

Okay, it probably the same, so it might need additional code to

+ name[strchrnul(name, '@') - name] = '\0';

-- 
With Best Regards,
Andy Shevchenko