All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org,
	 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	andrew@lunn.ch,  gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com,  ojeda@kernel.org,
	tzimmermann@suse.de, javierm@redhat.com, robin@protonic.nl,
	 lee@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,
	 linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530
Date: Wed, 28 Feb 2024 02:12:05 +0200	[thread overview]
Message-ID: <CAHp75VdXfCp1FRd6JKTB==MkywjPQCvQru=Y02bjSn5nu-WGFA@mail.gmail.com> (raw)
In-Reply-To: <20240227212244.262710-4-chris.packham@alliedtelesis.co.nz>

On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
>
> The Allied Telesis x530 products have a 7 segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7seg device.

Please, be consistent with naming and references. I think the
compatible / driver name are the only two that should be used.

This also needs an Ack from the respective maintainer (I don't know
who that is, you might find in MAINTAINERS, though).

-- 
With Best Regards,
Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org,
	 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	andrew@lunn.ch,  gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com,  ojeda@kernel.org,
	tzimmermann@suse.de, javierm@redhat.com, robin@protonic.nl,
	 lee@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,
	 linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530
Date: Wed, 28 Feb 2024 02:12:05 +0200	[thread overview]
Message-ID: <CAHp75VdXfCp1FRd6JKTB==MkywjPQCvQru=Y02bjSn5nu-WGFA@mail.gmail.com> (raw)
In-Reply-To: <20240227212244.262710-4-chris.packham@alliedtelesis.co.nz>

On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
>
> The Allied Telesis x530 products have a 7 segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7seg device.

Please, be consistent with naming and references. I think the
compatible / driver name are the only two that should be used.

This also needs an Ack from the respective maintainer (I don't know
who that is, you might find in MAINTAINERS, though).

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-28  0:12 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 21:22 [PATCH v2 0/4] auxdisplay: 7 segment LED display Chris Packham
2024-02-27 21:22 ` Chris Packham
2024-02-27 21:22 ` [PATCH v2 1/4] auxdisplay: Add 7 segment LED display driver Chris Packham
2024-02-27 21:22   ` Chris Packham
2024-02-27 22:13   ` Randy Dunlap
2024-02-27 22:13     ` Randy Dunlap
2024-02-27 23:56   ` Andy Shevchenko
2024-02-27 23:56     ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Chris Packham
2024-02-27 21:22   ` Chris Packham
2024-02-27 22:19   ` Rob Herring
2024-02-27 22:19     ` Rob Herring
2024-02-28  0:03   ` Andy Shevchenko
2024-02-28  0:03     ` Andy Shevchenko
2024-02-28  1:53     ` Chris Packham
2024-02-28  1:53       ` Chris Packham
2024-02-28 17:22       ` Andy Shevchenko
2024-02-28 17:22         ` Andy Shevchenko
2024-02-28 14:04   ` Rob Herring
2024-02-28 14:04     ` Rob Herring
2024-02-28 14:57     ` Andy Shevchenko
2024-02-28 14:57       ` Andy Shevchenko
2024-02-29  9:23       ` Geert Uytterhoeven
2024-02-29  9:23         ` Geert Uytterhoeven
2024-02-29 10:42         ` Andy Shevchenko
2024-02-29 10:42           ` Andy Shevchenko
2024-02-28 20:01     ` Chris Packham
2024-02-28 20:01       ` Chris Packham
2024-02-29  9:24       ` Geert Uytterhoeven
2024-02-29  9:24         ` Geert Uytterhoeven
2024-02-29 10:44         ` andy
2024-02-29 10:44           ` andy
2024-02-27 21:22 ` [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530 Chris Packham
2024-02-27 21:22   ` Chris Packham
2024-02-28  0:12   ` Andy Shevchenko [this message]
2024-02-28  0:12     ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 4/4] ARM: dts: marvell: Indicate USB activity " Chris Packham
2024-02-27 21:22   ` Chris Packham
2024-02-28  0:09   ` Andy Shevchenko
2024-02-28  0:09     ` Andy Shevchenko
2024-02-28  1:11     ` Chris Packham
2024-02-28  1:11       ` Chris Packham
2024-02-28  0:05 ` [PATCH v2 0/4] auxdisplay: 7 segment LED display Andy Shevchenko
2024-02-28  0:05   ` Andy Shevchenko
2024-02-28  0:25   ` Chris Packham
2024-02-28  0:25     ` Chris Packham
2024-02-28 18:45     ` Andy Shevchenko
2024-02-28 18:45       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VdXfCp1FRd6JKTB==MkywjPQCvQru=Y02bjSn5nu-WGFA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=andy@kernel.org \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregory.clement@bootlin.com \
    --cc=javierm@redhat.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.