From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Andrzej Hajda <a.hajda@samsung.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Javier Martinez Canillas <javierm@redhat.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Mark Brown <broonie@kernel.org> Subject: Re: [PATCH 2/3] driver core: add deferring probe reason to devices_deferred property Date: Tue, 16 Oct 2018 16:42:41 +0300 [thread overview] Message-ID: <CAHp75VefP2qit3=s9E_uuOg4+J0Zk2OD-XjpVsWM7X3s2g-0wA@mail.gmail.com> (raw) In-Reply-To: <20181016072244.1216-3-a.hajda@samsung.com> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda <a.hajda@samsung.com> wrote: > > /sys/kernel/debug/devices_deferred property contains list of deferred devices. > This list does not contain reason why the driver deferred probe, the patch > improves it. > The natural place to set the reason is probe_err function introduced recently, > ie. if probe_err will be called with -EPROBE_DEFER instead of printk the message > will be attached to deferred device and printed when user read devices_deferred > property. > - if (err != -EPROBE_DEFER) { > - va_start(args, fmt); > + va_start(args, fmt); > > - vaf.fmt = fmt; > - vaf.va = &args; > + vaf.fmt = fmt; > + vaf.va = &args; > > + if (err != -EPROBE_DEFER) > __dev_printk(KERN_ERR, dev, &vaf); > - va_end(args); > - } > + else > + __deferred_probe_set_msg(dev, fmt, args); > + > + va_end(args); Yeah, ping-pong style of programming (one patch "amends" something which had been introduced by another). That's why better to follow my comment for the patch 1. > +/* > + * __deferred_probe_set_msg() - Set defer probe reason message for device > + */ > +void __deferred_probe_set_msg(const struct device *dev, const char *fmt, > + va_list args) > +{ > + const int size = 128; > + char **p; > + int n; > + > + mutex_lock(&deferred_probe_mutex); > + > + p = &dev->p->deferred_probe_msg; > + if (!*p) { > + *p = kmalloc(size, GFP_KERNEL); > + if (!*p) > + goto end; > + } > + n = snprintf(*p, size, "%s %s: ", dev_driver_string(dev), dev_name(dev)); > + if (n < size) > + vsnprintf(*p + n, size - n, fmt, args); Perhaps kasprintf() instead of this huge plays around the size and allocation? > list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe) > - seq_printf(s, "%s\n", dev_name(curr->device)); > + if (curr->device->p->deferred_probe_msg) > + seq_puts(s, curr->device->p->deferred_probe_msg); > + else > + seq_printf(s, "%s\n", dev_name(curr->device)); I wouldn't care (much) about debugfs, though better to keep some order here, i.e. always print device name. Something like seq_printf(s, "%s\t%s\n", dev_name(), deferred_probe_msg ?: ""); and remove that part from above __deferred_probe_set_msg(). -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] driver core: add deferring probe reason to devices_deferred property Date: Tue, 16 Oct 2018 16:42:41 +0300 [thread overview] Message-ID: <CAHp75VefP2qit3=s9E_uuOg4+J0Zk2OD-XjpVsWM7X3s2g-0wA@mail.gmail.com> (raw) In-Reply-To: <20181016072244.1216-3-a.hajda@samsung.com> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda <a.hajda@samsung.com> wrote: > > /sys/kernel/debug/devices_deferred property contains list of deferred devices. > This list does not contain reason why the driver deferred probe, the patch > improves it. > The natural place to set the reason is probe_err function introduced recently, > ie. if probe_err will be called with -EPROBE_DEFER instead of printk the message > will be attached to deferred device and printed when user read devices_deferred > property. > - if (err != -EPROBE_DEFER) { > - va_start(args, fmt); > + va_start(args, fmt); > > - vaf.fmt = fmt; > - vaf.va = &args; > + vaf.fmt = fmt; > + vaf.va = &args; > > + if (err != -EPROBE_DEFER) > __dev_printk(KERN_ERR, dev, &vaf); > - va_end(args); > - } > + else > + __deferred_probe_set_msg(dev, fmt, args); > + > + va_end(args); Yeah, ping-pong style of programming (one patch "amends" something which had been introduced by another). That's why better to follow my comment for the patch 1. > +/* > + * __deferred_probe_set_msg() - Set defer probe reason message for device > + */ > +void __deferred_probe_set_msg(const struct device *dev, const char *fmt, > + va_list args) > +{ > + const int size = 128; > + char **p; > + int n; > + > + mutex_lock(&deferred_probe_mutex); > + > + p = &dev->p->deferred_probe_msg; > + if (!*p) { > + *p = kmalloc(size, GFP_KERNEL); > + if (!*p) > + goto end; > + } > + n = snprintf(*p, size, "%s %s: ", dev_driver_string(dev), dev_name(dev)); > + if (n < size) > + vsnprintf(*p + n, size - n, fmt, args); Perhaps kasprintf() instead of this huge plays around the size and allocation? > list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe) > - seq_printf(s, "%s\n", dev_name(curr->device)); > + if (curr->device->p->deferred_probe_msg) > + seq_puts(s, curr->device->p->deferred_probe_msg); > + else > + seq_printf(s, "%s\n", dev_name(curr->device)); I wouldn't care (much) about debugfs, though better to keep some order here, i.e. always print device name. Something like seq_printf(s, "%s\t%s\n", dev_name(), deferred_probe_msg ?: ""); and remove that part from above __deferred_probe_set_msg(). -- With Best Regards, Andy Shevchenko
next prev parent reply other threads:[~2018-10-16 13:42 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20181016072248eucas1p18943ce87e084797cd597afd4edb65a65@eucas1p1.samsung.com> 2018-10-16 7:22 ` [PATCH 0/3] driver core: add probe error check helper Andrzej Hajda 2018-10-16 7:22 ` Andrzej Hajda [not found] ` <CGME20181016072249eucas1p2303b8c06a9f7c839a971fe065b0c752e@eucas1p2.samsung.com> 2018-10-16 7:22 ` [PATCH 1/3] driver core: add probe_err log helper Andrzej Hajda 2018-10-16 7:22 ` Andrzej Hajda 2018-10-16 9:32 ` Javier Martinez Canillas 2018-10-16 9:32 ` Javier Martinez Canillas 2018-10-16 10:27 ` Mark Brown 2018-10-16 10:27 ` Mark Brown 2018-10-16 11:09 ` Greg Kroah-Hartman 2018-10-16 11:09 ` Greg Kroah-Hartman 2018-10-16 11:01 ` Andy Shevchenko 2018-10-16 11:01 ` Andy Shevchenko 2018-10-16 11:29 ` Andrzej Hajda 2018-10-16 11:29 ` Andrzej Hajda [not found] ` <605bd00e-ed0d-4259-bdc3-1784b2b3b16a@samsung.com> 2018-10-16 12:55 ` Andrzej Hajda 2018-10-16 12:55 ` Andrzej Hajda 2018-10-16 13:55 ` Andy Shevchenko 2018-10-16 13:55 ` Andy Shevchenko [not found] ` <CGME20181017085832eucas1p23dbb86230149a13634b8a091c3b1301f@eucas1p2.samsung.com> 2018-10-17 8:58 ` [PATCH v2 " Andrzej Hajda 2018-10-17 8:58 ` Andrzej Hajda 2018-10-17 9:56 ` Mark Brown 2018-10-17 9:56 ` Mark Brown 2018-10-17 11:30 ` Andy Shevchenko 2018-10-17 11:30 ` Andy Shevchenko 2018-10-17 11:49 ` Greg Kroah-Hartman 2018-10-17 11:49 ` Greg Kroah-Hartman 2018-10-17 11:29 ` [PATCH " Russell King - ARM Linux 2018-10-17 11:29 ` Russell King - ARM Linux 2018-10-17 11:33 ` Andy Shevchenko 2018-10-17 11:33 ` Andy Shevchenko [not found] ` <CGME20181017132209eucas1p1d23615adc15663caaffb3c117dc61151@eucas1p1.samsung.com> 2018-10-17 13:22 ` [PATCH v3 1/4] " Andrzej Hajda 2018-10-17 13:22 ` Andrzej Hajda 2018-10-18 1:45 ` [PATCH 1/3] " Joe Perches 2018-10-18 1:45 ` Joe Perches [not found] ` <CGME20181016072249eucas1p28855602564eb74a771fe521712962680@eucas1p2.samsung.com> 2018-10-16 7:22 ` [PATCH 2/3] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda 2018-10-16 7:22 ` Andrzej Hajda 2018-10-16 9:25 ` Mark Brown 2018-10-16 9:47 ` Javier Martinez Canillas 2018-10-16 9:47 ` Javier Martinez Canillas 2018-10-16 13:42 ` Andy Shevchenko [this message] 2018-10-16 13:42 ` Andy Shevchenko [not found] ` <CGME20181017085952eucas1p2ff93b96d300aab2dc70b97bf266978ab@eucas1p2.samsung.com> 2018-10-17 8:59 ` [PATCH v2 " Andrzej Hajda 2018-10-17 8:59 ` Andrzej Hajda 2018-10-17 11:35 ` Andy Shevchenko 2018-10-17 11:35 ` Andy Shevchenko [not found] ` <CGME20181017132404eucas1p2a413f6853af8f11a874650b6289d56cf@eucas1p2.samsung.com> 2018-10-17 13:24 ` [PATCH v3 2/4] " Andrzej Hajda 2018-10-17 13:24 ` Andrzej Hajda 2018-10-17 14:17 ` Andy Shevchenko 2018-10-17 14:17 ` Andy Shevchenko [not found] ` <CGME20181018064916eucas1p22f03a19eb09cecdb0061dc5a4bf99ce6@eucas1p2.samsung.com> 2018-10-18 6:49 ` [PATCH v4 2/3] " Andrzej Hajda 2018-10-18 6:49 ` Andrzej Hajda [not found] ` <CGME20181016072250eucas1p1a763670c8509d20a6e6847eadb246817@eucas1p1.samsung.com> 2018-10-16 7:22 ` [PATCH 3/3] drivers: use probe_err function in obvious cases Andrzej Hajda 2018-10-16 9:52 ` Javier Martinez Canillas 2018-10-16 9:52 ` Javier Martinez Canillas 2018-10-16 13:51 ` Andy Shevchenko 2018-10-16 13:51 ` Andy Shevchenko 2018-10-17 9:10 ` Andrzej Hajda 2018-10-17 9:10 ` Andrzej Hajda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75VefP2qit3=s9E_uuOg4+J0Zk2OD-XjpVsWM7X3s2g-0wA@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=a.hajda@samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=javierm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=rafael@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.