From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>,
Yisheng Xie <xieyisheng1@huawei.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] console/fbcon: Add support for deferred console takeover
Date: Tue, 26 Jun 2018 21:49:33 +0300 [thread overview]
Message-ID: <CAHp75Vf2x00AdgWj_zuKGkkBGV8HiZHrfHeMx+AAx0ToaxMF4A@mail.gmail.com> (raw)
In-Reply-To: <ad0becb1-eece-b89c-c77f-273403052491@redhat.com>
On Tue, Jun 26, 2018 at 9:29 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>> + for (i = 0; i < FB_MAX; i++) {
>>> + if (registered_fb[i])
>>> + fbcon_fb_registered(registered_fb[i]);
>>> + }
>> Simple git grep shows that we perhaps do
>>
>> #define for_each_registered_fbcon(i) ...
>>
>> (As an example see for_each_pci_bridge() how it's done there)
>
>
> This is probably a worthwhile cleanup for all the fbdev related
> code / drivers. But outside of the scope of this patchset.
True.
Yisheng, in case you are interested in doing such clean up...
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>,
Yisheng Xie <xieyisheng1@huawei.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 3/3] console/fbcon: Add support for deferred console takeover
Date: Tue, 26 Jun 2018 18:49:33 +0000 [thread overview]
Message-ID: <CAHp75Vf2x00AdgWj_zuKGkkBGV8HiZHrfHeMx+AAx0ToaxMF4A@mail.gmail.com> (raw)
In-Reply-To: <ad0becb1-eece-b89c-c77f-273403052491@redhat.com>
On Tue, Jun 26, 2018 at 9:29 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>> + for (i = 0; i < FB_MAX; i++) {
>>> + if (registered_fb[i])
>>> + fbcon_fb_registered(registered_fb[i]);
>>> + }
>> Simple git grep shows that we perhaps do
>>
>> #define for_each_registered_fbcon(i) ...
>>
>> (As an example see for_each_pci_bridge() how it's done there)
>
>
> This is probably a worthwhile cleanup for all the fbdev related
> code / drivers. But outside of the scope of this patchset.
True.
Yisheng, in case you are interested in doing such clean up...
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>,
Yisheng Xie <xieyisheng1@huawei.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 3/3] console/fbcon: Add support for deferred console takeover
Date: Tue, 26 Jun 2018 21:49:33 +0300 [thread overview]
Message-ID: <CAHp75Vf2x00AdgWj_zuKGkkBGV8HiZHrfHeMx+AAx0ToaxMF4A@mail.gmail.com> (raw)
In-Reply-To: <ad0becb1-eece-b89c-c77f-273403052491@redhat.com>
On Tue, Jun 26, 2018 at 9:29 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>> + for (i = 0; i < FB_MAX; i++) {
>>> + if (registered_fb[i])
>>> + fbcon_fb_registered(registered_fb[i]);
>>> + }
>> Simple git grep shows that we perhaps do
>>
>> #define for_each_registered_fbcon(i) ...
>>
>> (As an example see for_each_pci_bridge() how it's done there)
>
>
> This is probably a worthwhile cleanup for all the fbdev related
> code / drivers. But outside of the scope of this patchset.
True.
Yisheng, in case you are interested in doing such clean up...
--
With Best Regards,
Andy Shevchenko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-26 18:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:55 [PATCH v3 0/3] console/fbcon: Add support for deferred console takeover Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 13:55 ` [PATCH v3 1/3] printk: Export is_console_locked Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 13:55 ` [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 14:00 ` Daniel Vetter
2018-06-26 14:00 ` Daniel Vetter
2018-06-26 14:00 ` Daniel Vetter
2018-06-26 14:47 ` Steven Rostedt
2018-06-26 14:47 ` Steven Rostedt
2018-06-26 14:47 ` Steven Rostedt
2018-06-26 18:29 ` Hans de Goede
2018-06-26 18:29 ` Hans de Goede
2018-06-26 18:29 ` Hans de Goede
2018-06-26 13:55 ` [PATCH v3 3/3] console/fbcon: Add support for deferred console takeover Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 13:55 ` Hans de Goede
2018-06-26 17:12 ` Andy Shevchenko
2018-06-26 17:12 ` Andy Shevchenko
2018-06-26 17:12 ` Andy Shevchenko
2018-06-26 17:13 ` Andy Shevchenko
2018-06-26 17:13 ` Andy Shevchenko
2018-06-26 17:13 ` Andy Shevchenko
2018-06-26 18:29 ` Hans de Goede
2018-06-26 18:29 ` Hans de Goede
2018-06-26 18:29 ` Hans de Goede
2018-06-26 18:49 ` Andy Shevchenko [this message]
2018-06-26 18:49 ` Andy Shevchenko
2018-06-26 18:49 ` Andy Shevchenko
2018-06-26 18:36 [PATCH v4 0/3] " Hans de Goede
2018-06-26 18:36 ` [PATCH v3 3/3] " Hans de Goede
2018-06-26 18:36 ` Hans de Goede
2018-06-26 18:36 ` Hans de Goede
2018-06-28 7:55 ` Daniel Vetter
2018-06-28 7:55 ` Daniel Vetter
2018-06-28 7:55 ` Daniel Vetter
2018-06-28 8:20 ` Hans de Goede
2018-06-28 8:20 ` Hans de Goede
2018-06-28 8:20 ` Hans de Goede
2018-06-28 8:37 ` Daniel Vetter
2018-06-28 8:37 ` Daniel Vetter
2018-06-28 8:37 ` Daniel Vetter
2018-06-28 8:58 ` Hans de Goede
2018-06-28 8:58 ` Hans de Goede
2018-06-28 8:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf2x00AdgWj_zuKGkkBGV8HiZHrfHeMx+AAx0ToaxMF4A@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.