From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
James Cameron <quozl@laptop.org>,
Mark Rutland <mark.rutland@arm.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 07/15] Platform: OLPC: Use BIT() and GENMASK() for event masks
Date: Wed, 9 Jan 2019 13:14:08 +0200 [thread overview]
Message-ID: <CAHp75Vf=B4TxZ5ETXaezQAm3HGzQ6cNkApwxq+3_fw92phumkw@mail.gmail.com> (raw)
In-Reply-To: <20190108175818.705110-8-lkundrak@v3.sk>
On Tue, Jan 8, 2019 at 7:58 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Just a cosmetic tidy-up.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - This patch was added to the set.
>
> include/linux/olpc-ec.h | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
> index e28f72416a57..c4602364e909 100644
> --- a/include/linux/olpc-ec.h
> +++ b/include/linux/olpc-ec.h
> @@ -2,6 +2,8 @@
> #ifndef _LINUX_OLPC_EC_H
> #define _LINUX_OLPC_EC_H
>
> +#include <linux/bits.h>
> +
> /* XO-1 EC commands */
> #define EC_FIRMWARE_REV 0x08
> #define EC_WRITE_SCI_MASK 0x1b
> @@ -17,17 +19,16 @@
> #define EC_EXT_SCI_QUERY 0x85
>
> /* SCI source values */
> -#define EC_SCI_SRC_EMPTY 0x00
> -#define EC_SCI_SRC_GAME 0x01
> -#define EC_SCI_SRC_BATTERY 0x02
> -#define EC_SCI_SRC_BATSOC 0x04
> -#define EC_SCI_SRC_BATERR 0x08
> -#define EC_SCI_SRC_EBOOK 0x10 /* XO-1 only */
> -#define EC_SCI_SRC_WLAN 0x20 /* XO-1 only */
> -#define EC_SCI_SRC_ACPWR 0x40
> -#define EC_SCI_SRC_BATCRIT 0x80
> -#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
> -#define EC_SCI_SRC_ALL 0x1FF
> +#define EC_SCI_SRC_GAME BIT(0)
> +#define EC_SCI_SRC_BATTERY BIT(1)
> +#define EC_SCI_SRC_BATSOC BIT(2)
> +#define EC_SCI_SRC_BATERR BIT(3)
> +#define EC_SCI_SRC_EBOOK BIT(4) /* XO-1 only */
> +#define EC_SCI_SRC_WLAN BIT(5) /* XO-1 only */
> +#define EC_SCI_SRC_ACPWR BIT(6)
> +#define EC_SCI_SRC_BATCRIT BIT(7)
> +#define EC_SCI_SRC_GPWAKE BIT(8) /* XO-1.5 only */
> +#define EC_SCI_SRC_ALL GENMASK(8, 0)
>
> struct platform_device;
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
James Cameron <quozl@laptop.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Russell King <linux@armlinux.org.uk>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v4 07/15] Platform: OLPC: Use BIT() and GENMASK() for event masks
Date: Wed, 9 Jan 2019 13:14:08 +0200 [thread overview]
Message-ID: <CAHp75Vf=B4TxZ5ETXaezQAm3HGzQ6cNkApwxq+3_fw92phumkw@mail.gmail.com> (raw)
In-Reply-To: <20190108175818.705110-8-lkundrak@v3.sk>
On Tue, Jan 8, 2019 at 7:58 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Just a cosmetic tidy-up.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - This patch was added to the set.
>
> include/linux/olpc-ec.h | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
> index e28f72416a57..c4602364e909 100644
> --- a/include/linux/olpc-ec.h
> +++ b/include/linux/olpc-ec.h
> @@ -2,6 +2,8 @@
> #ifndef _LINUX_OLPC_EC_H
> #define _LINUX_OLPC_EC_H
>
> +#include <linux/bits.h>
> +
> /* XO-1 EC commands */
> #define EC_FIRMWARE_REV 0x08
> #define EC_WRITE_SCI_MASK 0x1b
> @@ -17,17 +19,16 @@
> #define EC_EXT_SCI_QUERY 0x85
>
> /* SCI source values */
> -#define EC_SCI_SRC_EMPTY 0x00
> -#define EC_SCI_SRC_GAME 0x01
> -#define EC_SCI_SRC_BATTERY 0x02
> -#define EC_SCI_SRC_BATSOC 0x04
> -#define EC_SCI_SRC_BATERR 0x08
> -#define EC_SCI_SRC_EBOOK 0x10 /* XO-1 only */
> -#define EC_SCI_SRC_WLAN 0x20 /* XO-1 only */
> -#define EC_SCI_SRC_ACPWR 0x40
> -#define EC_SCI_SRC_BATCRIT 0x80
> -#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
> -#define EC_SCI_SRC_ALL 0x1FF
> +#define EC_SCI_SRC_GAME BIT(0)
> +#define EC_SCI_SRC_BATTERY BIT(1)
> +#define EC_SCI_SRC_BATSOC BIT(2)
> +#define EC_SCI_SRC_BATERR BIT(3)
> +#define EC_SCI_SRC_EBOOK BIT(4) /* XO-1 only */
> +#define EC_SCI_SRC_WLAN BIT(5) /* XO-1 only */
> +#define EC_SCI_SRC_ACPWR BIT(6)
> +#define EC_SCI_SRC_BATCRIT BIT(7)
> +#define EC_SCI_SRC_GPWAKE BIT(8) /* XO-1.5 only */
> +#define EC_SCI_SRC_ALL GENMASK(8, 0)
>
> struct platform_device;
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
James Cameron <quozl@laptop.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)"
<x86@kernel.org>, Russell King <linux@armlinux.org.uk>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v4 07/15] Platform: OLPC: Use BIT() and GENMASK() for event masks
Date: Wed, 9 Jan 2019 13:14:08 +0200 [thread overview]
Message-ID: <CAHp75Vf=B4TxZ5ETXaezQAm3HGzQ6cNkApwxq+3_fw92phumkw@mail.gmail.com> (raw)
In-Reply-To: <20190108175818.705110-8-lkundrak@v3.sk>
On Tue, Jan 8, 2019 at 7:58 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Just a cosmetic tidy-up.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - This patch was added to the set.
>
> include/linux/olpc-ec.h | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
> index e28f72416a57..c4602364e909 100644
> --- a/include/linux/olpc-ec.h
> +++ b/include/linux/olpc-ec.h
> @@ -2,6 +2,8 @@
> #ifndef _LINUX_OLPC_EC_H
> #define _LINUX_OLPC_EC_H
>
> +#include <linux/bits.h>
> +
> /* XO-1 EC commands */
> #define EC_FIRMWARE_REV 0x08
> #define EC_WRITE_SCI_MASK 0x1b
> @@ -17,17 +19,16 @@
> #define EC_EXT_SCI_QUERY 0x85
>
> /* SCI source values */
> -#define EC_SCI_SRC_EMPTY 0x00
> -#define EC_SCI_SRC_GAME 0x01
> -#define EC_SCI_SRC_BATTERY 0x02
> -#define EC_SCI_SRC_BATSOC 0x04
> -#define EC_SCI_SRC_BATERR 0x08
> -#define EC_SCI_SRC_EBOOK 0x10 /* XO-1 only */
> -#define EC_SCI_SRC_WLAN 0x20 /* XO-1 only */
> -#define EC_SCI_SRC_ACPWR 0x40
> -#define EC_SCI_SRC_BATCRIT 0x80
> -#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
> -#define EC_SCI_SRC_ALL 0x1FF
> +#define EC_SCI_SRC_GAME BIT(0)
> +#define EC_SCI_SRC_BATTERY BIT(1)
> +#define EC_SCI_SRC_BATSOC BIT(2)
> +#define EC_SCI_SRC_BATERR BIT(3)
> +#define EC_SCI_SRC_EBOOK BIT(4) /* XO-1 only */
> +#define EC_SCI_SRC_WLAN BIT(5) /* XO-1 only */
> +#define EC_SCI_SRC_ACPWR BIT(6)
> +#define EC_SCI_SRC_BATCRIT BIT(7)
> +#define EC_SCI_SRC_GPWAKE BIT(8) /* XO-1.5 only */
> +#define EC_SCI_SRC_ALL GENMASK(8, 0)
>
> struct platform_device;
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-09 11:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 17:58 [PATCH v4 00/15] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 01/15] ARM: export arm_pm_restart() Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 23:31 ` Russell King - ARM Linux
2019-01-08 23:31 ` Russell King - ARM Linux
2019-01-09 7:24 ` Lubomir Rintel
2019-01-09 7:24 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 02/15] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 02/15] dt-bindings: olpc, xo1.75-ec: " Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 03/15] Platform: OLPC: Remove an unused include Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 04/15] Platform: OLPC: Add XO-1.75 EC driver Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 05/15] Platform: OLPC: Avoid a warning if the EC didn't register yet Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 06/15] Platform: OLPC: Move EC-specific functionality out from x86 Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-09 11:23 ` Andy Shevchenko
2019-01-09 11:23 ` Andy Shevchenko
2019-01-10 17:12 ` Lubomir Rintel
2019-01-10 17:12 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 07/15] Platform: OLPC: Use BIT() and GENMASK() for event masks Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-09 11:14 ` Andy Shevchenko [this message]
2019-01-09 11:14 ` Andy Shevchenko
2019-01-09 11:14 ` Andy Shevchenko
2019-01-08 17:58 ` [PATCH v4 08/15] Platform: OLPC: add a regulator for the DCON Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 09/15] dt-bindings: olpc_battery: Add XO-1.5 battery Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 10/15] x86, olpc: Use a correct version when making up a battery node Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 11/15] power: supply: olpc_battery: Use DT to get battery version Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 12/15] power: supply: olpc_battery: Move priv data to a struct Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 13/15] power: supply: olpc_battery: Use devm_power_supply_register() Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 14/15] power: supply: olpc_battery: Avoid using platform_info Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-08 17:58 ` [PATCH v4 15/15] power: supply: olpc_battery: Add OLPC XO 1.75 support Lubomir Rintel
2019-01-08 17:58 ` Lubomir Rintel
2019-01-09 11:15 ` [PATCH v4 00/15] Add support for OLPC XO 1.75 Embedded Controller Andy Shevchenko
2019-01-09 11:15 ` Andy Shevchenko
2019-01-09 16:37 ` Lubomir Rintel
2019-01-09 16:37 ` Lubomir Rintel
2019-01-10 10:08 ` Andy Shevchenko
2019-01-10 10:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vf=B4TxZ5ETXaezQAm3HGzQ6cNkApwxq+3_fw92phumkw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quozl@laptop.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.