From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Robert Foss <robert.foss@linaro.org>,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Tomasz Figa <tfiga@chromium.org>,
linux-media <linux-media@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v2 2/3] media: ov8856: Add devicetree support
Date: Tue, 31 Mar 2020 16:53:53 +0300 [thread overview]
Message-ID: <CAHp75VfGx0psWk-4Dc-E=HL9Gz_Cz3T46L_nsqrehVLQgkqViA@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5DHBCJbfS2Lt7R-3J_TUJi1is2Xn6n5iZkRwvmn5i6Dmg@mail.gmail.com>
On Tue, Mar 31, 2020 at 4:43 PM Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Mar 31, 2020 at 10:37 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> > After testing this change, it breaks the driver during probing.
>
> Why exactly does it break probing? Maybe the GPIO polarity defined in
> the device tree is wrong?
>
> > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they
> > seem to never be 0 or 1.
>
> If you do a grep in all gpiod_set_value_cansleep() usages in the
> kernel tree, there is not a single case where GPIOD_OUT_HIGH or
> GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep().
+1. It simple reveals the problem that is somewhere else.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Robert Foss <robert.foss@linaro.org>,
Tomasz Figa <tfiga@chromium.org>,
Sakari Ailus <sakari.ailus@iki.fi>,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [v2 2/3] media: ov8856: Add devicetree support
Date: Tue, 31 Mar 2020 16:53:53 +0300 [thread overview]
Message-ID: <CAHp75VfGx0psWk-4Dc-E=HL9Gz_Cz3T46L_nsqrehVLQgkqViA@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5DHBCJbfS2Lt7R-3J_TUJi1is2Xn6n5iZkRwvmn5i6Dmg@mail.gmail.com>
On Tue, Mar 31, 2020 at 4:43 PM Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Mar 31, 2020 at 10:37 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> > After testing this change, it breaks the driver during probing.
>
> Why exactly does it break probing? Maybe the GPIO polarity defined in
> the device tree is wrong?
>
> > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they
> > seem to never be 0 or 1.
>
> If you do a grep in all gpiod_set_value_cansleep() usages in the
> kernel tree, there is not a single case where GPIOD_OUT_HIGH or
> GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep().
+1. It simple reveals the problem that is somewhere else.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-31 13:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 11:03 [v2 0/3] media: ov8856: Add devicetree support Robert Foss
2020-03-13 11:03 ` Robert Foss
2020-03-13 11:03 ` [v2 1/3] media: dt-bindings: ov8856: Document YAML bindings Robert Foss
2020-03-13 11:03 ` Robert Foss
2020-03-13 12:19 ` Sakari Ailus
2020-03-13 12:19 ` Sakari Ailus
2020-03-13 22:00 ` Rob Herring
2020-03-13 22:00 ` Rob Herring
2020-03-13 11:03 ` [v2 2/3] media: ov8856: Add devicetree support Robert Foss
2020-03-13 11:03 ` Robert Foss
2020-03-13 12:17 ` Sakari Ailus
2020-03-13 12:17 ` Sakari Ailus
2020-03-26 11:56 ` Robert Foss
2020-03-26 11:56 ` Robert Foss
2020-03-26 14:47 ` Sakari Ailus
2020-03-26 14:47 ` Sakari Ailus
2020-03-27 10:32 ` Robert Foss
2020-03-27 10:32 ` Robert Foss
2020-03-27 13:37 ` Sakari Ailus
2020-03-27 13:37 ` Sakari Ailus
2020-03-13 12:28 ` Andy Shevchenko
2020-03-13 12:28 ` Andy Shevchenko
2020-03-13 13:15 ` Fabio Estevam
2020-03-13 13:15 ` Fabio Estevam
2020-03-31 13:37 ` Robert Foss
2020-03-31 13:37 ` Robert Foss
2020-03-31 13:42 ` Fabio Estevam
2020-03-31 13:42 ` Fabio Estevam
2020-03-31 13:53 ` Andy Shevchenko [this message]
2020-03-31 13:53 ` Andy Shevchenko
2020-03-13 11:03 ` [v2 3/3] media: ov8856: Implement sensor module revision identification Robert Foss
2020-03-13 11:03 ` Robert Foss
2020-03-13 12:43 ` Sakari Ailus
2020-03-13 12:43 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfGx0psWk-4Dc-E=HL9Gz_Cz3T46L_nsqrehVLQgkqViA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robert.foss@linaro.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.