From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mark Pearson <markpearson@lenovo.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: correct palmsensor error checking
Date: Mon, 4 Jan 2021 17:17:12 +0200 [thread overview]
Message-ID: <CAHp75VfS3hAJ+vP54V+80zzWVW-+vYK-gGocRMrQhHkWnPXzXg@mail.gmail.com> (raw)
In-Reply-To: <20201230024726.7861-1-markpearson@lenovo.com>
On Wed, Dec 30, 2020 at 4:54 AM Mark Pearson <markpearson@lenovo.com> wrote:
>
> The previous commit adding functionality for the palm sensor had a
> mistake which meant the error conditions on initialisation was not checked
> correctly. On some older platforms this meant that if the sensor wasn't
> available an error would be returned and the driver would fail to load.
> This commit corrects the error condition. Many thanks to Mario Oenning
> for reporting and determining the issue
Hint to the future (maybe Hans will fix this while it's in his review queue):
we have a Reported-by tag. Of course if a person would like to avoid
it, then it's fine.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-04 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 2:47 [PATCH] platform/x86: thinkpad_acpi: correct palmsensor error checking Mark Pearson
2021-01-04 14:56 ` Hans de Goede
2021-01-04 15:17 ` Andy Shevchenko [this message]
2021-01-04 15:32 ` Hans de Goede
2021-01-04 15:43 ` [External] " Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfS3hAJ+vP54V+80zzWVW-+vYK-gGocRMrQhHkWnPXzXg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.