From: Mark Pearson <markpearson@lenovo.com>
To: Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mark Gross <mgross@linux.intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [External] Re: [PATCH] platform/x86: thinkpad_acpi: correct palmsensor error checking
Date: Mon, 4 Jan 2021 10:43:36 -0500 [thread overview]
Message-ID: <e9f57686-bdd1-89eb-622f-851b26e35f17@lenovo.com> (raw)
In-Reply-To: <c99cbd33-4969-568a-205d-52c53509e586@redhat.com>
On 04/01/2021 10:32, Hans de Goede wrote:
> Hi,
>
> On 1/4/21 4:17 PM, Andy Shevchenko wrote:
>> On Wed, Dec 30, 2020 at 4:54 AM Mark Pearson
>> <markpearson@lenovo.com> wrote:
>>>
>>> The previous commit adding functionality for the palm sensor had
>>> a mistake which meant the error conditions on initialisation was
>>> not checked correctly. On some older platforms this meant that if
>>> the sensor wasn't available an error would be returned and the
>>> driver would fail to load.
>>
>>> This commit corrects the error condition. Many thanks to Mario
>>> Oenning for reporting and determining the issue
>>
>> Hint to the future (maybe Hans will fix this while it's in his
>> review queue): we have a Reported-by tag. Of course if a person
>> would like to avoid it, then it's fine.
>
> I did notice this too, but I did not fix it. For future patches the
> right thing to do is to ask the reporter if he is ok with a
> Reported-by tag being added (which will expose their email to the
> world) and then proceed depending on their answer, at least that is
> what I usually do. Although sometimes I do just add the Reported-by
> tag, esp. if the email has been send to a (couple of) lists, so the
> email already has been exposed to a large audience.
>
Ack - thanks all. I wasn't aware of the reported-by etiquette :)
Probably a good one to know about....I'm sure this won't be the last
issue reported against a Lenovo system!
Mark
prev parent reply other threads:[~2021-01-04 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 2:47 [PATCH] platform/x86: thinkpad_acpi: correct palmsensor error checking Mark Pearson
2021-01-04 14:56 ` Hans de Goede
2021-01-04 15:17 ` Andy Shevchenko
2021-01-04 15:32 ` Hans de Goede
2021-01-04 15:43 ` Mark Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f57686-bdd1-89eb-622f-851b26e35f17@lenovo.com \
--to=markpearson@lenovo.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.